Received-SPF: pass (google.com: domain of linux-kernel+bounces-209201-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <f2cd7136-889d-4a3c-b029-07a8c18ef589@intel.com>
Date: Tue, 11 Jun 2024 10:53:17 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH 2/2] KVM: x86: Enable guest SSP read/write interface
 with new uAPIs
To: Sean Christopherson <seanjc@google.com>
CC: <pbonzini@redhat.com>, <mlevitsk@redhat.com>, <kvm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
References: <20240509075423.156858-1-weijiang.yang@intel.com>
 <20240509075423.156858-2-weijiang.yang@intel.com>
 <ZmelpPm5YfGifhIj@google.com>
Content-Language: en-US
From: "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <ZmelpPm5YfGifhIj@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTZmZFVBeUdTL2hEVURmREpTb0ZNbDE0a2VhUUxMV0lGNk0xMTgrUm5NcVEv?=
 =?utf-8?B?dFZTNkZmcTVTelJEVE5wMjRhWVg0U2RUTXY0N3J5U1p1Uk9uNGFNcTZ3OU1T?=
 =?utf-8?B?OUNKdDNYZjMvNXlGc21YYW0wampJeXRVRGg5YVZFS2Y1ektSOG4zK3ZZemJC?=
 =?utf-8?B?NkR5SGkxWEtJMVFFbnJERDdZNlJKUzlxYzhXUWNPNUZVa0w2ZC9jNGtPTXdH?=
 =?utf-8?B?Skp2UElJK1lkMHYzcElUWWx3aHJNK01kMW84eHV6ZkFITjM3Mk9Mb2RtRDND?=
 =?utf-8?B?dnFtYU16UWwzUnQxcHVsNTIrdm1qRkI2ZTloK2tmbCtSUitTQWpmOFJDelVt?=
 =?utf-8?B?K1R3Vk14NEM4aFoxNE5maVU1TDVteVFZRnMrZ1RhMEs3TmNodDlYK1dwQmxP?=
 =?utf-8?B?MW9yWi9vV0UycUxRRkpXVndwOHlhZXNiL09EUGF2aEZyaXZrc2l3SDc0K1p5?=
 =?utf-8?B?OWtpOW1kQ0V6VVF0UEY2cXVVYkZ3T3VLbGg2UFlVTGxkOHZJVy9DVVdWUkJj?=
 =?utf-8?B?YzE2NUpVNEtHeEUyMGI4L2E5WGxvWVI2akFJZVVpdm81aG5aMFZLT3FPSkFC?=
 =?utf-8?B?QWdiOHViLzN1a1BoQ2REVjlIVytHZ2hvOUhCRUZSNEViMUdXYTlkSlRwMjBN?=
 =?utf-8?B?Q0hwNDZwMUZCTXVxb3FZaTI1bjIxZjJRKzlaZGtVN1FMeE9GdnBsUVRiQ0Q4?=
 =?utf-8?B?VDBWd1VNdk9YMHgwUjdSQ0hTR3d5S2Q2dTlsYWRKV0dENWNVV0lKTXU4YXlN?=
 =?utf-8?B?aWRJWCtlRzdWcTdtc1VXRlVneDljWG1IYVRrUlZFbVJaaEl3TDFIcWxFNkJq?=
 =?utf-8?B?M1lYdGlsSkczMm1wQTdWMVVNZFhsQzFTZ1VHc0tKRDFrTVR0NUE4NHNzaFVt?=
 =?utf-8?B?OFdHL0RkcHNKMU85aUJPVVUva0VGVGdYeW53RndLVUE2QzBGaVFDaWM3UE1W?=
 =?utf-8?B?dFFCM0ZBM1NSc255YjYvN1ZJOVFnQXp3ZXRPVFhXdDRraUx1Qml1dFNPdVhz?=
 =?utf-8?B?bUJLNDV3THhTcGhCblVBZWU3SjFqTHNoT1NYREtQcHVrUmZvVURPR2U4czFN?=
 =?utf-8?B?WGpxMExCdEpVdUFFaVdkTzRHVDVpdGRleVI5QkxvbDZ1dGppbnR6REhabFAx?=
 =?utf-8?B?SjFlRDdWejJ5cVY1Skt3UmxZdzUvUFJwYmhDREQxMjhCNDExaXYvVjhQeENV?=
 =?utf-8?B?TGEyTjkzdEFiaUpxM01GMHE0OXplT3VnN1AwY2d6UmVOL0szZ3NBdUpXRTZO?=
 =?utf-8?B?K1dQd3NtajFJMDliQ3Niei9idEtzWk9icmszaGpDUTFYOHVXVXhtYU9jNG5n?=
 =?utf-8?B?MTByamxjb3JqbWFpalVKcElXUTM4UE5mRnRJNHlGdGdTbHUxT3JkRUVab1pD?=
 =?utf-8?B?cjB3bXFqUUcrcndySzloR2dyK2hVUXN5MGpCOHNLMGczUnFTd3Bkc3QvV2pl?=
 =?utf-8?B?bmpBdmYzam9CNDA0em10NzY1V2RWU1VYSGhrS25qSzJEQXo0MDk3aUQyZWkz?=
 =?utf-8?B?OERuZkpudGJyb0ViTEhLTjJnL2Q1QnZVMEEzbXY5MmhyVkFBcUFkY250L2pF?=
 =?utf-8?B?dlpVR1ZMNE4yUU00Vi9lSXdGMmNoRFVYVXRJS3pkRnlBeEd0NVF3UzdybWtk?=
 =?utf-8?B?LzVBaDh1cys3VHhsT1JyTGFrT0haeE5aT0gzMW1IVm1VZ1U3cVF0NHl3SnBM?=
 =?utf-8?B?ZU5Ha3JOOHZsTnZaa1BhY3p1MEpzaW1LMENqbHZmeHM3MHlKOFZXSCszYmpR?=
 =?utf-8?B?RUQ5aktuLzl3Z1AvdDZEWFBPdG9oaEVITHgzUmkvcDFrNXZhRlVBQmQ2eW1l?=
 =?utf-8?B?Q3hBQzBDV3FNaVZ3MHNBbXVvWFdUZVQ2YTZmclVSUit4S3h2NmhWZlhXYllL?=
 =?utf-8?B?MjhiOURyemZxWWhhaGFadExhZnE1NTlUTGFoOXV6YzE2NGZkMk10cVdIRGdI?=
 =?utf-8?B?VFhZZ05xQXNTY2NCK3VIbnRYa1VRNERDcEQyUDlrVDU5L21mczhEWDhxajJi?=
 =?utf-8?B?dXlqejNYOENlU2lReUxBNUJ4OXZjM3VjTHlENWVxRFJwSFNBcTNRNGd3cHlS?=
 =?utf-8?B?V1psUWVGWkQva0hwbVZkMHA4bk9lS0l1RDZySlMzQ3NtcTZiWkx6RWNZTmFu?=
 =?utf-8?B?djVNdHFENmVvWmF2SHgraFJMai95ZHpXaW00dm1SYTBMc0hqc3l4bG1CQWhW?=
 =?utf-8?B?Snc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 713add9f-3573-42f7-47cc-08dc89c1a92f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 02:53:24.2678
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8YyVuu5Hbe+iAE31v1Rs2JNF9lz1klbN6Feeqiyep8kw5JTo0Q6hWoEbD0uhylja5dMnFOpALhr6PAmheKfefw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6942
X-OriginatorOrg: intel.com

On 6/11/2024 9:17 AM, Sean Christopherson wrote:
> On Thu, May 09, 2024, Yang Weijiang wrote:
>> Enable guest shadow stack pointer(SSP) access interface with new uAPIs.
>> CET guest SSP is HW register which has corresponding VMCS field to save
>> /restore guest values when VM-{Exit,Entry} happens. KVM handles SSP as
>> a synthetic MSR for userspace access.
>>
>> Use a translation helper to set up mapping for SSP synthetic index and
>> KVM-internal MSR index so that userspace doesn't need to take care of
>> KVM's management for synthetic MSRs and avoid conflicts.
>>
>> Suggested-by: Sean Christopherson <seanjc@google.com>
>> Signed-off-by: Yang Weijiang <weijiang.yang@intel.com>
>> ---
>>   arch/x86/include/uapi/asm/kvm.h |  3 +++
>>   arch/x86/kvm/x86.c              |  7 +++++++
>>   arch/x86/kvm/x86.h              | 10 ++++++++++
>>   3 files changed, 20 insertions(+)
>>
>> diff --git a/arch/x86/include/uapi/asm/kvm.h b/arch/x86/include/uapi/asm/kvm.h
>> index ca2a47a85fa1..81c8d9ea2e58 100644
>> --- a/arch/x86/include/uapi/asm/kvm.h
>> +++ b/arch/x86/include/uapi/asm/kvm.h
>> @@ -420,6 +420,9 @@ struct kvm_x86_reg_id {
>>   	__u16 rsvd16;
>>   };
>>   
>> +/* KVM synthetic MSR index staring from 0 */
>> +#define MSR_KVM_GUEST_SSP	0
> Do we want to have "SYNTHETIC" in the name?  E.g. to try and differentiate from
> KVM's paravirtual MSRs?
>
> Hmm, but the PV MSRs are synthetic too.  Maybe it's the MSR part that's bad, e.g.
> the whole point of these shenanigans is to let KVM use its internal MSR framework
> without exposing those details to userspace.
>
> So rather than, KVM_X86_REG_SYNTHETIC_MSR, what if we go with KVM_X86_REG_SYNTHETIC?
> And then this becomes something like KVM_SYNTHETIC_GUEST_SSP?

Yes, makes sense for me.

>
> Aha!  And then to prepare for a future where we add synthetic registers that
> aren't routed through the MSR framework (which seems unlikely, but its trivially
> easy to handle, so why not):
>
> static int kvm_translate_synthetic_reg(struct kvm_x86_reg_id *reg)
> {
> 	switch (reg->index) {
> 	case MSR_KVM_GUEST_SSP:
> 		reg->type = KVM_X86_REG_MSR;
> 		reg->index = MSR_KVM_INTERNAL_GUEST_SSP;
> 		break;
> 	default:
> 		return -EINVAL;
> 	}
> 	return 0;
> }
>
> and then the caller would have slightly different ordering:
>
>          if (id->type == KVM_X86_REG_SYNTHETIC_MSR) {
>                  r = kvm_translate_synthetic_msr(&id->index);
>                  if (r)
>                          break;
>          }
>
>          r = -EINVAL;
>          if (id->type != KVM_X86_REG_MSR)
>                  break;
I assume reg->type translation for GUEST_SSP is due to the fact it relies on CET common checking
stuffs underneath for the register, i.e., it goes through existing MSR framework. But for future other
synthetic MSRs, it needs to refactor the code here so that it could be routed into new handling.
e.g.:

if (id->type == KVM_X86_REG_MSR)
         go through MSR framework;
else
         go through other new handling;

But currently the new uAPIs are only for GUEST_SSP, so above suggested id->type check works.
Does it make sense?