Received-SPF: pass (google.com: domain of linux-kernel+bounces-209266-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 11 Jun 2024 08:18:04 +0300
From: Dan Carpenter <dan.carpenter@linaro.org>
To: "<Tree Davies" <tdavies@darkphysics.net>
Cc: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/24] Staging: rtl8192e: Rename variable bforced_tx20Mhz
Message-ID: <a3049efc-b69f-427f-9de5-7e18c22e30b8@moroto.mountain>
References: <20240610054449.71316-1-tdavies@darkphysics.net>
 <20240610054449.71316-10-tdavies@darkphysics.net>
 <5ccfa433-f1be-45f6-9138-348cb4093866@moroto.mountain>
 <ZmezV4UvCEImxMBX@lunchbox.darkphysics>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZmezV4UvCEImxMBX@lunchbox.darkphysics>

On Mon, Jun 10, 2024 at 07:15:51PM -0700, <Tree Davies wrote:
> On Mon, Jun 10, 2024 at 09:08:03AM +0300, Dan Carpenter wrote:
> > On Sun, Jun 09, 2024 at 10:44:34PM -0700, Tree Davies wrote:
> > > Rename variable bforced_tx20Mhz to forced_tx_20mhz
> > > to fix checkpatch warning Avoid CamelCase.
> > 
> > The correct capitalization for megahertz is MHz.  So the original is
> > wrong but the new name is not correct either.
> > 
> > regards,
> > dan carpenter
> > 
> 
> Thanks Dan,
> So... I guess just spell it out as 'forced_tx_20_megahertz' ?

No, just write it as "forced_tx_20MHz".  Don't bow down to checkpatch.

regards,
dan carpenter