Received-SPF: pass (google.com: domain of linux-kernel+bounces-209298-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <6c01bed7-580e-4f1a-9986-39c20f063e67@amd.com>
Date: Tue, 11 Jun 2024 11:35:03 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v4 3/4] net: macb: Add ARP support to WOL
Content-Language: en-GB
To: Andrew Lunn <andrew@lunn.ch>
Cc: nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev,
 davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
 pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
 conor+dt@kernel.org, linux@armlinux.org.uk, vadim.fedorenko@linux.dev,
 netdev@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, git@amd.com
References: <20240610053936.622237-1-vineeth.karumanchi@amd.com>
 <20240610053936.622237-4-vineeth.karumanchi@amd.com>
 <b46427d8-2b8c-4b26-b53a-6dcc3d0ea27f@lunn.ch>
From: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
In-Reply-To: <b46427d8-2b8c-4b26-b53a-6dcc3d0ea27f@lunn.ch>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a0Z0cGFpajFIQWJ6TEJiTCtyWUhTeCtrSnNjaUlMS1F0QnU5MjlPZTFDNzJP?=
 =?utf-8?B?WHlKeFFIWDdFL1h3RFRSS3ppRytZNEpTWE0rRms5eTM4T1gwcVYzNENkMDRw?=
 =?utf-8?B?dG1jQ1Rvb0MvYzZ0TmZId3BidFdzSC9ZR202dDc2bjdxZkVBTE1QMkdQUWNr?=
 =?utf-8?B?QWlQc2hNcHhORStTcWNOSjFmdHJleEVKUlpxYTdTdzJtMjVUZysxTHVWdHNU?=
 =?utf-8?B?UXF3dmttS1QrcVplTFVXRHgrZ0ZmN0ZqUUd6a3dwTER3MjZwYitrdlRiRk9w?=
 =?utf-8?B?aFlodHBWWnJlNDdXVlI2MCtCekZoMGZiTW1kL01mZmZBVzgva2RBNFZFYTJZ?=
 =?utf-8?B?dzIwTFRnUGdrazR4MStadTJ1K1JRNnVmb1N0K1VzSW83OWVqSWVvN0x4RTFi?=
 =?utf-8?B?MTFqTkNkcitWNkszVVZtc3FDeHBsMFc0QWxPUW5OQ1QxTDNvbTdJVEhieTU2?=
 =?utf-8?B?b1gyU1JTUUtUQS84Sk1wY0VCS0NtdGxKaFRUK3hEdFZ6ckJ4RW0yQi81NkJN?=
 =?utf-8?B?ME1sM0ZBb0NvYVZ1YklTU3pNOU4xbVdJUWtvbGQ3WjRjVm1yTXljaXFsVzZ0?=
 =?utf-8?B?dXUya2dqMzFlTkZUM1BJeDFEOEZkNitqOE0yTHBndXpPTjNUV3FLc2tqUW5o?=
 =?utf-8?B?TnN0eDNQa2d0aDVaRlJuRC9iRGR3L0ZhdkFGNVNJalh4NlJ4NytHRmpoNXFP?=
 =?utf-8?B?eFltd0FjRE1XblpxZUFtS0JqWkJISjk5TWFPNXJmb0hZaW0vYjJEZDJWVmxn?=
 =?utf-8?B?bXBiVlZKSDVERXM1NTJ4Vmd2NXJ4dEM0T1ljNm5tV3pDR1RrRjc0S2RvT1p2?=
 =?utf-8?B?ZmVOYkR6OFQxa0M4TE5mUUhkQzJMNngxOWxZVExmZzU3b0lZNGpnVTc1ZFBX?=
 =?utf-8?B?ZDdFcyttemNCUitmbVovWWtXbXAyUkdvNW4xL2t0SkswWkJab3FQVmVIZVQy?=
 =?utf-8?B?ZDl4UFFvQmlMTEUzb2ozcU5zbWxZTEhBeHZiSVdCZWR5YXpMcTl6cE96S1BO?=
 =?utf-8?B?bFkyRjU0dmcrQUxjMTRzMEJRbHE2WW9CL2lGbGo5VEFBTU1pU2IybloxUXVq?=
 =?utf-8?B?R3JqSVhYUld0clBXWTQ2VEwyZmJ4U1IzcUdMcnBuK2RUejFtNUl3QWhQRHFu?=
 =?utf-8?B?WHdneUhiZTc1K2VvVmJKdFpLanJvM0haTXk4L1l4SGcxMHV4UW1Malc4NmRx?=
 =?utf-8?B?ZlBHMTZzU3dhZ1NUamovV2FiT1pyOGo4bHNlQzdlL3dIV0pXTksxelZKVmx0?=
 =?utf-8?B?TXZkbHFZYmlFTzM0UmNrcURXd0tnV2EzMUh2eFhPYzkrL1gvZGxhSENMdyt2?=
 =?utf-8?B?a2ZNVHN0Kzh3ZkRCWVdLa3FESktWSWxrYm02Q3ZQVG5ra0xDbTRSV3hXWmMy?=
 =?utf-8?B?LytEYjJpdmkwTjhxOXZHRTRicGdTYmFDVzVPaWdldTI3WGM5bkZucmJIRGpt?=
 =?utf-8?B?TGhyOEhkV3hnSGNzckdwV1J3cnhudGgySmtONmhtYm8wTUNBOG43cm9FTVk0?=
 =?utf-8?B?VS9PakJsd2diOU5HRHEzbVFSUkRpVmdWVjR4N2pyYTJIdkthclFIVVg2VmdR?=
 =?utf-8?B?MG9XaFB3RzhRV2RrcU9TcTRuaENmbi9oTTFkU1ZiM3kzUEJEZHpRRUkyLzJH?=
 =?utf-8?B?KzA1eWlibytnNDYwc3kzZEtYVWRJQm1NVlZXUndPSE1Ua3lPdzhxUFZ4ZDlk?=
 =?utf-8?B?TkZzbmFOSSs1T2RJVWdxZlhkZThCNjUzT0tnalo1YjEweU1JY0pXV3NCYVJx?=
 =?utf-8?B?VXFpQUhmTGwxSjFpY1prR2hCTTBsRDlISlZ3UEkvYWs3Z2FkSkZLN1BjYm8x?=
 =?utf-8?B?anQwM0puUXM0TW1yUnRPdG03WjRDMml5bnF3YmpwWi9VNUVNNVBjMkVJbFJZ?=
 =?utf-8?B?VmtWRGtLQzVaWTdQK0tPMHNiYkxOUm5wMGVGK0RwSXc1ZVRjTU5DUEh3bUVP?=
 =?utf-8?B?QXppQzBYMFZUU3JNY0ZQazNheDI1WFhqVVN2WjlUN3VRcms3OStMS3JveWRt?=
 =?utf-8?B?V2IvVFIwcDFqTGpyUExGaWxtUFVVYUpWQnNoL0tidHRnRjRWVFhhVmRURkQr?=
 =?utf-8?B?TEluZ3RFVHhaN0ROeGkzRUNNWVhoYmREK2loeWJmNXYrUDdSWGlsd002SlVO?=
 =?utf-8?Q?VZm/GztMa03c3lFAS91vC/EoB?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a33a571e-6999-4683-4e23-08dc89dc766f
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5946.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 06:05:15.5698
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: USJ8jqTDV8QhepCnLpKB4nb0kU2gX6GMaqFSjHLzSGemT1uLGOgQGya5ArET81Gi
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8527

Hi Andrew,


On 10/06/24 6:16 pm, Andrew Lunn wrote:
>> @@ -3294,22 +3292,15 @@ static int macb_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol)
>>   
>>   	/* Pass the order to phylink layer */
>>   	ret = phylink_ethtool_set_wol(bp->phylink, wol);
>> -	/* Don't manage WoL on MAC if handled by the PHY
>> -	 * or if there's a failure in talking to the PHY
>> -	 */
>> -	if (!ret || ret != -EOPNOTSUPP)
>> +	/* Don't manage WoL on MAC if there's a failure in talking to the PHY */
>> +	if (!!ret && ret != -EOPNOTSUPP)
>>   		return ret;
> 
> The comment is wrong. You could be happily talking to the PHY, it just
> does not support what you asked it to do.
> 


These are the 3 possible return scenarios

1. -EOPNOTSUPP. : When there is no PHY or no set_wol() in PHY driver.
2. 0 : Success
3. any error (-EINVAL, ... ) from set_wol()

we are returning in case 3.

The comment can be "Don't manage WoL on MAC, if PHY set_wol() fails"

please let me know your thoughts/comments.


???? vineeth