Received-SPF: pass (google.com: domain of linux-kernel+bounces-209291-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240610195828.474370-1-mjguzik@gmail.com> <20240610195828.474370-2-mjguzik@gmail.com>
 <ZmfZukP3a2atzQma@infradead.org> <CAGudoHE12-7c0kmVpKz8HyBeHt8jX8hOQ7zQxZNJ0Re7FF8r6g@mail.gmail.com>
 <ZmfemrY9ZPnvmocu@infradead.org>
In-Reply-To: <ZmfemrY9ZPnvmocu@infradead.org>
From: Mateusz Guzik <mjguzik@gmail.com>
Date: Tue, 11 Jun 2024 07:36:46 +0200
Message-ID: <CAGudoHH_Cx1F5Fdiv7EQaz_pWmZUyuieMdx+_XsUXa6AY829Yw@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] vfs: add rcu-based find_inode variants for iget ops
To: Christoph Hellwig <hch@infradead.org>
Cc: brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, 
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, 
	linux-btrfs@vger.kernel.org, josef@toxicpanda.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 11, 2024 at 7:20=E2=80=AFAM Christoph Hellwig <hch@infradead.or=
g> wrote:
>
> On Tue, Jun 11, 2024 at 07:17:41AM +0200, Mateusz Guzik wrote:
> >
> > I agree, but this is me just copying and modifying an existing line.
> >
> > include/linux/fs.h is chock full of extern-prefixed func declarations,
> > on top of that some name the arguments while the rest does not.
> >
> > Someone(tm) should definitely clean it up, but I'm not interested in
> > bikeshedding about it.
>
> No one asked you to clean the mess up, but don't add any in changed
> or added lines.  Without that:
>
> Nacked-by: Christoph Hellwig <hch@lst.de>
>

I am not saying you told me to clean the file up.

I am explaining why the addition looks the way it does: I am keeping
it consistent with the surroundings, which I assumed is the preferred
way.

That said, whichever way this is spelled out is fine with me so if vfs
overlords want 'extern' removed I will make the change no problem. (or
based on what I had seen from Christian so far, he will the touch it
up himself, which is again fine with me)

--=20
Mateusz Guzik <mjguzik gmail.com>