Received-SPF: pass (google.com: domain of linux-kernel+bounces-209343-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Tue, 11 Jun 2024 09:50:22 +0300 (EEST)
To: "Moger, Babu" <babu.moger@amd.com>
cc: fenghua.yu@intel.com, Reinette Chatre <reinette.chatre@intel.com>, 
    shuah@kernel.org, LKML <linux-kernel@vger.kernel.org>, 
    linux-kselftest@vger.kernel.org, 
    =?ISO-8859-15?Q?Maciej_Wiecz=F3r-Retman?= <maciej.wieczor-retman@intel.com>, 
    peternewman@google.com, eranian@google.com
Subject: Re: [PATCH v2] selftests/resctrl: Fix noncont_cat_run_test for AMD
In-Reply-To: <0e153d27-fa1d-4c47-8d4e-a2004c991ffc@amd.com>
Message-ID: <32ee6801-cc68-e058-dfca-521ef9f398cb@linux.intel.com>
References: <3a6c9dd9dc6bda6e2582db049bfe853cd836139f.1717622080.git.babu.moger@amd.com> <7679d70a0ea939db13ae9dac20de56644460d6df.1718035091.git.babu.moger@amd.com> <91052cec-071b-7cc7-5f85-4fa29ec2aea4@linux.intel.com>
 <0e153d27-fa1d-4c47-8d4e-a2004c991ffc@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323328-446345429-1718088064=:1025"
Content-ID: <bbe28686-412a-5be0-e29b-c905ab97f256@linux.intel.com>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-446345429-1718088064=:1025
Content-Type: text/plain; CHARSET=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE
Content-ID: <7a7c7790-f400-a639-f19d-d6c15fc5af1a@linux.intel.com>

On Mon, 10 Jun 2024, Moger, Babu wrote:
> On 6/10/24 11:20, Ilpo J=E4rvinen wrote:
> > On Mon, 10 Jun 2024, Babu Moger wrote:
> >=20
> >> The selftest noncont_cat_run_test fails on AMD with the warnings. Reas=
on
> >=20
> > noncont_cat_run_test()
>=20
> I want to mention the test here. not function. How about this?
>=20
> "The selftest non-contiguous CBM test fails on AMD with the warnings."

Yes, it's possible to refer to something with natural language (in fact, I=
=20
personally find that better than using a function name when both options=20
exist).

The underscores are C artifacts to replace spaces that do not belong to=20
natural language so if one uses underscores, I'll always take it as a=20
direct reference to C code.

The quote still has "the warnings" though (but I see Reinette already=20
noted that).

> > (In general, use () when refering to a function, same thing in the=20
> > shortlog).
> >=20
> > "the warnings" sounds like I should know about what warning it fails wi=
th
> > but there's no previous context which tells that information. I suggest=
=20
> > you either use "a warning" or quote the warning it fails with into the=
=20
> > commit message.
> >=20
> >> is, AMD supports non contiguous CBM masks but does not report it via C=
PUID.


--=20
 i.
--8323328-446345429-1718088064=:1025--