Received-SPF: pass (google.com: domain of linux-kernel+bounces-209347-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Feedback-ID: i2ee147e6:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-515-g87b2bad5a-fm-20240604.001-g87b2bad5
Precedence: bulk
MIME-Version: 1.0
Message-Id: <dc9a785c-f8f1-474d-ba49-31de63dc5e8d@app.fastmail.com>
In-Reply-To: <2024061112-kilogram-poker-bacf@gregkh>
References: <2024061112-kilogram-poker-bacf@gregkh>
Date: Mon, 10 Jun 2024 23:53:46 -0700
From: "Danny Lin" <danny@kdrag0n.dev>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, masahiroy@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
 =?UTF-8?Q?=C3=8D=C3=B1igo_Huguet?= <ihuguet@redhat.com>,
 =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?= <mic@digikod.net>,
 "Vincent Mailhol" <mailhol.vincent@wanadoo.fr>
Subject: Re: [PATCH] .editorconfig: move to Documentation/ directory
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 10, 2024 at 11:49 PM, Greg Kroah-Hartman wrote:
> Some editors (like the vim variants), when seeing "trim_whitespace"
> decide to do just that for all of the whitespace in the file you are
> saving, even if it is not on a line that you have modified.  This plays
> havoc with diffs and is NOT something that should be intended.

If trim_trailing_whitespace is the only rule that has actually been a pr=
oblem,
how about removing it and leaving the rest of .editorconfig intact?
The other rules are still useful to have as defaults.

Thanks,
Danny

>
> As the "only trim whitespace on modified files" is not part of the
> editorconfig standard, just move the whole thing off to the
> Documentation/ directory so that those that wish to use such a thing c=
an
> pick it up from there.
>
> Cc: Danny Lin <danny@kdrag0n.dev>
> Cc: =C3=8D=C3=B1igo Huguet <ihuguet@redhat.com>
> Cc: Micka=C3=ABl Sala=C3=BCn <mic@digikod.net>
> Cc: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  .editorconfig =3D> Documentation/.editorconfig | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename .editorconfig =3D> Documentation/.editorconfig (100%)
>
> diff --git a/.editorconfig b/Documentation/.editorconfig
> similarity index 100%
> rename from .editorconfig
> rename to Documentation/.editorconfig
> --=20
> 2.45.2