Received-SPF: pass (google.com: domain of linux-kernel+bounces-209364-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Jackson Lee <jackson.lee@chipsnmedia.com>
To: mchehab@kernel.org,
	nicolas@ndufresne.ca,
	sebastian.fricke@collabora.com
Cc: linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	hverkuil@xs4all.nl,
	nas.chung@chipsnmedia.com,
	lafley.kim@chipsnmedia.com,
	b-brnich@ti.com,
	jackson.lee@chipsnmedia.com
Subject: [PATCH v5 0/4] Add features to an existing driver
Date: Tue, 11 Jun 2024 16:14:57 +0900
Message-Id: <20240611071501.80-1-jackson.lee@chipsnmedia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Ghpb/r2qZz9w0qKPQWUevOeOXEu8mkkigdls/o8GvwOBZaDRFdTPtyTzcaHf?=
 =?us-ascii?Q?pdw81y5qCVdVoaCDHHc8nDnDsgp78EzomD7tsjSdtHbWf3S//WS/ArLe05Hs?=
 =?us-ascii?Q?Ez8PjTgHjJQ7LgmS9zHDZfSSmC+iLBeVgAn75m8bmF0ip1UCZeuUSoZ13vuB?=
 =?us-ascii?Q?Ng+UhkoKEIWEHTYGbVpcwBy4lIOQCz6J2e4P5qWXrUP/vfR4qErE7RUimRSc?=
 =?us-ascii?Q?b6PX2TG0EK20hZ1jR/8GQyd8Ge3naajMXneghhPInPabf+MvioHzay2/5PMf?=
 =?us-ascii?Q?qRZLmVP4w9UAYaQNp3aZWRMPcqH+lwGbBrwVYDSkCOP+LgUhjVARqMZ62/1k?=
 =?us-ascii?Q?Tl4ziSijXXGPNR1PfX3A0J1uF8Br4yrNx7GLgpHvoQWFuU6s4lyv+zMAWb4m?=
 =?us-ascii?Q?LsgLCPewlv9pdLtS+lQuJLVtUFqZrdhJXEXnPZam1NE8Lea+BbKiZNIpOLN9?=
 =?us-ascii?Q?PeXC6Ab1J1ExwKSGf1VWQP2kDQI3wWVL8w0+Yy0INsPbBpUwXDe8CaAt2T9e?=
 =?us-ascii?Q?vgRP0P5pDy9kb0aW2Rn5n+O76Kbdsz0DPpH6+tEEgcNzwb1L6MBx5PQqZVeL?=
 =?us-ascii?Q?9BoutOlMiVsZbasL5tui15NyOIYfmrLKV1oRcFpSJwCExp9wZJk5u6THtkDv?=
 =?us-ascii?Q?M7OeJGUiv9xM+oFlTFwGUEEbRv2Gpa2PJiejCCXEkhXkdXp3uWMytq/aIGy1?=
 =?us-ascii?Q?YcICIjpWslQ0oOZZ2YI3TkseOl5sop1Vs0TxsxuesZeNnA+oTmqOKBB+n09+?=
 =?us-ascii?Q?VhAJF1swpOn90kd2LyXwpoMC165rbxK1mkpKjQlhpXU8YwUqtGv0ziW6GoUx?=
 =?us-ascii?Q?r2QfdH/XyanLrw8ucEfYpgqaG3Kx1BqI5h0HyM5xXXuaNDKXgaL9UXChM8yZ?=
 =?us-ascii?Q?b7RheJYzNWhL4PORwo0/jzZ4KZ8LVbOXz5QnW3JW2biRf93mZ1JKy7TPj6dm?=
 =?us-ascii?Q?/XH6nfN9in5wvOh7u4I/ConcMPMgvJbXTXj4EfSoTIa/33tSRzVzyT3VrhLQ?=
 =?us-ascii?Q?LnDf+jq1pz9afQTJ5ASpmDEFc/QtpAIPX0IYyPf3KMEHuxJi3a/HFID71Ewi?=
 =?us-ascii?Q?duV6oKqPWvVwm9YzyIaL3FWe/8dKRgMmm6M4ESWmjlRT8Cjux30hTM5IZ0Z2?=
 =?us-ascii?Q?GyBy7OFJy+RYxsLB5Dn33V70LctbWej6Zhx8vdvIOqPnMVlIbf/a43yBYMGH?=
 =?us-ascii?Q?izu9SaeHONXnWzrmMHK+dz5iBtOz9xAoTUhDm8FvuLAI43MWNa8FdS1s8h5X?=
 =?us-ascii?Q?SgNA3EgecsnHcgOfWhk8QXjeofkyAYrttf8Bq6ZWuxSyDlp8H8qBGrM49wMo?=
 =?us-ascii?Q?592jeDh6KrXfNqGYR/YFJsTs/vI7BcmgqMpTEcyojLtPRHRcPSlRbiZQewpE?=
 =?us-ascii?Q?oDKCm6zgxVP5+Q6vKyb/Ne3ZHZWQ1yWAKR7d76/7+Ict9AwnxEkiOZ12Mtyf?=
 =?us-ascii?Q?PN6pO74ShOnPkZofuWk8en00S3TYGI7cSgnvS7+bGuaOAawDimd21g0H+DVO?=
 =?us-ascii?Q?jgFzSxsyBb8dOYifOxJlmOXSFaUD9fQbWKnf5gPnUjPY0aA4X3YQspNYTo5I?=
 =?us-ascii?Q?hKpmwVrtw5NGYwFIbx+qlRVEBlcgRj/oiyoHIwMIgGCacoJ0Wudn+ZiZfMsz?=
 =?us-ascii?Q?dw=3D=3D?=
X-OriginatorOrg: chipsnmedia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 90c2a979-fec0-463c-9697-08dc89e63a79
X-MS-Exchange-CrossTenant-AuthSource: SE1P216MB1303.KORP216.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 07:15:09.7233
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4d70c8e9-142b-4389-b7f2-fa8a3c68c467
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zWRnF5YMInCA6eRWVol2w/DJsW/TqPMNEAaofToroiUuQUXlNo+fSeaoLtAvQ51MqCfBILvMTpl7tHP96BNDg28/SIeSguOGyfIWZSdn10E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEWP216MB2956

From: "jackson.lee" <jackson.lee@chipsnmedia.com>

The wave5 codec driver is a stateful encoder/decoder.
The following patches is for supporting yuv422 inpuy format, supporting runtime suspend/resume feature and extra things.

v4l2-compliance results:
========================

v4l2-compliance 1.24.1, 64 bits, 64-bit time_t

Buffer ioctls:
            warn: v4l2-test-buffers.cpp(693): VIDIOC_CREATE_BUFS not supported
            warn: v4l2-test-buffers.cpp(693): VIDIOC_CREATE_BUFS not supported
    test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
    test VIDIOC_EXPBUF: OK
    test Requests: OK (Not Supported)

Total for wave5-dec device /dev/video0: 45, Succeeded: 45, Failed: 0, Warnings: 2 Total for wave5-enc device /dev/video1: 45, Succeeded: 45, Failed: 0, Warnings: 0

Fluster test results:
=====================

Running test suite JCT-VC-HEVC_V1 with decoder GStreamer-H.265-V4L2-Gst1.0 Using 1 parallel job(s)
Ran 132/147 tests successfully               in 97.421 secs

(1 test fails because of not supporting to parse multi frames, 1 test fails because of a missing frame and slight corruption,
 2 tests fail because of sizes which are incompatible with the IP, 11 tests fail because of unsupported 10 bit format)

Running test suite JVT-AVC_V1 with decoder GStreamer-H.264-V4L2-Gst1.0 Using 1 parallel job(s)
Ran 77/135 tests successfully               in 37.233 secs

(58 fail because the hardware is unable to decode  MBAFF / FMO / Field / Extended profile streams.)

Change since v4:
================
* For [PATCH v4 2/4] media: chips-media: wave5: Support runtime suspend/resume
 - Fix warning message

* For [PATCH v4 3/4] media: chips-media: wave5: Use helpers to calculate bytesperline and sizeimage.
 - Fix warning message
 - add Reviewed-By tag

* For [PATCH v4 4/4] media: chips-media: wave5: Support YUV422 raw pixel-formats on the encoder
 - add Reviewed-By tag

Change since v3:
=================

* For [PATCH v4 1/4] media: chips-media: wave5: Support SPS/PPS generation for each IDR
 - add Reviewed-By tag

* For [PATCH v4 2/4] media: chips-media: wave5: Support runtime suspend/resume
 - add Reviewed-By tag

* For [PATCH v4 3/4] media: chips-media: wave5: Use helpers to calculate bytesperline and sizeimage.
 - modify the commit message
 - define three framesize structures for decoder

* For [PATCH v4 4/4] media: chips-media: wave5: Support YUV422 raw pixel-formats on the encoder
 - modify the commit message
 - use the v4l2_format_info to calculate luma, chroma size

Change since v2:
=================

* For [PATCH v3 0/4] media: chips-media: wave5: Support SPS/PPS generation for each IDR
 - add the suggested _SHIFT suffix

* For [PATCH v3 1/4] media: chips-media: wave5: Support runtime suspend/resume
 - change a commit message

* For [PATCH v3 2/4] media: chips-media: wave5: Use helpers to calculate bytesperline and sizeimage
 - add pix_fmt_type parameter into wave5_update_pix_fmt function
 - add min/max width/height values into dec_fmt_list 

Change since v1:
=================

* For [PATCH v2 0/4] media: chips-media: wave5: Support SPS/PPS generation for each IDR
 - define a macro for register addresses

* For [PATCH v2 1/4] media: chips-media: wave5: Support runtime suspend/resume
 - add auto suspend/resume

* For [PATCH v2 2/4] media: chips-media: wave5: Use helpers to calculate bytesperline and sizeimage
 - use helper functions to calculate bytesperline and sizeimage

* For [PATCH v2 3/4] media: chips-media: wave5: Support YUV422 raw pixel-formats on the encoder
 - remove unnecessary codes

Change since v0:
=================
The DEFAULT_SRC_SIZE macro was defined using multiple lines, To make a simple define, tab and multiple lines has been removed, The macro is defined using one line.


jackson.lee (4):
  media: chips-media: wave5: Support SPS/PPS generation for each IDR
  media: chips-media: wave5: Support runtime suspend/resume
  media: chips-media: wave5: Use helpers to calculate bytesperline and
    sizeimage.
  media: chips-media: wave5: Support YUV422 raw pixel-formats on the
    encoder.

 .../platform/chips-media/wave5/wave5-helper.c |  24 ++
 .../platform/chips-media/wave5/wave5-helper.h |   5 +
 .../platform/chips-media/wave5/wave5-hw.c     |  23 +-
 .../chips-media/wave5/wave5-vpu-dec.c         | 312 +++++++-----------
 .../chips-media/wave5/wave5-vpu-enc.c         | 308 +++++++++--------
 .../platform/chips-media/wave5/wave5-vpu.c    |  43 +++
 .../platform/chips-media/wave5/wave5-vpu.h    |   5 +-
 .../platform/chips-media/wave5/wave5-vpuapi.c |  14 +-
 .../platform/chips-media/wave5/wave5-vpuapi.h |   1 +
 .../chips-media/wave5/wave5-vpuconfig.h       |  27 +-
 .../media/platform/chips-media/wave5/wave5.h  |   3 +
 11 files changed, 420 insertions(+), 345 deletions(-)

-- 
2.43.0