Date: Wed, 6 Feb 2008 13:58:02 -0800
From: Greg KH <greg@kroah.com>
To: "Kok, Auke" <auke-jan.h.kok@intel.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Pavel Machek <pavel@ucw.cz>,
       ?????? ??????????? <penguinista@mail.net.mk>,
       Arjan van de Ven <arjan@infradead.org>,
       Shaohua Li <shaohua.li@intel.com>, lkml <linux-kernel@vger.kernel.org>,
       linux-pci <linux-pci@atrey.karlin.mff.cuni.cz>
Subject: Re: PCIE ASPM support hangs my laptop pretty often
Message-ID: <20080206215802.GA6021@kroah.com>
References: <200802051840.05237.penguinista@mail.net.mk> <47A8FDDF.6080503@intel.com> <20080206130004.GC26817@elf.ucw.cz> <200802061825.21692.rjw@sisk.pl> <47AA2AAE.3040101@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <47AA2AAE.3040101@intel.com>
User-Agent: Mutt/1.5.16 (2007-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2235
Lines: 49

On Wed, Feb 06, 2008 at 01:46:22PM -0800, Kok, Auke wrote:
> Rafael J. Wysocki wrote:
> > On Wednesday, 6 of February 2008, Pavel Machek wrote:
> >> On Tue 2008-02-05 16:22:55, Kok, Auke wrote:
> >>> ?????? ??????????? wrote:
> >>>>>>>> I've patched my kernel with the PCIe ASPM and after setting
> >>>>>>>> echo powersave > /sys/module/pcie_aspm/parameters/policy
> >>>>>>>>
> >>>>>>>> I started to experience random hangs of my laptop.
> >>>>>>>> Hardware info:
> >>>>>>>> Thinkpad x60s 1704-5UG
> >>>>>>> the x60's chipset doesn't support ASPM properly afaik... bad idea.
> >>>>>> Well, the code shouldn't then cause a crash of the machine :)
> >>>>> The user enabled it specifically (where it is disabled by default)
> >>>>>
> >>>>> ASPM has been crashing e1000(e), which is why I've recently merged a patch
> >>>>> to disable L1 ASPM for the onboard 82573 nic on those platforms.
> >>>>>
> >>>>> this new infrastructure should work in the default configuration - enabling
> >>>>> ASPM where this system leaves it disabled is expected to give problems
> >>>>> unless you know what you are doing.
> >>>> In my defense, the patch documentation didn't say it doesn't work with my 
> >>>> hardware, nor that it hangs the chipset :) and the promised 1.3w surelly 
> >>>> looked nice.
> >>>>
> >>>> So, are there any benefits of ASPM if I have it in the kernel but it's set to 
> >>>> default? I got the impression that "default" means not much power savings?
> >>> did the Kconfig not come with a big fat (EXPERIMENTAL) ?
> >> (EXPERIMENTAL) is something different from (KNOWN BROKEN).
> >>
> >> If we know about broken setups, we should probably be blacklisting
> >> them.
> > 
> > Well, the ASPM thing seems to break every single setup I've tested.  So,
> > perhaps we should whitelist the working ones?
> 
> greg KH is reverting this patch alltogether in mainline, maybe the original writer
> can accomodate some of the comments in the rewrite.

It's already reverted.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/