Received-SPF: pass (google.com: domain of linux-kernel+bounces-209430-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <2024061112-kilogram-poker-bacf@gregkh> <dc9a785c-f8f1-474d-ba49-31de63dc5e8d@app.fastmail.com>
In-Reply-To: <dc9a785c-f8f1-474d-ba49-31de63dc5e8d@app.fastmail.com>
From: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Date: Tue, 11 Jun 2024 16:56:47 +0900
Message-ID: <CAMZ6RqLtc5jtfjeQO2Su8iSjw4bbPczKMsnW3mCB=SXkSufY-g@mail.gmail.com>
Subject: Re: [PATCH] .editorconfig: move to Documentation/ directory
To: Danny Lin <danny@kdrag0n.dev>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, masahiroy@kernel.org, 
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, 
	=?UTF-8?B?w43DsWlnbyBIdWd1ZXQ=?= <ihuguet@redhat.com>, 
	=?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= <mic@digikod.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue. 11 June 2024 at 15:53, Danny Lin <danny@kdrag0n.dev> wrote:
> On Mon, Jun 10, 2024 at 11:49 PM, Greg Kroah-Hartman wrote:
> > Some editors (like the vim variants), when seeing "trim_whitespace"
> > decide to do just that for all of the whitespace in the file you are
> > saving, even if it is not on a line that you have modified.  This plays
> > havoc with diffs and is NOT something that should be intended.
>
> If trim_trailing_whitespace is the only rule that has actually been a pro=
blem,
> how about removing it and leaving the rest of .editorconfig intact?
> The other rules are still useful to have as defaults.

+1

The trim_trailling_whitespace can be removed. IMHO the main point of
the .editorconfig is to set up the correct indentation, that is to say
the indent_style and indent_size parameters, and I don't think that
anyone is having issues with these so far.

> Thanks,
> Danny
>
> >
> > As the "only trim whitespace on modified files" is not part of the
> > editorconfig standard, just move the whole thing off to the
> > Documentation/ directory so that those that wish to use such a thing ca=
n
> > pick it up from there.
> >
> > Cc: Danny Lin <danny@kdrag0n.dev>
> > Cc: =C3=8D=C3=B1igo Huguet <ihuguet@redhat.com>
> > Cc: Micka=C3=ABl Sala=C3=BCn <mic@digikod.net>
> > Cc: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> > Cc: Masahiro Yamada <masahiroy@kernel.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> >  .editorconfig =3D> Documentation/.editorconfig | 0

This would not solve the issue, because it would still apply for
anything under Documentation/*

> >  1 file changed, 0 insertions(+), 0 deletions(-)
> >  rename .editorconfig =3D> Documentation/.editorconfig (100%)
> >
> > diff --git a/.editorconfig b/Documentation/.editorconfig
> > similarity index 100%
> > rename from .editorconfig
> > rename to Documentation/.editorconfig
> > --
> > 2.45.2