Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp190008lqp; Tue, 11 Jun 2024 01:04:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWx+nxMz9E5EtQ+hN8cBwZaUlcrrqsmcdwLtF+/4g/NzmgQwqIK4KkXTwYgYpFzpogINXGo92lPIppsmTmiOs8T6O2jLODgzRStM+uGzg== X-Google-Smtp-Source: AGHT+IGDphFMFsHgI0K56WfqTIwDHIOQmwHghXON/JauSSi+HtzFRKWKmY8Wh/6iFSqRIzPORCxA X-Received: by 2002:a05:6a20:2d0a:b0:1b4:dd91:cec with SMTP id adf61e73a8af0-1b4dd910eb1mr9570861637.45.1718093049196; Tue, 11 Jun 2024 01:04:09 -0700 (PDT) Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-6ea6d41976csi4399680a12.44.2024.06.11.01.04.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 01:04:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-209395-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=R5CkjXBC; arc=fail (signature failed); spf=pass (google.com: domain of linux-kernel+bounces-209395-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-209395-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=hpe.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 27A84B29C63 for ; Tue, 11 Jun 2024 07:42:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AAA3C17332B; Tue, 11 Jun 2024 07:40:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b="R5CkjXBC" Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A42617624B; Tue, 11 Jun 2024 07:40:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.143.35 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718091640; cv=fail; b=Zlu1lBP9KYcGRz0V7b9mlTiLvdYyr5wrP5ikdfhBPO25pWh1Evp1dOIvM/kMtCCFBOqSgfQ2VNold+pI3HCWkCo4XA3K0CEvpiaiXmgwSBML9gMLNm7fxwMvjsnybiaFTo7uqdfENx6Y1VQvWblgfRHAxJ1D3+/63UFe9xmhvvk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718091640; c=relaxed/simple; bh=UtmGWzANRaxitOjVUU4Og35++Y9hdz/ywpdvn2kyAyE=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=S87ffxyqKUmLZUVWzRAvGNsu3QemVjeUT375hBTLVPQXMSjvauB27xeBSE7cTz2rq3bUrXI2g4i68WJVDAS8KIbvyMSyc7UeBYC3K4HiYVvDT10MpmdKsepMzu42flpEdcv5ol1ifuv8hzxlg6+byrOEpJXsPWivjX7XmWNDZPo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=hpe.com; spf=pass smtp.mailfrom=hpe.com; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b=R5CkjXBC; arc=fail smtp.client-ip=148.163.143.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=hpe.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hpe.com Received: from pps.filterd (m0134424.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 45B4goXp029776; Tue, 11 Jun 2024 07:13:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=cc : content-transfer-encoding : content-type : date : from : in-reply-to : message-id : mime-version : references : subject : to; s=pps0720; bh=UtmGWzANRaxitOjVUU4Og35++Y9hdz/ywpdvn2kyAyE=; b=R5CkjXBCwsaVIg106tqCEPDuwj9CjfAjUL6z5z2+l6TQGdEt1nNYMFyBMLj1jMEsgF+x rxmUGKBkmauZA6oQO1Xb/ZjXLnovyzrHkOyktNPe5gOkytkmnmrcr0LTtima09wm9hfg H6Vj9/6dQQ6vpeMnWNtrkOpus16ybLZlKCiL0yR5EE5ai5BwRuIKIf65Tm7g8svlIhld zjV0sHJ9KWNtuvo9gi3MVUjnmsSbX4YjvnCoNBq1Gnwon2z7zf6dEpEtBSOZ4cATF/sk mBGd0rwAcD9M9qvYi8qGjeyTcuRbHOdIgs7K/1Jacw7L6Tly/gwIOiL+3LnDVed4rGK6 dQ== Received: from p1lg14878.it.hpe.com ([16.230.97.204]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 3ypfsw930c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Jun 2024 07:13:27 +0000 Received: from p1wg14924.americas.hpqcorp.net (unknown [10.119.18.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by p1lg14878.it.hpe.com (Postfix) with ESMTPS id 6486014789; Tue, 11 Jun 2024 07:13:11 +0000 (UTC) Received: from p1wg14926.americas.hpqcorp.net (10.119.18.115) by p1wg14924.americas.hpqcorp.net (10.119.18.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Mon, 10 Jun 2024 19:13:01 -1200 Received: from p1wg14921.americas.hpqcorp.net (16.230.19.124) by p1wg14926.americas.hpqcorp.net (10.119.18.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42 via Frontend Transport; Mon, 10 Jun 2024 19:13:01 -1200 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (192.58.206.38) by edge.it.hpe.com (16.230.19.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Mon, 10 Jun 2024 19:13:01 -1200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dSAf144+S3vezpDDml1Ich80mC6wHoG+uNcG//tJOXZMqWgPSkU79jBYF5LR7+rAWmxBwgrJvKsthtyvULZAEhGx8UOg8CS90anzBdHf1gQ/NYcaGQCnB3DxuV9xNvji7lVnE1JpksZCWCUY01YcD4iYB45qq2l2akXSLWa/aZndn94PlYRJFzT0knFTPTfxPdCKLink3yK9qHjSQE2uRCSFZXqaVjrAsSNTgZalirhpWzUqHKYQTiqcvhB8QSLMojdnwluTOGgw7wJx1dFMNcCqpXXGbTmY2BxfM/E4GJzioUKOI8TLB2Se58cwiW2I1YzU0mJzsLYLOIM1sMh3FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UtmGWzANRaxitOjVUU4Og35++Y9hdz/ywpdvn2kyAyE=; b=OLaHs9CjC2SZSDAxxTG4sQRt9+ZqZ2CVfrXJqggSTvkhXUGF4fx0G/RXgraBCQH6ZRV2IVAQDISERmWHL4E58/hrJKqLT3udkeBVjmSKOdMhEuZJ2sRWa5qjsWVRenMdx1wb9ktauZyZ3rNdF8hwJRqPQbFg13oHdYcO/y+d/bfbXYghzXl7Gp7FsrTFIIj03kV4b+V9pIXuTNiOtD1lyYVgLzeNwdhrfm3EYra2v4Hf5HKPsSxuuI03GuOJ947AZNFn/USSy6XJDuljVFozo8rriTA4j1tW5jFbonP9IeEIY2enrYoijcCwej/22FQYTULmnaS7xUkaaG4j+/D/+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from PH7PR84MB1581.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:510:150::10) by DM4PR84MB1832.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:8:4f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.27; Tue, 11 Jun 2024 07:12:58 +0000 Received: from PH7PR84MB1581.NAMPRD84.PROD.OUTLOOK.COM ([fe80::1c64:65aa:5b9b:557e]) by PH7PR84MB1581.NAMPRD84.PROD.OUTLOOK.COM ([fe80::1c64:65aa:5b9b:557e%5]) with mapi id 15.20.7633.036; Tue, 11 Jun 2024 07:12:58 +0000 From: "Chien, Richard (Options Engineering)" To: Andrew Lunn , Richard chien CC: "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "jesse.brandeburg@intel.com" , "anthony.l.nguyen@intel.com" , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] ixgbe: Add support for firmware update Thread-Topic: [PATCH] ixgbe: Add support for firmware update Thread-Index: AQHaukt8I3wFUtywh0O9hYZw5ozMD7HBZkoAgAC9eQA= Date: Tue, 11 Jun 2024 07:12:58 +0000 Message-ID: References: <20240609085735.6253-1-richard.chien@hpe.com> In-Reply-To: Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR84MB1581:EE_|DM4PR84MB1832:EE_ x-ms-office365-filtering-correlation-id: f9761b7f-2965-4581-b9c5-08dc89e5ec29 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230031|7416005|366007|376005|1800799015|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?ZHpCw0EP17SxIOaUaGMVwUvgR4ATaaIZ7X2wCiMTCwOnUHJhkjaSqBITGMRu?= =?us-ascii?Q?7DfYIPo9KZ/tE3rYIFFGzUc12xdE0MyxG8LzOYrW8FDJFvAeIeUgK65ymlIJ?= =?us-ascii?Q?9kqAXaaCByeD2XQwK2fpyo/mCDEaitZ0hs2Su09W3Z8i/A93Ox4Qv7sAhYt3?= =?us-ascii?Q?XKWyCFsY4N2Na/EhQZNZgDpj8fWsVC0vDEcVIZgGlUuk+HzDupxMrp/yJqv+?= =?us-ascii?Q?/3YxLKykQFLJ+is6Rh2KqUD9+eDc1Q+dkamcYmJKHCnc0Cq1kUfsOKs+7Dax?= =?us-ascii?Q?P/XN1Y91kgQgzl2jsZrtF/mwGJF9+B3XjDzGvHi8KmodYQJej/BeP4KeeBM8?= =?us-ascii?Q?Apm3oAe6w0OQnUOyvXe+CrewavduEOROGxyHOn6SsXpg5sn0JTERDJX4bq/c?= =?us-ascii?Q?kX1CGZvdDWm3wkwGQJxLCjhmi8K/rCs1Eve7Oiv5L6K6fO9R+1Uef16i39aW?= =?us-ascii?Q?zrgtgeJZfdYU/ze1323qjm4YNAjKTo0I9qEtaKTbj/gEAkuen+JPRWNiacZ6?= =?us-ascii?Q?UPB9AFVBfW+rY6fyjrDnjG3mEaFAISGnyJj7gp5OnFfwiYh2skJRWgQrozTU?= =?us-ascii?Q?C+tbAniCh9HuIdmaORgYMsrjkOdfSEjZAxTAqSWNs4piVr+ZQXjGDya8sd0+?= =?us-ascii?Q?gbB4iKla+wQGTX0h/vzmDLE18mqPQ/gA2BYG8YM74aR+SqKWpdDjWxCcCuTj?= =?us-ascii?Q?yP2gNakG9ADpVGJhX2hLKli2ZpBdIVfPeUPgzX3ca+9fKV8J8DUAM//QNgLW?= =?us-ascii?Q?VacAsniwVCx4VBGOJ6OiED4HEc444cadmx1qMZyn4JgLuVmpCPQd2Pg5Ufhm?= =?us-ascii?Q?p/93OXLmrLcP/Aa1BXU5ATe2czFKB0dAElerNX7i9/wJ2AKzE69aYhf4tx3u?= =?us-ascii?Q?j6L9jE+z2cNfRNuWKfZCyY82TsATQs81A/+KRmhHJFkm4kjoygR2WvG1cYhF?= =?us-ascii?Q?6fmQ4+hNoY2D+9wbx/5h2sSgEDPKkBuY7cTv85ZE9RSSrcMDTWSuE5LddxkA?= =?us-ascii?Q?qQYdmwGJjRKxYdsNJka2zYc5wIat8d1a6Ykv2SK2eJtx1cI57N3y3gZNU6j4?= =?us-ascii?Q?fRZ/uuRgpiXELhshL0z5hQi7pooBiC/aTyXDkUaNetKcCzYiD4KJbzh6vp/+?= =?us-ascii?Q?BQqtbkYufLJmopsvsx/Ll4tdEJUyBrvKnLq8/kLhkSnImhsnEncbNO7poT0n?= =?us-ascii?Q?21IHx9VzJVF3vtBPRmzKjCDS3/aHNlUVvOnvdLs5jCcgxdQCk4QHe85BsGSI?= =?us-ascii?Q?n92sPRG+VzBFP7PXmOz7Nkx/7dTw77rJunQ0lOQUXqbgXIeUSN2HHRsrB0FY?= =?us-ascii?Q?DT4Zp/O9ydG+9bp7vetDUd6Vavw8D8iobQ3vvIVViDHo753i+/om0gTsB0N2?= =?us-ascii?Q?5X3eB9I=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR84MB1581.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(7416005)(366007)(376005)(1800799015)(38070700009);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?R8dQwFePxcNLvT9pH1rcHHczavqdxIJ3wDHujH1jepM7SOYjPiyoeH0dJuSA?= =?us-ascii?Q?OJITjh+Rf6Ycd9BlpQf3EPVxvfSl+aDdH4PTw6QoSVeKI/YFfoX9Do/yIzIA?= =?us-ascii?Q?4a44P6+0VP9c3n9khGcKUceXPtuoa4pjZYWtcI6rGFkZn+T8S5YyzFTYhROk?= =?us-ascii?Q?Mmvov21pZVAZnQU16v6VS6W/sYN1jZs5AAP4wQAM1oHdLVn188xb5THeI1lu?= =?us-ascii?Q?hL7PPfkqB3Nt/roaJfw6QWhJCr2qR3EjKB52MlIGKNRRZKmDRw0HWUTS+jPW?= =?us-ascii?Q?XNvPqYc6PiQUC+2hyTwA9O7/zHJYbzK/RSni5G3joNnpKc/yfzVjSRoqtJa8?= =?us-ascii?Q?foAsqnKkAKZL78ji9mF0Vd8pgGjyb6bKChrwPsM7lv/583ydqFAkcx0sY8wc?= =?us-ascii?Q?gGO996gMIOuQeWgxu341tiHpOtmadzzfsp0AZOfaRGktMyVIoVFLMI66JPYW?= =?us-ascii?Q?bIVamrt6bgtmleMhWS6tYG6O1Uh6b6s32kQsx3YhUZyj4Kz4ffzMAQxVT5ZN?= =?us-ascii?Q?QshKQjllfbI3oSD4UpYmg80UKyml5LvZk3Klk09ORFvqkhvCU61K9BkcPZox?= =?us-ascii?Q?lYHlCbcDIjWiK7F8rUuXWkg5gvfpPiJW1zIk8xXNVi/hMflht8XVSMtlYD4i?= =?us-ascii?Q?ewhmkBJW55Gn0xwlHfNCUai7UafmXQBqWllqkpLDV9RfowuQjLiHu47LVf82?= =?us-ascii?Q?wP7gax5ORGs14LaKzckx30ZjEFA5Nk+V2iExE01IQBR2czDSBhpMQvuIm2OV?= =?us-ascii?Q?Lzxw+TCFk0EW5Hb8ak0rxXnlb19FAlsQT02Wfgmk4TztIZvhiS3JB3iYqmYK?= =?us-ascii?Q?lw4c+q9mEQpgKUERO+cBe0V+4udzI4u2u8rApj6IUWwjxSB1fmBklHcjLwaB?= =?us-ascii?Q?9ScKBO+zdk/u1emP9yjxK4woAaZ/vuRtQi1elybxKdLyVIdpdEAR+OAmxkCg?= =?us-ascii?Q?0A+JsvbKMch35EnmDQME5JsKBu3iqoC4n8CFP9nzKGg/h8Ie8afVVkhSIa3q?= =?us-ascii?Q?GL+CvdTs1fbw1+5jQ4Bx6koK/kOoCvTyQtHGtE/Bd1tn5/MONr4TIB1x35YE?= =?us-ascii?Q?awUn2uMXhvjsJZ2uFHm4R7LKfkAT6Sehl62G6gHXUlTxHzWvjJLWSXA9dtmn?= =?us-ascii?Q?eQkQRyx2PvqQZeHRiyqLVVuGHUIdpK8AIXvbXVSsuPdJc50sGAYDDoZnkKTn?= =?us-ascii?Q?ANjduaatm4+8zFSnokRK0pabL+bzQvhuQOOW3L8PaGvAKU0nzHCceZVMnw2E?= =?us-ascii?Q?cpjpLl+l3E5Hps6X2JOt0cvPOgoDd9zmax3nZHQdjAB0PBUZAF4H3JuW7Txt?= =?us-ascii?Q?OskXvA+R3sCI5hVivrnBXPkj46H7iuNxT70rLq1t5U1BH3q4ZUHtbaUvoZG2?= =?us-ascii?Q?1raKwlKtLvV/UzXMV3EwHdQKFd4vWCbTINnFB8mLUk46vp97fwmVw0w4ChIG?= =?us-ascii?Q?y+QBYd3o9MoJe6+y0J3COhgiaOtB5YiqCBNk2NiKgCUqXsYUoQmVeGXrHbGA?= =?us-ascii?Q?opD0tgfLQd40yexjaDywZsXdIrRNlfH38w5IVfY/jleoapUZ8dY67sjH35cz?= =?us-ascii?Q?3gd6hZWUdfteLPIKp61X1gSQJvW3qTsa5CobvYRg?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR84MB1581.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: f9761b7f-2965-4581-b9c5-08dc89e5ec29 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2024 07:12:58.1816 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QGCe5wv9VB5muKl4Hnj5z+LMV4oJ4NOjQYwHM18wjmSvyZCNvN7NyAkErXv1mg0la2SfX67oKnlD7RAx7PgRtA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR84MB1832 X-OriginatorOrg: hpe.com X-Proofpoint-GUID: LKILvaZpfBR5BBQx_Hb4-4OlRI5_3G94 X-Proofpoint-ORIG-GUID: LKILvaZpfBR5BBQx_Hb4-4OlRI5_3G94 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-11_02,2024-06-11_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=782 spamscore=0 priorityscore=1501 clxscore=1011 adultscore=0 phishscore=0 bulkscore=0 mlxscore=0 impostorscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2406110053 > I would also think about why Intel has not submitted this code before? > Maybe because it does things the wrong way? Please look at how other > Ethernet drivers support firmware. Is it the same? It might be you need t= o > throw away this code and reimplement it to mainline standards, maybe usin= g > devlink flash, or ethtool -f. See Jacob's reply for details. =20 > One additional question. Is the firmware part of linux-firmware? Given th= is is > Intel, i expect the firmware is distributeable, but have they distributed= it? It is the Intel 10G NIC firmware embedded into HPE firmware update packages= and redistributed to the end user. Thanks, Richard