Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759388AbYBFWRy (ORCPT ); Wed, 6 Feb 2008 17:17:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754897AbYBFWRn (ORCPT ); Wed, 6 Feb 2008 17:17:43 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:47922 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754635AbYBFWRl (ORCPT ); Wed, 6 Feb 2008 17:17:41 -0500 Date: Wed, 6 Feb 2008 14:16:36 -0800 From: Andrew Morton To: Gianluca Alberici Cc: chuck.lever@oracle.com, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: NFS EINVAL on open(... | O_TRUNC) on 2.6.23.9 Message-Id: <20080206141636.1001b1c5.akpm@linux-foundation.org> In-Reply-To: <47AA2CB6.9070908@abinetworks.biz> References: <476CEC5E.9070002@abinetworks.biz> <838DE9A2-59B2-49FA-B3E8-89B26368B1CF@bluecamel.eml.cc> <476E47F5.4090807@abinetworks.biz> <20071225140431.9264970a.akpm@linux-foundation.org> <199BEBA7-E46E-4B1F-9D36-91BB43331B75@oracle.com> <4791EE99.3030802@abinetworks.biz> <5FD6714F-EF9A-4F07-B2B6-D6F6CC911936@oracle.com> <479C744A.6020207@abinetworks.biz> <12964A18-350B-443F-B15A-D78B3723C89A@oracle.com> <479F2463.2040704@abinetworks.biz> <4AAA3DAF-898C-4ED5-BD07-4FD2B5CEEF16@oracle.com> <7EE4B02B-3359-41C0-BFED-0947DF9F5F5A@oracle.com> <479F8377.6090704@abinetworks.biz> <1201638661.7969.7.camel@heimdal.trondhjem.org> <47A0704D.7080808@abinetworks.biz> <47A9FB91.2040304@abinetworks.biz> <47AA2CB6.9070908@abinetworks.biz> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1977 Lines: 46 On Wed, 06 Feb 2008 22:55:02 +0100 Gianluca Alberici wrote: > I finally got it. Problem and solution have been found from 6 month but > nobody cared...up to now those servers have not been mantained, this > problem is not discussed anywhere else than the following link. > The bug (userspace server side i would say at this point) is well > described from the author of an nfs-user-server patch which has not been > managed yet. The magic hint to find it on google was 'nfs server > utimensat' :-) > > http://marc.info/?l=linux-nfs&m=118724649406144&w=2 This is pretty significant. We have on several occasions in recent years tightened up the argument checking on long-standing system calls and it's always a concern that this will break previously-working applications. And now it has happened. If we put buggy code into the kernel then we're largely stuck with it: we need to be back-compatible with our bugs so we don't break things like this. > I have already prepared a working patch for cfsd based upon the one ive > listed. The nfs patch is of course waiting for commit since august, > 2007. Ill submit it to debian cfsd mantainers, hoping to have more > chance than my predecessor. > It doesnt seem to me that there was any kernel related issue. > > Thanks a lot again, sorry for the lots of noise i have done. I will try > to be more appropriate next time. That wasn't noise - it was quite valuable. Thanks for all the work you did on this. Given that our broken-by-unbreaking code has been out there in several releases there isn't really any point in rebreaking it to fix this - the offending applications need to be repaired so they'll work on 2.6.22 and 2.6.23 anyway. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/