Received-SPF: pass (google.com: domain of linux-kernel+bounces-209466-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 11 Jun 2024 16:16:28 +0800
From: Xu Yilun <yilun.xu@linux.intel.com>
To: linux@treblig.org
Cc: mdf@kernel.org, hao.wu@intel.com, linux-fpga@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fpga: altera-fpga2sdram: remove unused struct 'prop_map'
Message-ID: <ZmgH3FakPP2w/ksI@yilunxu-OptiPlex-7050>
References: <20240530205245.125513-1-linux@treblig.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240530205245.125513-1-linux@treblig.org>

On Thu, May 30, 2024 at 09:52:45PM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>

This is only needed if the person sending the patch is not the author.

> 
> 'prop_map' has been unused since the original
> commit e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support").

Please use 'fixes:' tag.

Thanks,
Yilun

> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  drivers/fpga/altera-fpga2sdram.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/fpga/altera-fpga2sdram.c b/drivers/fpga/altera-fpga2sdram.c
> index 6b60ca004345..f4de3fea0b2d 100644
> --- a/drivers/fpga/altera-fpga2sdram.c
> +++ b/drivers/fpga/altera-fpga2sdram.c
> @@ -75,12 +75,6 @@ static int alt_fpga2sdram_enable_set(struct fpga_bridge *bridge, bool enable)
>  	return _alt_fpga2sdram_enable_set(bridge->priv, enable);
>  }
>  
> -struct prop_map {
> -	char *prop_name;
> -	u32 *prop_value;
> -	u32 prop_max;
> -};
> -
>  static const struct fpga_bridge_ops altera_fpga2sdram_br_ops = {
>  	.enable_set = alt_fpga2sdram_enable_set,
>  	.enable_show = alt_fpga2sdram_enable_show,
> -- 
> 2.45.1
> 
>