Received-SPF: pass (google.com: domain of linux-kernel+bounces-209458-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <2024061137-jawless-dipped-e789@gregkh>
In-Reply-To: <2024061137-jawless-dipped-e789@gregkh>
From: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Date: Tue, 11 Jun 2024 17:16:30 +0900
Message-ID: <CAMZ6Rq+rS=LO2EL7Mzurdsv3LVMmiJ3C9a9yEsdMJeqBaRbLMg@mail.gmail.com>
Subject: Re: [PATCH v2] .editorconfig: remove trim_trailing_whitespace option
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: masahiroy@kernel.org, linux-kernel@vger.kernel.org, 
	linux-doc@vger.kernel.org, Danny Lin <danny@kdrag0n.dev>, 
	=?UTF-8?B?w43DsWlnbyBIdWd1ZXQ=?= <ihuguet@redhat.com>, 
	=?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= <mic@digikod.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue. 11 juin 2024 at 16:27, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> Some editors (like the vim variants), when seeing "trim_whitespace"
> decide to do just that for all of the whitespace in the file you are
> saving, even if it is not on a line that you have modified.  This plays
> havoc with diffs and is NOT something that should be intended.
>
> As the "only trim whitespace on modified files" is not part of the
> editorconfig standard yet, just delete these lines from the
> .editorconfig file so that we don't end up with diffs that are
> automatically rejected by maintainers for containing things they
> shouldn't.
>
> Cc: Danny Lin <danny@kdrag0n.dev>
> Cc: =C3=8D=C3=B1igo Huguet <ihuguet@redhat.com>
> Cc: Micka=C3=ABl Sala=C3=BCn <mic@digikod.net>
> Cc: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Fixes: 5a602de99797 ("Add .editorconfig file for basic formatting")
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Thanks, this v2 is way better!

Acked-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>

> ---
> v2: - only remove the lines, don't move the whole file to Documentation
>     - add Fixes: tag
>
>
>  .editorconfig | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/.editorconfig b/.editorconfig
> index 854773350cc5..29a30ccfc07b 100644
> --- a/.editorconfig
> +++ b/.editorconfig
> @@ -5,7 +5,6 @@ root =3D true
>  [{*.{awk,c,dts,dtsi,dtso,h,mk,s,S},Kconfig,Makefile,Makefile.*}]
>  charset =3D utf-8
>  end_of_line =3D lf
> -trim_trailing_whitespace =3D true
>  insert_final_newline =3D true
>  indent_style =3D tab
>  indent_size =3D 8
> @@ -13,7 +12,6 @@ indent_size =3D 8
>  [*.{json,py,rs}]
>  charset =3D utf-8
>  end_of_line =3D lf
> -trim_trailing_whitespace =3D true
>  insert_final_newline =3D true
>  indent_style =3D space
>  indent_size =3D 4
> @@ -26,7 +24,6 @@ indent_size =3D 8
>  [*.yaml]
>  charset =3D utf-8
>  end_of_line =3D lf
> -trim_trailing_whitespace =3D unset
>  insert_final_newline =3D true
>  indent_style =3D space
>  indent_size =3D 2
> --
> 2.45.2
>