Received-SPF: pass (google.com: domain of linux-kernel+bounces-209502-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: "Hennerich, Michael" <Michael.Hennerich@analog.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        "linux-input@vger.kernel.org"
	<linux-input@vger.kernel.org>,
        "Sa, Nuno" <Nuno.Sa@analog.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 1/4] Input: adxl34x - use device core to create
 driver-specific device attributes
Thread-Topic: [PATCH v2 1/4] Input: adxl34x - use device core to create
 driver-specific device attributes
Thread-Index: AQHau1VHoUP6sdn6nk20zqnTQKtPUrHCQI2A
Date: Tue, 11 Jun 2024 08:45:02 +0000
Message-ID: 
 <PH0PR03MB65124C79F46C7300DA8074088EC72@PH0PR03MB6512.namprd03.prod.outlook.com>
References: <20240610164301.1048482-1-dmitry.torokhov@gmail.com>
In-Reply-To: <20240610164301.1048482-1-dmitry.torokhov@gmail.com>
Accept-Language: en-US, de-DE
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?31IAuuKeJZ0Qv7MOhWVXY/eEGs6R3KpY5INngvsHh/VhPgMnNDj0m2V6o5MO?=
 =?us-ascii?Q?U40x7QK1+aBnOpQrYGuaDlICjn9vvZy4jyh6OavEJDlD/k3WSPfo95tpALIf?=
 =?us-ascii?Q?6p49WRRQaBmEfkSTE2VSUDeRgmmIEFqKCeUfXzeEL3JMq8jGwAXwhg1adb6M?=
 =?us-ascii?Q?0fa4rDFjesFSprw5/TqmslXBxcrIaMBnHqrq8kg2d2oMpWBHL8y8kGBbgDJm?=
 =?us-ascii?Q?JP4OeCSLgCGvlHsTMyFFCNXK+tnlrSQ/nmsVStVQoBWgaYLxQFJvNbuXcbFk?=
 =?us-ascii?Q?pj/OeA7pEsOjWbC2Jmj7pxvbRGHz75KFnq4qwPkTFdf017Y3NYrUGxx+dbee?=
 =?us-ascii?Q?EucxKrV9Y0+wGKIvbW4jbFn3NZU+woUEFDtFRbjXuDwoTUQzjqNagYsDbHSm?=
 =?us-ascii?Q?d7/aEfvYtDzGIOZVfzXCXeRzEwl68s60JyALFU4jSO1JPdMevggkv6I+mWj/?=
 =?us-ascii?Q?V0uMi4iUhmNHEq1goQV4VvnxzB6764DKKJUILApC3e22UG6U0XWkfTC50rY+?=
 =?us-ascii?Q?6YYvOxkG18qCSEIxXx4W31gpBA4mmrJeZmBwl9mJj24nz/cdsPVAtdZ0sZK1?=
 =?us-ascii?Q?6OBpJtDB1+7PbwcuYJ2osnhO0j4PVFqroGe52SX10w5ZlYOmTZXjNjfcEyf7?=
 =?us-ascii?Q?fmqKwIsp7GrYL88UrBbIeSolzCWID3MuibDmWavk5seRPoDK2AsE1H19qg1U?=
 =?us-ascii?Q?hIuvfYH3+WbVUmfwEgnooqzFLGMQ/oB+3Q/7MLPrL5daV5TXKZUfxBvaXPVa?=
 =?us-ascii?Q?1BXjNy/1n6Kds3NhENwMxE5GJqXO88h1DLUOD2PBnEAV28elf2R7R5H1kYDo?=
 =?us-ascii?Q?QKrdg2ygpJVyM7sZJEBE+FQuATeNd+qWjc2HuUGpXQZ9csN4MRcP/Heto7jm?=
 =?us-ascii?Q?4r3OA23YEJaKpHghzspMqpK1km3W6prb2OK28TMDvXo1a0Po6PK9PraL7TnR?=
 =?us-ascii?Q?GYLCbzRgj+hUVVMNlMJ7jxTp01TUDH4klENDKB6eibWsSYbqsDJt6kWVoEO0?=
 =?us-ascii?Q?cOfZ0DxqsPiPd5khjGU15lHQmX0g4I+VRmAkaWgnyFw89LK5mzoCDi4JfHyL?=
 =?us-ascii?Q?IB90eJjAzL3ohi11TKrUOexjnptnxPkMaQ/KGE0aG0aMq9wdL0XKYL3YCKIG?=
 =?us-ascii?Q?TEnyQgMkIbMbIDlXO7270erY3a9xmJ9vsilm4P78WCjvBTPIQLV4AwvwnXFk?=
 =?us-ascii?Q?MYQ2TYxgaVXjUJlvwDttCaPTDTYDuyipKclrx5v1NmpUc/YbQXykO8sv32kG?=
 =?us-ascii?Q?rOPWmHemq5GEgQEY76x/4tQctkbgImD1yJgKUYUI0AGhsb88v4TYlM9vUUmd?=
 =?us-ascii?Q?cZko+Pg3TY5Jj7LJm6CKk/5fRMqsdMS7eXDJPEW7mPoCG5yqFABBlthV3FCR?=
 =?us-ascii?Q?OCGKkG9qXDbR3CVMo5TTcIFWGSRJTy+74JDSxjSyeAICB6skjydexM2YBcX1?=
 =?us-ascii?Q?VkG5ucg2+IfX/ru7mM/8fOxVIHly2Wj5tjnWl4uH3MR42x3V0WEF6w1vJdjs?=
 =?us-ascii?Q?vqLFEjJI8QPsUd5+F1sNsObigr1qGyAB2akq8lXXkl/hNYBDhYRbcEQHF2E2?=
 =?us-ascii?Q?ePk4ju1LOQ3fUOhZ7KlRzVQeN73egio4PtJCa/fAnNmxJGrDxsYbJxYVCABi?=
 =?us-ascii?Q?hQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB6512.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 68fd24ca-5097-4822-2426-08dc89f2c900
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2024 08:45:02.6627
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /lP3lF0IlgunxPFwsimR+ROAxjXqeeH3Cp37dY01aI9FHp9zMjpXpKK0TVl/hb18SzEg3Tsi6OJ/uC2mraNGbqnFEGtr/zrofoMi5GoLeRk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR03MB7196
X-Proofpoint-GUID: zhvLmmeZuzXE8bl00Dgd6hVoD4w3Ll4k
X-Proofpoint-ORIG-GUID: zhvLmmeZuzXE8bl00Dgd6hVoD4w3Ll4k
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-11_04,2024-06-11_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0
 lowpriorityscore=0 spamscore=0 mlxscore=0 adultscore=0 priorityscore=1501
 malwarescore=0 phishscore=0 impostorscore=0 clxscore=1011 mlxlogscore=999
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2405170001 definitions=main-2406110065


> -----Original Message-----
> From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Sent: Monday, June 10, 2024 6:43 PM
> To: linux-input@vger.kernel.org; Sa, Nuno <Nuno.Sa@analog.com>
> Cc: Hennerich, Michael <Michael.Hennerich@analog.com>; linux-
> kernel@vger.kernel.org
> Subject: [PATCH v2 1/4] Input: adxl34x - use device core to create driver=
-
> specific device attributes
>=20
>=20
> Instead of creating driver-specific device attributes with
> sysfs_create_group() have device core do this by setting up dev_groups
> pointer in the driver structure.
>=20
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Acked-by: Michael Hennerich <michael.hennerich@analog.com>

> ---
>=20
> v2: added Nono's ACK
>=20
>  drivers/input/misc/adxl34x-i2c.c |  1 +  drivers/input/misc/adxl34x-spi.=
c |  1
> +
>  drivers/input/misc/adxl34x.c     | 15 +++++++--------
>  drivers/input/misc/adxl34x.h     |  1 +
>  4 files changed, 10 insertions(+), 8 deletions(-)
>=20
> diff --git a/drivers/input/misc/adxl34x-i2c.c b/drivers/input/misc/adxl34=
x-
> i2c.c
> index d4014e367c77..7531c7b2d657 100644
> --- a/drivers/input/misc/adxl34x-i2c.c
> +++ b/drivers/input/misc/adxl34x-i2c.c
> @@ -132,6 +132,7 @@ MODULE_DEVICE_TABLE(of, adxl34x_of_id);  static
> struct i2c_driver adxl34x_driver =3D {
>  	.driver =3D {
>  		.name =3D "adxl34x",
> +		.dev_groups =3D adxl34x_groups,
>  		.pm =3D pm_sleep_ptr(&adxl34x_pm),
>  		.of_match_table =3D adxl34x_of_id,
>  	},
> diff --git a/drivers/input/misc/adxl34x-spi.c b/drivers/input/misc/adxl34=
x-
> spi.c
> index f1094a8ccdd5..2befcc4df0be 100644
> --- a/drivers/input/misc/adxl34x-spi.c
> +++ b/drivers/input/misc/adxl34x-spi.c
> @@ -97,6 +97,7 @@ static void adxl34x_spi_remove(struct spi_device *spi)
> static struct spi_driver adxl34x_driver =3D {
>  	.driver =3D {
>  		.name =3D "adxl34x",
> +		.dev_groups =3D adxl34x_groups,
>  		.pm =3D pm_sleep_ptr(&adxl34x_pm),
>  	},
>  	.probe   =3D adxl34x_spi_probe,
> diff --git a/drivers/input/misc/adxl34x.c b/drivers/input/misc/adxl34x.c =
index
> a3f45e0ee0c7..fbe5a56c19d1 100644
> --- a/drivers/input/misc/adxl34x.c
> +++ b/drivers/input/misc/adxl34x.c
> @@ -664,6 +664,12 @@ static const struct attribute_group
> adxl34x_attr_group =3D {
>  	.attrs =3D adxl34x_attributes,
>  };
>=20
> +const struct attribute_group *adxl34x_groups[] =3D {
> +	&adxl34x_attr_group,
> +	NULL
> +};
> +EXPORT_SYMBOL_GPL(adxl34x_groups);
> +
>  static int adxl34x_input_open(struct input_dev *input)  {
>  	struct adxl34x *ac =3D input_get_drvdata(input); @@ -823,13 +829,9
> @@ struct adxl34x *adxl34x_probe(struct device *dev, int irq,
>  		goto err_free_mem;
>  	}
>=20
> -	err =3D sysfs_create_group(&dev->kobj, &adxl34x_attr_group);
> -	if (err)
> -		goto err_free_irq;
> -
>  	err =3D input_register_device(input_dev);
>  	if (err)
> -		goto err_remove_attr;
> +		goto err_free_irq;
>=20
>  	AC_WRITE(ac, OFSX, pdata->x_axis_offset);
>  	ac->hwcal.x =3D pdata->x_axis_offset;
> @@ -889,8 +891,6 @@ struct adxl34x *adxl34x_probe(struct device *dev, int
> irq,
>=20
>  	return ac;
>=20
> - err_remove_attr:
> -	sysfs_remove_group(&dev->kobj, &adxl34x_attr_group);
>   err_free_irq:
>  	free_irq(ac->irq, ac);
>   err_free_mem:
> @@ -903,7 +903,6 @@ EXPORT_SYMBOL_GPL(adxl34x_probe);
>=20
>  void adxl34x_remove(struct adxl34x *ac)  {
> -	sysfs_remove_group(&ac->dev->kobj, &adxl34x_attr_group);
>  	free_irq(ac->irq, ac);
>  	input_unregister_device(ac->input);
>  	dev_dbg(ac->dev, "unregistered accelerometer\n"); diff --git
> a/drivers/input/misc/adxl34x.h b/drivers/input/misc/adxl34x.h index
> f9272a2e7a96..67e0ddc5c3eb 100644
> --- a/drivers/input/misc/adxl34x.h
> +++ b/drivers/input/misc/adxl34x.h
> @@ -26,5 +26,6 @@ struct adxl34x *adxl34x_probe(struct device *dev, int
> irq,  void adxl34x_remove(struct adxl34x *ac);
>=20
>  extern const struct dev_pm_ops adxl34x_pm;
> +extern const struct attribute_group *adxl34x_groups[];
>=20
>  #endif
> --
> 2.45.2.505.gda0bf45e8d-goog