Received-SPF: pass (google.com: domain of linux-kernel+bounces-209512-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240528-alice-mm-v7-0-78222c31b8f4@google.com>
 <20240528-alice-mm-v7-4-78222c31b8f4@google.com> <882a4ba5-b0ef-4c21-8167-e2949424912c@redhat.com>
In-Reply-To: <882a4ba5-b0ef-4c21-8167-e2949424912c@redhat.com>
From: Alice Ryhl <aliceryhl@google.com>
Date: Tue, 11 Jun 2024 10:51:19 +0200
Message-ID: <CAH5fLgjrt0Ohj1qBv=GrqZumBTMQ1jbsKakChmxmG2JYDJEM8w@mail.gmail.com>
Subject: Re: [PATCH v7 4/4] rust: add abstraction for `struct page`
To: Abdiel Janulgue <abdiel@redhat.com>
Cc: Miguel Ojeda <ojeda@kernel.org>, Matthew Wilcox <willy@infradead.org>, 
	Al Viro <viro@zeniv.linux.org.uk>, Andrew Morton <akpm@linux-foundation.org>, 
	Kees Cook <keescook@chromium.org>, Alex Gaynor <alex.gaynor@gmail.com>, 
	Wedson Almeida Filho <wedsonaf@gmail.com>, Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>, 
	=?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>, 
	Benno Lossin <benno.lossin@proton.me>, Andreas Hindborg <a.hindborg@samsung.com>, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@android.com>, 
	Todd Kjos <tkjos@android.com>, Martijn Coenen <maco@android.com>, 
	Joel Fernandes <joel@joelfernandes.org>, Carlos Llamas <cmllamas@google.com>, 
	Suren Baghdasaryan <surenb@google.com>, Arnd Bergmann <arnd@arndb.de>, Trevor Gross <tmgross@umich.edu>, 
	linux-mm@kvack.org, linux-kernel@vger.kernel.org, 
	rust-for-linux@vger.kernel.org, Christian Brauner <brauner@kernel.org>, 
	Danilo Krummrich <dakr@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 10, 2024 at 10:47=E2=80=AFPM Abdiel Janulgue <abdiel@redhat.com=
> wrote:
>
> Hi,
>
> On 28/05/2024 17:58, Alice Ryhl wrote:
> > Adds a new struct called `Page` that wraps a pointer to `struct page`.
> > This struct is assumed to hold ownership over the page, so that Rust
> > code can allocate and manage pages directly.
> >
> > +
> > +impl Drop for Page {
> > +    fn drop(&mut self) {
> > +        // SAFETY: By the type invariants, we have ownership of the pa=
ge and can free it.
> > +        unsafe { bindings::__free_pages(self.page.as_ptr(), 0) };
> > +    }
> > +}
> >
>
> What about cases where the struct page pointer is not owned or allocated
> by this wrapper? For example, pages returned vmalloc_to_page()?
> Any thoughts about exposing a provision to avoid freeing those pages
> during Drop?
>
> We've been experimenting in adapting this Page wrapper in advance for
> page management within the Nova DRM driver.

That would make a lot of sense, but this Page wrapper doesn't support
it. You are very welcome to extend it.

There are essentially two ways to go about it:

1. Change the Page struct to be a `Opaque<bindings::page>` and use the
types &Page and BoxLikeType<Page> for these two purposes. Here,
BoxLikeType would be a new type that is to Box in the same way as how
ARef is to Arc.
2. Introduce a new PageRef<'a> type that's like a reference to a page.
You can have Page deref to PageRef so that they share methods.

The second solution is easiest right now. The first solution is
probably what we want long-term.

Alice