Received-SPF: pass (google.com: domain of linux-kernel+bounces-209534-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Lei Liu <liulei.rjpt@vivo.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	=?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= <arve@android.com>,
	Todd Kjos <tkjos@android.com>,
	Martijn Coenen <maco@android.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	Christian Brauner <brauner@kernel.org>,
	Carlos Llamas <cmllamas@google.com>,
	Suren Baghdasaryan <surenb@google.com>,
	linux-kernel@vger.kernel.org
Cc: opensource.kernel@vivo.com,
	Lei Liu <liulei.rjpt@vivo.com>
Subject: [PATCH] binder_alloc: replace kcalloc with kvcalloc to mitigate OOM issues
Date: Tue, 11 Jun 2024 16:56:28 +0800
Message-Id: <20240611085629.25088-1-liulei.rjpt@vivo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RzBKYWRQOFM5Z01mU0lLYXMxVUN4NVJYL1dSanB3bDc0RzFLdjdlNEVYMFlG?=
 =?utf-8?B?WnBuQ1h3L2FDZEJ5N25vYmlIL3o4RzdObld2NE4xSFBRdVRxVURUM3cxNEcx?=
 =?utf-8?B?WXRMSWI0NFR5UEpOY2t3SGdHUGcyaTRSTUEvUEgwTlN4MmlBYVFRQ3FrZ3Vq?=
 =?utf-8?B?ZmN3SHlFUi82bDlyWHNXanR0VkRvaEIzYW5xaUMrN2lSSE9KTGhTT0oxVG1F?=
 =?utf-8?B?NTZoS1JEaWdxKzU1RlFHOWZNaFZmR2Q5ek9xSzVudUtUT1dWaDlZSUloUkZQ?=
 =?utf-8?B?TjJNVDZETFAvcDNCQzkyTlVsTGp2RkFBMXM5T2ozVWFMNlJjMXJianZ0YXgx?=
 =?utf-8?B?ZlRzNktlZXBkNWsyODI5NkpUVFM1Z1daNWZaN2lYOHAyTCt4RkV0b0hHQkRm?=
 =?utf-8?B?em9EenE5R29EdmpIUkg0U21kVXB3VmtLTHFDY3lydW5Bek9FTklEbmlPYlBV?=
 =?utf-8?B?Sk1HaTgyaHc2ZGpFQ3BqbEdMd1gzK082bG00RXVhWU0yN2JxZDdGZ296Vnpu?=
 =?utf-8?B?UktSN2pkVkUvRG5NTExpbEhzUkpQbjlCTk9TU2dEWjMySXE5L0tMOWxHK28r?=
 =?utf-8?B?bnFka3pmVXpST3FPTGlnWHdYQzZxVzIxbXJKYlRGMEd5SXhETitrN0ZHaWtj?=
 =?utf-8?B?Q1JYNXVjWlVRSU5WWG8wYUVNOWV2RFJocHlIc1NQbG1SeTBRNU00Z0I5TTFV?=
 =?utf-8?B?aXZqZXRZN2NmYytkTS9jSWlmclIvQ3RreEVzaTZoVFBmbmtxeHRNWjJOdDk1?=
 =?utf-8?B?dWJQUG83T21jN21Vek1hT0VxWXQ0VDZwc3R0ZTJGTnFoQVdKTnJRdnlCKytW?=
 =?utf-8?B?aTdNWFRyZTNWYWRYRXlLRlJXYzlEV0Fid2JYRU16UDY0MzFUeDJwU1VwUHgx?=
 =?utf-8?B?bVUzWWtBK0xNdFRtOUVId0c0SDNVRTJGb29HL0JFeGtsL0hDZ0JxamNUcDN5?=
 =?utf-8?B?Y2s5S2VjT0VJcXRvN0hwZUdZanlGQURiZzhCeEJjZ2c1bTNQK0dnL2wvRjhh?=
 =?utf-8?B?YmsvK2cwSTF6Z2lzTjg0WXAvZHdrRWFDY0FreWpOMGRaNEpiQXBzYzhoaDE2?=
 =?utf-8?B?a0R2Vjc4T1lFVXlPVTh2b041NTZ2T0gwSWdKZUlIY29yUGx6ZzlZMzBIbXNz?=
 =?utf-8?B?bHJ3OVpNV0hnNTZSbkw1Lzl2MFluZFljOUxINUhOdTZFcmxxdjAvdlB6MFFs?=
 =?utf-8?B?dURqRHd3a25HMHlBRXBybTRhRXRUYWhoZzJmQ0FCY0hDd0hRYjFDdmFKa1Fo?=
 =?utf-8?B?dzk1MjFmVHpYem81cUhyZ1JsWWRUb2VzamtwcnphRlNsZnBIUXgyK2FrY1Bu?=
 =?utf-8?B?bmVla2hsL0JuRnlzL1Rka0lPS2syOHVWSE1xdzB6djdwdnEvZmF1WFNjRjho?=
 =?utf-8?B?ZFJVSHUxTzNCLzZLcFFPWkl3a1hpTHpDSzRrT1NKV2ExZTdjREpqYWU3WlBk?=
 =?utf-8?B?Q3pFQW9XREhJaWl1ekk3STdRV3laMFVXNFF6OHRqSGxhdVRJc2xLOStEbFo4?=
 =?utf-8?B?b3BqY0ZGRFZqRGVCVGZIbFJLdWFlNGRHMmhXMTAyZmZKSTg3cEhhMFpCdUdK?=
 =?utf-8?B?cmxkVjV4eEh1dmZxcW4va2pUdVBCckdtUmJUVklueERKVHJwYmRsaWNRNGlH?=
 =?utf-8?B?d2JmcnpyU1U5dzcrY3MyVVRFNUthVUthTEFpOUVNZ3B0UXh1Vy9mc0RrVk1O?=
 =?utf-8?B?dnd1Z3VOTGtybldDd2xPYmpvYnhmL1RJZzh1NHh1aXhEVFNrUmllSCs0VTFr?=
 =?utf-8?B?YTlPZk5IZWQ1dU4wTDJBdUNwakhGclFwZndVZEFhK3NXUUU0OFN5SnAxaFFS?=
 =?utf-8?B?Sk12K1ZEbGxkUWZ4TEZtUUtsN1pPK0hpUzRTQmovbWdJRXFabW9aaE9wL0J0?=
 =?utf-8?B?dHByYzFCOCtsWHYxVG1mYjYwdEVUQURqSEJLWk9yQzJod3ZncEJ3ZDhKY3dG?=
 =?utf-8?B?eGFwZ2xRcXZiVWgwWE4rY1RQNlZBMFJwYkdTd0F5eThkdGlsS1RidHhianZh?=
 =?utf-8?B?S2hRSTc2UVAxMGppYjNhVG9NK29YK3RmdXpBN251aDFNVUpXRloySFdLdUk4?=
 =?utf-8?B?aVNMNE0zOTY4RkhPTkJYd0NsVllQckROYzFwcjF4dDcvN0gvK0xBRm5FTDMw?=
 =?utf-8?Q?CSRokSz4AbjtZebZsLc4x1RdN?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a4d30235-2e8c-4944-d053-08dc89f469df
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5624.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 08:56:42.2952
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6/EU5b655p7GjCgNjErNH4ojri5jq0ExzjhGNYBZhgyRAWlCZaPCtmrazHjgI7php3eW4nP8SsTHKDGGrFAl6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB5827

In binder_alloc, there is a frequent need for order3 memory allocation,
especially on small-memory mobile devices, which can lead to OOM and
cause foreground applications to be killed, resulting in flashbacks.

We use kvcalloc to allocate memory, which can reduce system OOM
occurrences, as well as decrease the time and probability of failure for
order3 memory allocations. Additionally, it can also improve the
throughput of binder (as verified by Google's binder_benchmark testing
tool).

We have conducted multiple tests on an 8GB memory phone, and the
performance of kvcalloc is better. Below is a partial excerpt of the
test data.

throughput = (size * Iterations)/Time
Benchmark-kvcalloc	Time	CPU	Iterations	throughput(Gb/s)
----------------------------------------------------------------
BM_sendVec_binder-4096	30926 ns	20481 ns	34457	4563.66↑
BM_sendVec_binder-8192	42667 ns	30837 ns	22631	4345.11↑
BM_sendVec_binder-16384	67586 ns	52381 ns	13318	3228.51↑
BM_sendVec_binder-32768	116496 ns	94893 ns	7416	2085.97↑
BM_sendVec_binder-65536	265482 ns	209214 ns	3530	871.40↑

Benchmark-kvcalloc	Time	CPU	Iterations	throughput(Gb/s)
----------------------------------------------------------------
BM_sendVec_binder-4096	39070 ns	24207 ns	31063	3256.56
BM_sendVec_binder-8192	49476 ns	35099 ns	18817	3115.62
BM_sendVec_binder-16384	76866 ns	58924 ns	11883	2532.86
BM_sendVec_binder-32768	134022 ns	102788 ns	6535	1597.78
BM_sendVec_binder-65536	281004 ns	220028 ns	3135	731.14

Signed-off-by: Lei Liu <liulei.rjpt@vivo.com>
---
 drivers/android/binder_alloc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c
index 2e1f261ec5c8..5dcab4a5e341 100644
--- a/drivers/android/binder_alloc.c
+++ b/drivers/android/binder_alloc.c
@@ -836,7 +836,7 @@ int binder_alloc_mmap_handler(struct binder_alloc *alloc,
 
 	alloc->buffer = vma->vm_start;
 
-	alloc->pages = kcalloc(alloc->buffer_size / PAGE_SIZE,
+	alloc->pages = kvcalloc(alloc->buffer_size / PAGE_SIZE,
 			       sizeof(alloc->pages[0]),
 			       GFP_KERNEL);
 	if (alloc->pages == NULL) {
@@ -869,7 +869,7 @@ int binder_alloc_mmap_handler(struct binder_alloc *alloc,
 	return 0;
 
 err_alloc_buf_struct_failed:
-	kfree(alloc->pages);
+	kvfree(alloc->pages);
 	alloc->pages = NULL;
 err_alloc_pages_failed:
 	alloc->buffer = 0;
@@ -939,7 +939,7 @@ void binder_alloc_deferred_release(struct binder_alloc *alloc)
 			__free_page(alloc->pages[i].page_ptr);
 			page_count++;
 		}
-		kfree(alloc->pages);
+		kvfree(alloc->pages);
 	}
 	spin_unlock(&alloc->lock);
 	if (alloc->mm)
-- 
2.34.1