Received-SPF: pass (google.com: domain of linux-kernel+bounces-209537-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <5f329f81cdfed31771f014d4d3cc35f4d13ffb0e.camel@gmail.com>
Subject: Re: [PATCH 4/4] hwmon: (pmbus/max31827) Explain why enum chips must
 not start with 0
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>, linux-hwmon@vger.kernel.org
Cc: Rob Herring <robh@kernel.org>, linux-kernel@vger.kernel.org, Peter Yin
 <peteryin.openbmc@gmail.com>, Potin Lai <potin.lai.pt@gmail.com>, Daniel
 Matyas <daniel.matyas@analog.com>, Andrew Davis <afd@ti.com>, Krzysztof
 Kozlowski <krzysztof.kozlowski@linaro.org>
Date: Tue, 11 Jun 2024 11:07:10 +0200
In-Reply-To: <20240610181046.1991436-5-linux@roeck-us.net>
References: <20240610181046.1991436-1-linux@roeck-us.net>
	 <20240610181046.1991436-5-linux@roeck-us.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.2 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-06-10 at 11:10 -0700, Guenter Roeck wrote:
> If a driver calls device_get_match_data(), the .data pointer in its id
> data structures must not be NULL/0 because device_get_match_data()
> returns NULL if an entry is not found. Explain that in a comment to avoid
> confusion why this is required in this driver but not in other drivers.
>=20
> Cc: Daniel Matyas <daniel.matyas@analog.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---

Acked-by: Nuno Sa <nuno.sa@analog.com>

> =C2=A0drivers/hwmon/max31827.c | 5 +++++
> =C2=A01 file changed, 5 insertions(+)
>=20
> diff --git a/drivers/hwmon/max31827.c b/drivers/hwmon/max31827.c
> index f8a13b30f100..391cb059e94d 100644
> --- a/drivers/hwmon/max31827.c
> +++ b/drivers/hwmon/max31827.c
> @@ -46,6 +46,11 @@
> =C2=A0#define MAX31827_M_DGR_TO_16_BIT(x)	(((x) << 4) / 1000)
> =C2=A0#define MAX31827_DEVICE_ENABLE(x)	((x) ? 0xA : 0x0)
> =C2=A0
> +/*
> + * The enum passed in the .data pointer of struct of_device_id must
> + * start with a value !=3D 0 since that is a requirement for using
> + * device_get_match_data().
> + */
> =C2=A0enum chips { max31827 =3D 1, max31828, max31829 };
> =C2=A0
> =C2=A0enum max31827_cnv {