Received-SPF: pass (google.com: domain of linux-kernel+bounces-209547-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 11 Jun 2024 14:40:49 +0530
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Ionela Voinescu <ionela.voinescu@arm.com>
Cc: Riwen Lu <luriwen@hotmail.com>, beata.michalska@arm.com,
	rafael@kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, hotran@apm.com,
	Riwen Lu <luriwen@kylinos.cn>
Subject: Re: [PATCH v3] cpufreq/cppc: Remove the desired_perf compare when
 set target
Message-ID: <20240611091049.lrypvvluntf37uff@vireshk-i7>
References: <20240530061621.36byo5a2iqc6o2az@vireshk-i7>
 <OS3P286MB249076187B3497D1EDD70988B1F32@OS3P286MB2490.JPNP286.PROD.OUTLOOK.COM>
 <20240606090737.z3qenphikjs5ijj4@vireshk-i7>
 <ZmgQ06jtJBPh5wat@arm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZmgQ06jtJBPh5wat@arm.com>

On 11-06-24, 09:54, Ionela Voinescu wrote:
> It's alright with me.

Great.

> Some "nits":
>  - the "desired_perf" local variable could be removed in this case.

Riwen, please fix this and resend.

>  - [note] while this change helps, we'd still need policy->cur to always
>    have the latest request value (see details at [1]) for this check to
>    be made obsolete by the comparison between target_freq and policy->cur,
>    as mentioned in the commit message. But this is/can be a separate
>    matter.
> 
>    [1] https://lore.kernel.org/lkml/ZmB1qKucR5fXk100@arm.com/

Yeah, lets discuss that in the other thread only.

-- 
viresh