Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp219951lqp; Tue, 11 Jun 2024 02:22:46 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWZVYKN6j8DA1ZUB7e72C22zNVS7T45w6EmwqtMaM1yYpqzMKnnWKwYkopWFucFcRkcKx9WUpwl+2VwPcdHpgKENLacChfYeSCM3/aRIg== X-Google-Smtp-Source: AGHT+IEqGqDUTKlpodPwr7OdRJihkVbOJfFKw9e2e7ebIkcLTsWmEVOgXrYsrZeVGf97mn4um999 X-Received: by 2002:a0d:e24e:0:b0:61b:3488:4e94 with SMTP id 00721157ae682-62cd5577b81mr117003727b3.4.1718097765491; Tue, 11 Jun 2024 02:22:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718097765; cv=pass; d=google.com; s=arc-20160816; b=A2YlW8bRzdxlV6nwgYt2w9mNxaPq5HDeYqrHxb/yxFUaQvg4f378RulsM7fmnGZIjg M2j4DHwkxFuK2kwbyIBH6ra8ydZbo/emldE/bm74W4diMELXWLEhrBS6ytt72iUJP9vy gSO7pbziiN8D9yI4Ok3j9Wgwc7NkCJhiOHqn5z8Vr0+XAq3XodGwXY+N+tfEJohEiaBK kqsKn6h0BPJSWauqel6cCto7FMpKPSMewOSnS8DEraUt+J+RIAxYwy9+K4XMsBxXHsPd yKXGm9zR7Lswkabl8lqiW9Ln4PD8TyLlXs/9Oyj0aijkaW578iyq0dquY548YVBuAifV Rs2Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :content-language:subject:references:cc:to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=SSWdIHLeK6c5qkRxJRQIzSFopdFgLqZQ5bZ8370mvc4=; fh=3fcKvMn4PckVAuXwQziWGUflhiURk6vM6gYvIrY4wUw=; b=wFsOAbNJPe+dGz98M5Iz9zdyctj9FxdrCg/lc9TVbZJfMk+yYVF+M5g9lZbwhi4dbp rrvTwacwj09fqoa6T/MCuUK0ggh0nnGqLRMQa7BSvrPx3fta05ovd0KVSsUVruk1Q9+/ 2DS8VDd7PzGuh3SHDLk2yjL+pWeYZgTGY75Y0HbgGOWdKIJiT3+IehYHF1hlS7eYRQ+7 7kiZtRsa3KjoA/shWDvjaPa3537bRsQK0e5D6YAb9c8jIRFuLTIR6IxlIh9PZVZA7Lp8 aeepMS7oXEVmIzhiPeqj4pkSytQunVqwAOAc7Ttkm+untpsdKZToNSYkz2ZQrQYItGZ6 EliA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=FftRtfIl; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-209560-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-209560-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 6a1803df08f44-6b04f967cbesi114654516d6.276.2024.06.11.02.22.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 02:22:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-209560-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=FftRtfIl; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-209560-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-209560-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 223921C21FE6 for ; Tue, 11 Jun 2024 09:22:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6555B17BB1B; Tue, 11 Jun 2024 09:20:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="FftRtfIl" Received: from mout.web.de (mout.web.de [212.227.15.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6057176FA7; Tue, 11 Jun 2024 09:20:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718097639; cv=none; b=i3l2uVij7Ng5VHAaCRmlKwDovVRCdlhLTmbX4aTD7rT4ydfMIbAd99rOB+2vo0uOZhPAtT8uOktCoPDCuUItB4u0ZRkoZfYNWi9fY1275rahcdH91H/bb8vPO4jyZJWbpK/b99zvhrajWz4p2PpZ3xADo6mLwZPDdMldgWbe9RQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718097639; c=relaxed/simple; bh=eO/SU6/Ukvz9yz53+xanZdbexobUG1/nTCp0LPHQuOw=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=O5Q4nkm2zIhQDslcjU1TkFdq/+qeduTMSBILKrYn4P6H5fXWj7eMNipF5/lPaAF+LBosLZclbhUQZSUlge66JB+9cMaQxIAd3B19Xb6/RLvA0h9jyRFrTTuNwkO3YhzIg/vvmSuz0Q5XdNz3cpHuwoQ5/RNMon1ZBVPWxuBZhfk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=FftRtfIl; arc=none smtp.client-ip=212.227.15.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1718097309; x=1718702109; i=markus.elfring@web.de; bh=SSWdIHLeK6c5qkRxJRQIzSFopdFgLqZQ5bZ8370mvc4=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=FftRtfIlHxGUAI3vCcm4yTpn/7z8WsjG+Em5dB5ND9N5eedR+QTMfkd+w7F2Zs2i WI1Yj0slkHGiDMKMlDkpOiP/MjEK/B6R2dAiV03zMK6+t4kT7xBeCDDQ888uoe/W3 HMJ+HG6g52cDLWKEcQbr6xXdD9cRTtNwHwz+bFZPPzkQ7TcZrvW0MggwyEXpoOwch F1SP/+OJXN2UQv0MqjXDYRgbkFIKPiQyMGI39/lLF6bCcLm4PLaCKaVl0+whiFMsB SB0PgbV6ShDjyXNFTfm7jH/gkRm4xnMBSXmDKl3ZdmJohCKk1XemhGUQoO6np/E5N r5idNtThZcYbX7sxNg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.83.95]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MSqTK-1rq7cJ2zhW-00J0sU; Tue, 11 Jun 2024 11:15:09 +0200 Message-ID: <0e1ac9ca-c241-4b48-a219-d1aaef2a752a@web.de> Date: Tue, 11 Jun 2024 11:15:06 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Ye Bin , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, Jens Axboe Cc: LKML , Christoph Hellwig , Ming Lei References: <20240606062655.2185006-1-yebin@huaweicloud.com> Subject: Re: [PATCH] block: bio-integrity: fix potential null-ptr-deref in bio_integrity_free Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240606062655.2185006-1-yebin@huaweicloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:GHmc89SQ4Td/zPwUg//USd5islR+tdgleigB+jmBeZEuq6FZ7Dy fkE7CjeiMfQNvzY0YK08nYlilwmnduxqbtLEXlZPIHy8TtJwqsAsxfDMtv1kVgp7vN7HY3T IALqM09md0BMzdXXkahjw/wqc3/g/o4um3hx2fvO5m4g3LdePf+xlz9QuKO0YSskYbKSlDW ouYkrcSzcG4LaTCOdkrZg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:w3g6y7385Ok=;4OLDESrn0lp0xrLZI+q1mYjtpDC 9L4XwYlMGBU/2knpMHxRGtTguQQPeZkUn9hbbhdJEbPFwKVuasnXIFwsFPPZMJWGF9Gyi5AdU p2/eh5PYU7JjePGFXBpZuGx5XzQAULZfIJqL3J5wx0xVh8v4k18N+f/UiMmgqVRhUdafKaK5A Vjuvpu5YRwyP4ZaoiHmzSaLZxFMm8rAaGBoCp24NpeW8eOYXiBufOe+roIN7J+3U0i1RO20M5 ibiygZB/TDIGdrs9L4FzHsK0UZvGL93mO/3aLCDIdHIZtml9pvBSI9vMWtqOaQ1lZwN9GWrnn XVz0VFlULaG85q/vFA2450eAeTuFWrQ+f0wPCIZ54LPwyy/bGCMqhtVdjGFY+/LHyZeMD3R6a dqQytdUotZXhiS5/f3pfvC3DcWQZFmjSAJed9btt0ovvy25dK/EJiQMLyGp7ZS/w4i7TfZ5Sf RpsDfzZ65tCEBD+iWOM2HkNTcH91z5c7FAQeclUgQeN/Fen8vAr2eZ5OMj7hPPJHya9BbL6rQ JoiO5Gu3MYgjmhHYVNqdPaLjh1TLMVOvgth8ETDFRpS4sBh2VWPFhatcBaZYvOdP8eXxM8sjK ftgSY1q05gPDkmgL3kVTG+xpDRT5wG/zQgS/gOcuzl5Bq6iGmjmXjyXVuqsQ2iYEhAOmZpXue gCx8qIA+QByymh0Zwrxr4B+hHfguxyA3d1JmrVMKmS9XzrIsEbSBj0Uer8v/MBbU9k7tNblRI FX09N3GphcrQdp2SBs4/aZi6w0LFVeRdWqpYu9CJhwdHpyxPlLEDJ9wjmNcyq9xiRm199crh4 h2dGqmiwCRC1yvvmWZpUy52+P348tLJ7LBdy0p3mQiSDo= =E2=80=A6 > The root cause of this issue is the concurrency between the write proces= s > and the block size update process. However, this concurrency does not ex= ist > in actual production environments. To solve above issue, Verify if the > segments of BIO are aligned with integrity intervals. * Please improve the change description with an imperative wording. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/= Documentation/process/submitting-patches.rst?h=3Dv6.10-rc2#n94 * Would you like to add the tag =E2=80=9CFixes=E2=80=9D accordingly? * How do you think about to use the summary phrase =E2=80=9CAvoid null poi= nter dereference in bio_integrity_free()=E2=80=9D? Regards, Markus