Received-SPF: pass (google.com: domain of linux-kernel+bounces-209540-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <a9d1a7771d78fdb0c5a165775645befe440af4ef.camel@gmail.com>
Subject: Re: [PATCH v2 2/4] Input: adxl34x - use input_set_capability()
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
 linux-input@vger.kernel.org,  Nuno Sa <nuno.sa@analog.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>, 
	linux-kernel@vger.kernel.org
Date: Tue, 11 Jun 2024 11:09:49 +0200
In-Reply-To: <20240610164301.1048482-2-dmitry.torokhov@gmail.com>
References: <20240610164301.1048482-1-dmitry.torokhov@gmail.com>
	 <20240610164301.1048482-2-dmitry.torokhov@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.2 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-06-10 at 09:42 -0700, Dmitry Torokhov wrote:
> Switch to using input_set_capability() instead of using __set_bit() to
> make clear what exactly kinds of events (EV_KEY, EV_REL) are being
> declared.
>=20
> Also drop redundant calls setting EV_ABS and ABS_X|Y|Z bits as that is
> taken care by input_set_abs_params().
>=20
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

>=20
> v2: new patch, split out from devm conversion at Nino's request
>=20
> =C2=A0drivers/input/misc/adxl34x.c | 32 +++++++++++++-------------------
> =C2=A01 file changed, 13 insertions(+), 19 deletions(-)
>=20
> diff --git a/drivers/input/misc/adxl34x.c b/drivers/input/misc/adxl34x.c
> index fbe5a56c19d1..830acf29c32b 100644
> --- a/drivers/input/misc/adxl34x.c
> +++ b/drivers/input/misc/adxl34x.c
> @@ -769,18 +769,12 @@ struct adxl34x *adxl34x_probe(struct device *dev, i=
nt
> irq,
> =C2=A0
> =C2=A0	input_set_drvdata(input_dev, ac);
> =C2=A0
> -	__set_bit(ac->pdata.ev_type, input_dev->evbit);
> -
> =C2=A0	if (ac->pdata.ev_type =3D=3D EV_REL) {
> -		__set_bit(REL_X, input_dev->relbit);
> -		__set_bit(REL_Y, input_dev->relbit);
> -		__set_bit(REL_Z, input_dev->relbit);
> +		input_set_capability(input_dev, EV_REL, REL_X);
> +		input_set_capability(input_dev, EV_REL, REL_Y);
> +		input_set_capability(input_dev, EV_REL, REL_Z);
> =C2=A0	} else {
> =C2=A0		/* EV_ABS */
> -		__set_bit(ABS_X, input_dev->absbit);
> -		__set_bit(ABS_Y, input_dev->absbit);
> -		__set_bit(ABS_Z, input_dev->absbit);
> -
> =C2=A0		if (pdata->data_range & FULL_RES)
> =C2=A0			range =3D ADXL_FULLRES_MAX_VAL;	/* Signed 13-bit */
> =C2=A0		else
> @@ -791,18 +785,18 @@ struct adxl34x *adxl34x_probe(struct device *dev, i=
nt
> irq,
> =C2=A0		input_set_abs_params(input_dev, ABS_Z, -range, range, 3, 3);
> =C2=A0	}
> =C2=A0
> -	__set_bit(EV_KEY, input_dev->evbit);
> -	__set_bit(pdata->ev_code_tap[ADXL_X_AXIS], input_dev->keybit);
> -	__set_bit(pdata->ev_code_tap[ADXL_Y_AXIS], input_dev->keybit);
> -	__set_bit(pdata->ev_code_tap[ADXL_Z_AXIS], input_dev->keybit);
> +	input_set_capability(input_dev, EV_KEY, pdata-
> >ev_code_tap[ADXL_X_AXIS]);
> +	input_set_capability(input_dev, EV_KEY, pdata-
> >ev_code_tap[ADXL_Y_AXIS]);
> +	input_set_capability(input_dev, EV_KEY, pdata-
> >ev_code_tap[ADXL_Z_AXIS]);
> =C2=A0
> =C2=A0	if (pdata->ev_code_ff) {
> =C2=A0		ac->int_mask =3D FREE_FALL;
> -		__set_bit(pdata->ev_code_ff, input_dev->keybit);
> +		input_set_capability(input_dev, EV_KEY, pdata->ev_code_ff);
> =C2=A0	}
> =C2=A0
> =C2=A0	if (pdata->ev_code_act_inactivity)
> -		__set_bit(pdata->ev_code_act_inactivity, input_dev->keybit);
> +		input_set_capability(input_dev, EV_KEY,
> +				=C2=A0=C2=A0=C2=A0=C2=A0 pdata->ev_code_act_inactivity);
> =C2=A0
> =C2=A0	ac->int_mask |=3D ACTIVITY | INACTIVITY;
> =C2=A0
> @@ -874,13 +868,13 @@ struct adxl34x *adxl34x_probe(struct device *dev, i=
nt
> irq,
> =C2=A0
> =C2=A0		if (pdata->orientation_enable & ADXL_EN_ORIENTATION_3D)
> =C2=A0			for (i =3D 0; i < ARRAY_SIZE(pdata-
> >ev_codes_orient_3d); i++)
> -				__set_bit(pdata->ev_codes_orient_3d[i],
> -					=C2=A0 input_dev->keybit);
> +				input_set_capability(input_dev, EV_KEY,
> +						=C2=A0=C2=A0=C2=A0=C2=A0 pdata-
> >ev_codes_orient_3d[i]);
> =C2=A0
> =C2=A0		if (pdata->orientation_enable & ADXL_EN_ORIENTATION_2D)
> =C2=A0			for (i =3D 0; i < ARRAY_SIZE(pdata-
> >ev_codes_orient_2d); i++)
> -				__set_bit(pdata->ev_codes_orient_2d[i],
> -					=C2=A0 input_dev->keybit);
> +				input_set_capability(input_dev, EV_KEY,
> +						=C2=A0=C2=A0=C2=A0=C2=A0 pdata-
> >ev_codes_orient_2d[i]);
> =C2=A0	} else {
> =C2=A0		ac->pdata.orientation_enable =3D 0;
> =C2=A0	}