Received-SPF: pass (google.com: domain of linux-kernel+bounces-209600-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 11 Jun 2024 17:53:52 +0800
From: Xu Yilun <yilun.xu@linux.intel.com>
To: Marco Pagani <marpagan@redhat.com>
Cc: Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
	Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
	linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 RESEND] Revert "fpga: disable KUnit test suites when
 module support is enabled"
Message-ID: <ZmgesCLjje6Q0yXh@yilunxu-OptiPlex-7050>
References: <20240604102536.59010-1-marpagan@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240604102536.59010-1-marpagan@redhat.com>

On Tue, Jun 04, 2024 at 12:25:35PM +0200, Marco Pagani wrote:
> This reverts commit a3fad2e92c76587fe262a1a4a122045b29885354.
> 
> The core components of the subsystem no longer assume that low-level
> modules register a driver for the parent device and rely on its owner
> pointer to take the module's refcount. KUnit test suites can now be safely
> re-enabled with loadable module support.
> 
> Signed-off-by: Marco Pagani <marpagan@redhat.com>

Acked-by: Xu Yilun <yilun.xu@intel.com>

Applied to for-next.

> ---
> 
> v2: reworked commit message
> ---
>  drivers/fpga/tests/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/fpga/tests/Kconfig b/drivers/fpga/tests/Kconfig
> index d4e55204c092..e4a64815f16d 100644
> --- a/drivers/fpga/tests/Kconfig
> +++ b/drivers/fpga/tests/Kconfig
> @@ -1,6 +1,6 @@
>  config FPGA_KUNIT_TESTS
> -	bool "KUnit test for the FPGA subsystem" if !KUNIT_ALL_TESTS
> -	depends on FPGA=y && FPGA_REGION=y && FPGA_BRIDGE=y && KUNIT=y && MODULES=n
> +	tristate "KUnit test for the FPGA subsystem" if !KUNIT_ALL_TESTS
> +	depends on FPGA && FPGA_REGION && FPGA_BRIDGE && KUNIT=y
>  	default KUNIT_ALL_TESTS
>          help
>            This builds unit tests for the FPGA subsystem
> 
> base-commit: b7c0e1ecee403a43abc89eb3e75672b01ff2ece9
> -- 
> 2.45.1
> 
>