Received-SPF: pass (google.com: domain of linux-kernel+bounces-209462-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 11 Jun 2024 08:21:06 +0000
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sylvain Petinot <sylvain.petinot@foss.st.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] media: vgxy61: Add MODULE_ALIAS()
Message-ID: <ZmgI8nET4sdhdwQx@kekkonen.localdomain>
References: <20240610150815.228790-1-benjamin.mugnier@foss.st.com>
 <20240610150815.228790-4-benjamin.mugnier@foss.st.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240610150815.228790-4-benjamin.mugnier@foss.st.com>

Hi Benjamin,

On Mon, Jun 10, 2024 at 05:08:15PM +0200, Benjamin Mugnier wrote:
> Preserve user space retro compatibility after the device rename.
> 
> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> ---
>  drivers/media/i2c/vgxy61.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/i2c/vgxy61.c b/drivers/media/i2c/vgxy61.c
> index ca3b43608dad..c85f356946ca 100644
> --- a/drivers/media/i2c/vgxy61.c
> +++ b/drivers/media/i2c/vgxy61.c
> @@ -1898,3 +1898,4 @@ MODULE_AUTHOR("Mickael Guene <mickael.guene@st.com>");
>  MODULE_AUTHOR("Sylvain Petinot <sylvain.petinot@foss.st.com>");
>  MODULE_DESCRIPTION("VGXY61 camera subdev driver");
>  MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:st-vgxy61");

Perhaps just "st-vgxy61" so that the module still loads if someone loads it
explicitly? That's what you'd want, right, as the old compatible string
will remain?

-- 
Kind regards,

Sakari Ailus