Received-SPF: pass (google.com: domain of linux-kernel+bounces-209664-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 11 Jun 2024 11:39:12 +0100
From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jai Luthra <j-luthra@ti.com>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>, Liam Girdwood <lgirdwood@gmail.com>,
	Peter Ujfalusi <peter.ujfalusi@gmail.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	alsa-devel@alsa-project.org, Devarsh Thakkar <devarsht@ti.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Jayesh Choudhary <j-choudhary@ti.com>
Subject: Re: [PATCH v2 1/2] ALSA: dmaengine: Synchronize dma channel in
 prepare()
Message-ID: <ZmgpUFy5-_5n_zyd@finisterre.sirena.org.uk>
References: <20240610-asoc_next-v2-0-b52aaf5d67c4@ti.com>
 <20240610-asoc_next-v2-1-b52aaf5d67c4@ti.com>
 <3557bd0f-86b4-4dce-90dd-59303f4f1154@metafoo.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="0TfXp5NDpMNDG3Z7"
Content-Disposition: inline
In-Reply-To: <3557bd0f-86b4-4dce-90dd-59303f4f1154@metafoo.de>


--0TfXp5NDpMNDG3Z7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jun 10, 2024 at 05:45:52PM -0700, Lars-Peter Clausen wrote:
> On 6/10/24 03:56, Jai Luthra wrote:

> > Sometimes the stream may be stopped due to XRUN events, in which case
> > the userspace can call snd_pcm_drop() and snd_pcm_prepare() to stop and
> > start the stream again.

> > In these cases, we must wait for the DMA channel to synchronize before
> > marking the stream as prepared for playback, as the DMA channel gets
> > stopped by snd_pcm_drop() without any synchronization.

> We should really implement the sync_stop() PCM callback and let the ALSA
> core let care of the sync.

Good point, that's a better idea.

--0TfXp5NDpMNDG3Z7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZoKU8ACgkQJNaLcl1U
h9BedQf+LgwsDPZ2r9hVlvRNDyt6JZgIXzyPghbWNXb2jndRsTN0kXDZlyMRdPtN
iljCdWcV193flVjp3ZMX7IsVtIEDiMtwNuspJjIU2nXEqEgQE4FcfSkLv5Q8uIcQ
jSp1zqxvo8AFrEKQrySdNdc5iysKN265nBFq3Q7KfAVvpndZL1ZYnCbJ738EoNhx
3RgYTlvAuOIoux34F/bXbrYPsEfQseB6Z9JvxvwtKoVDcDUcTUkQv2mwlN6zzqwO
Vk8fk1bIjPmf304blTqV3T53LPtTTOQvRIFu1xeFI61zpMRRq79wIHSSBUtiaxcs
Ijdg6xeeM0a9FfxfcH5bm3UKiRhKdA==
=pWL3
-----END PGP SIGNATURE-----

--0TfXp5NDpMNDG3Z7--