Received-SPF: pass (google.com: domain of linux-kernel+bounces-209684-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 11 Jun 2024 11:54:59 +0100
From: Mark Brown <broonie@kernel.org>
To: Dev Jain <dev.jain@arm.com>
Cc: shuah@kernel.org, oleg@redhat.com, stsp2@yandex.ru, mingo@kernel.org,
	tglx@linutronix.de, mark.rutland@arm.com, ryan.roberts@arm.com,
	suzuki.poulose@arm.com, Anshuman.Khandual@arm.com,
	DeepakKumar.Mishra@arm.com, AneeshKumar.KizhakeVeetil@arm.com,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] selftests: Rename sigaltstack to generic signal
Message-ID: <ZmgtA_GW_GPgPM1E@finisterre.sirena.org.uk>
References: <20240611075650.814397-1-dev.jain@arm.com>
 <20240611075650.814397-2-dev.jain@arm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="M7ZRx99x+Njm+IQK"
Content-Disposition: inline
In-Reply-To: <20240611075650.814397-2-dev.jain@arm.com>


--M7ZRx99x+Njm+IQK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 11, 2024 at 01:26:49PM +0530, Dev Jain wrote:
> Rename sigaltstack to signal, and rename the existing test to
> sigaltstack.c.
>=20
> Signed-off-by: Dev Jain <dev.jain@arm.com>
> ---

If people review patches and give a tag for them you should carry the
tag forward to avoid having to duplicate the review.  From v1:

I think this is reasonable if we're going to add more generic signal
tests - sigaltstack is a fairly small bit of functionality and having it
covered as part of a broader signal suite and the overhead of setting up
the suite separately is probably not worth it.

Reviewed-by: Mark Brown <broonie@kernel.org>

--M7ZRx99x+Njm+IQK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZoLQIACgkQJNaLcl1U
h9D3Kgf/WuphRjuFoS2YT244+k2nuqqetLVxqWOMOV/vt1NxuYL7bbhpz0EqhBqv
I6nqG70xVWuTHeR+4Q38vg2kT0r1ruQIxISVMTnb8P44j8Bs+5aZqUJwz87y8cdo
h/IZdHwz2wR6sSz2kT6U2hJUiL89dy46I6u4IwAdRLOgezildFig095w/hf0pc4E
Yh1+9hznungjj85Gbn7mO5W5op0j0IakA/Uzx+5c9IJ2a3rG4CcDBqZ9Oeyi828t
U/WX73qatb4E6X0kKqG2qOQf+FmSa74lkbJ/84yqIyoJCXWt+VnDrYFQzwPq8os9
6VvejhYY7PQAILNcUTRYFWZVwPgJUQ==
=ydvO
-----END PGP SIGNATURE-----

--M7ZRx99x+Njm+IQK--