Received-SPF: pass (google.com: domain of linux-kernel+bounces-209683-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <ZmVfcEOxmjUHZTSX@hovoldconsulting.com> <CAJZ5v0gVnjVyd_O6KgXy2sXr3b3M3vyTLyUCasyxP0GrAXro4Q@mail.gmail.com>
In-Reply-To: <CAJZ5v0gVnjVyd_O6KgXy2sXr3b3M3vyTLyUCasyxP0GrAXro4Q@mail.gmail.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Tue, 11 Jun 2024 12:54:25 +0200
Message-ID: <CAJZ5v0iz7gwhpvT53CH0ZEA_q3U=dnn6XR8HdLk6LpP3ye4Zkg@mail.gmail.com>
Subject: Re: cpufreq/thermal regression in 6.10
To: Johan Hovold <johan@kernel.org>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Viresh Kumar <viresh.kumar@linaro.org>, Zhang Rui <rui.zhang@intel.com>, 
	Lukasz Luba <lukasz.luba@arm.com>, Steev Klimaszewski <steev@kali.org>, linux-pm@vger.kernel.org, 
	linux-kernel@vger.kernel.org, regressions@lists.linux.dev
Content-Type: multipart/mixed; boundary="00000000000091410b061a9b1798"

--00000000000091410b061a9b1798
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 10, 2024 at 1:17=E2=80=AFPM Rafael J. Wysocki <rafael@kernel.or=
g> wrote:
>
> Hi,
>
> Thanks for the report.
>
> On Sun, Jun 9, 2024 at 9:53=E2=80=AFAM Johan Hovold <johan@kernel.org> wr=
ote:
> >
> > Hi,
> >
> > Steev reported to me off-list that the CPU frequency of the big cores o=
n
> > the Lenovo ThinkPad X13s sometimes appears to get stuck at a low
> > frequency with 6.10-rc2.
> >
> > I just confirmed that once the cores are fully throttled (using the
> > stepwise thermal governor) due to the skin temperature reaching the
> > first trip point, scaling_max_freq gets stuck at the next OPP:
> >
> >         cpu4/cpufreq/scaling_max_freq:940800
> >         cpu5/cpufreq/scaling_max_freq:940800
> >         cpu6/cpufreq/scaling_max_freq:940800
> >         cpu7/cpufreq/scaling_max_freq:940800
> >
> > when the temperature drops again.
>
> So apparently something fails to update its frequency QoS request.
>
> Would it be possible to provoke this with thermal debug enabled
> (CONFIG_THERMAL_DEBUGFS set) and see what's there in
> /sys/kernel/debug/thermal/?
>
> > This obviously leads to a massive performance drop and could possibly
> > also be related to reports like this one:
> >
> >         https://lore.kernel.org/all/CAHk-=3DwjwFGQZcDinK=3DBkEaA8FSyVg5=
NaUe0BobxowxeZ5PvetA@mail.gmail.com/
> >
> > I assume the regression may have been introduced by all the thermal wor=
k
> > that went into 6.10-rc1, but I don't have time to try to track this dow=
n
> > myself right now (and will be away from keyboard most of next week).
> >
> > I've confirmed that 6.9 works as expected.
>
> Well, I'd need to ask someone else affected by this, then.

If this is the step-wise governor, the problem might have been
introduced by commit

042a3d80f118 thermal: core: Move passive polling management to the core

which removed passive polling count updates from that governor, so if
the thermal zone in question has passive polling only and no regular
polling, temperature updates may stop coming before the governor drops
the cooling device states to the "no target" level.

So please test the attached partial revert of the above commit when you can=
.

--00000000000091410b061a9b1798
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="thermal-gov_step_wise--revert-passive.patch"
Content-Disposition: attachment; 
	filename="thermal-gov_step_wise--revert-passive.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lxaa98980>
X-Attachment-Id: f_lxaa98980

LS0tCiBkcml2ZXJzL3RoZXJtYWwvZ292X3N0ZXBfd2lzZS5jIHwgICAxMCArKysrKysrKysrCiAx
IGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKQoKSW5kZXg6IGxpbnV4LXBtL2RyaXZlcnMv
dGhlcm1hbC9nb3Zfc3RlcF93aXNlLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbGludXgtcG0ub3JpZy9kcml2
ZXJzL3RoZXJtYWwvZ292X3N0ZXBfd2lzZS5jCisrKyBsaW51eC1wbS9kcml2ZXJzL3RoZXJtYWwv
Z292X3N0ZXBfd2lzZS5jCkBAIC05Myw2ICs5MywxNiBAQCBzdGF0aWMgdm9pZCB0aGVybWFsX3pv
bmVfdHJpcF91cGRhdGUoc3RyCiAJCWlmIChpbnN0YW5jZS0+aW5pdGlhbGl6ZWQgJiYgb2xkX3Rh
cmdldCA9PSBpbnN0YW5jZS0+dGFyZ2V0KQogCQkJY29udGludWU7CiAKKwkJaWYgKHRyaXAtPnR5
cGUgPT0gVEhFUk1BTF9UUklQX1BBU1NJVkUpIHsKKwkJCS8qIElmIG5lZWRlZCwgdXBkYXRlIHRo
ZSBzdGF0dXMgb2YgcGFzc2l2ZSBwb2xsaW5nLiAqLworCQkJaWYgKG9sZF90YXJnZXQgPT0gVEhF
Uk1BTF9OT19UQVJHRVQgJiYKKwkJCSAgICBpbnN0YW5jZS0+dGFyZ2V0ICE9IFRIRVJNQUxfTk9f
VEFSR0VUKQorCQkJCXR6LT5wYXNzaXZlKys7CisJCQllbHNlIGlmIChvbGRfdGFyZ2V0ICE9IFRI
RVJNQUxfTk9fVEFSR0VUICYmCisJCQkJIGluc3RhbmNlLT50YXJnZXQgPT0gVEhFUk1BTF9OT19U
QVJHRVQpCisJCQkJdHotPnBhc3NpdmUtLTsKKwkJfQorCiAJCWluc3RhbmNlLT5pbml0aWFsaXpl
ZCA9IHRydWU7CiAKIAkJbXV0ZXhfbG9jaygmaW5zdGFuY2UtPmNkZXYtPmxvY2spOwo=
--00000000000091410b061a9b1798--