Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp265908lqp; Tue, 11 Jun 2024 04:06:14 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU6xPPI+hAaY1hB6tSdMoy+3lCEba83rpvB807FVSoOEIDsS/sxTOJRxUTXyMLMExVHxWqcCQtCU/dYxv9g/dgTXZf8OTJwnS/e3RpaFw== X-Google-Smtp-Source: AGHT+IG0zfAFXgNftNWVkplIpYCXEhfMSKA22OGQrsWa00IQR0dGNloorkWqgSCHi7RDOjEPt5/f X-Received: by 2002:a05:6358:54a2:b0:19f:4967:4e8f with SMTP id e5c5f4694b2df-19f49675529mr951968655d.22.1718103974033; Tue, 11 Jun 2024 04:06:14 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718103973; cv=pass; d=google.com; s=arc-20160816; b=XqidD7W4hc02F6PeuEW1hi5DvkAIy9+cQKmeKe4Wc3/7XUZmMnZk61ZoDNo5mf+W/p Xu589Y7t+HTA3Bu6ITXv2oYN8MbuH613mKPoiS0fdMv+JBjMGO6/FdRRgCrTqO+oRzcv C0OROHrgHX0insJfopvLM7nGvz7SF4MpGyNWF820gaTV6V/SSvcQs5IGXnLS8tVFOrMX B1h2cbsf/d7V30eO1+q2LJ/IOZ4dR43MP4/WU+QF7NScYzM8cmIxkwqwInB94MnODFEW DyO6f7FejMd/HFqi/WYtMq5s/DM32iZOsbFPS36iqjZzMJZdUAnX/92B7zsdLKDJEQdt ZqZA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=69DDbIOUEaKauOUdmIvkH0n9o6MTqowJZDIBEqtYRjk=; fh=o41xsCbKewbim33HXbAX84GpS1Ir88OZuCPwpOA7oGA=; b=Rn8+RLULQRTA5jff+jKi+dCQhDzXpW6bxSog/b9ZNZfZTtmkR6nrZ+RiXzRUmC3L0h oRazPEuY2jlYiXw0wYsJGkBMmicJhk35VHaxabU7bDh+Ur9SaS/bG/CEGHrk/MdZ3tG1 NdCO0ssKVBzvklJtkADo5vunrzeWXsQ7no9p/LE8LlKe6onW8XwNiHdAZVI+KlA9fe9x 5DGC+j8Au3j1ybK5z9oFsPx8YH/skBKYMZqV+2I1rIZ03xvX5vkkV8c6B3OYK9Bc2dSA tJWqJemLDiY+okpQG/6nEhzqkZ33xUbyiX5XHK8Vo6wLLQjnCLOwHSr+6mDPqLyOJjnL pg4w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=IrdXh91+; arc=pass (i=1 spf=pass spfdomain=alien8.de dkim=pass dkdomain=alien8.de dmarc=pass fromdomain=alien8.de); spf=pass (google.com: domain of linux-kernel+bounces-209682-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-209682-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-6e6a6de6e03si6270143a12.93.2024.06.11.04.06.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 04:06:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-209682-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=IrdXh91+; arc=pass (i=1 spf=pass spfdomain=alien8.de dkim=pass dkdomain=alien8.de dmarc=pass fromdomain=alien8.de); spf=pass (google.com: domain of linux-kernel+bounces-209682-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-209682-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id BA639B258FA for ; Tue, 11 Jun 2024 10:53:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1018917967A; Tue, 11 Jun 2024 10:53:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b="IrdXh91+" Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC24854750; Tue, 11 Jun 2024 10:52:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=65.109.113.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718103181; cv=none; b=s4eA5EDLyS5dq08TBz+FB5D5x1RGmUTfwj31jrdDJ3DOMJNO5YPGI522jZyzBCa/RP2QOTm4BGUU/vv98IB2QRdYb1PgaCgyYORg+4UxJ3HuXxgfO5bpEraSwx2H2fUbPHsokhxbxlYOqHWUccWhxaF40+ytEwBPoyM9HIqtSdo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718103181; c=relaxed/simple; bh=O6yNQpzWFfgaAyg+bB1AWIYfafWraDPTiYeM6mLHIxE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ac9IIBHLS/2vPk57LWp8zIv/SHz7xIwU7vLhhPsT1OyQoftbeU1ErhlRL7bnAlEsftUCrbTsgsvvEbYMp2BZvG5RdwEXZFtQF1j1H2m2mSv9qKlEjvSmXfFDbNN3PsHLQuxTaRmIW2AOD1uba6MaOUAo6yafql3sAGctqlAf9Yc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de; spf=pass smtp.mailfrom=alien8.de; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b=IrdXh91+; arc=none smtp.client-ip=65.109.113.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id B94FC40E016A; Tue, 11 Jun 2024 10:52:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id zovfewP79hYC; Tue, 11 Jun 2024 10:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1718103165; bh=69DDbIOUEaKauOUdmIvkH0n9o6MTqowJZDIBEqtYRjk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IrdXh91+jkSK4fhTYch24LBKWGhy8KcHgXwD5Idj4eGY3qo8lcNxZCmVGrkVvqb+W n3kgtn+0Le4fpSxtdfnApvEIdm7JWG2HJcEyQwmDzkMNc0OSAq71yts/PeqUwsoBA7 DlN/HVNHHIO5yCC3zvIpvTgBAkbXEWpcUPutOyeQhnBk+FocidZYj5/hQO1T3b0X+T Noys+XLq0ZE/vWhLbQZK6tmRuUa6dr0krya6OlQ3gT5agJexoDGULmq+tbgawPsO/J PR85bAkZmKR7stYniSsaDZunwXiZ6fy+WG9J8Uc0wMOAFtITLwplkW6QxXTZ2gqqx8 lNmwaVXzDY3l/jPCpYvofHCOkiItyslwrUNv2091Pk6mvMG+vsnlZO7hQmw5Hhlhxx kNFlHVVtS0obEPQ2ziWrggDdmSug1sc/y5JbnJnjUh14hmY6SrJuF62LfT3vYjch6+ WIwWMhqL/rE16dN7rACVXpDRh6uyWBcyhj3C/p6Hq2EgrLE/VrEPrdmt7bMX5uo8C3 m/MXSIxyu+uDYMPJhEBasyyxoS+OaRNkIYoMfdk8+MvV3keFyBsA0QePIry+PChqyw BpISeOBj1HUc0kCbYVNXK6ZBa3Qp9UhShj3QnqMZVUiR+k/pATuB2L6EwroIZ97cXT irzKizVtcRwgdhUi+QWRcXsE= Received: from zn.tnic (p5de8ee85.dip0.t-ipconnect.de [93.232.238.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 14D0640E0081; Tue, 11 Jun 2024 10:52:33 +0000 (UTC) Date: Tue, 11 Jun 2024 12:52:27 +0200 From: Borislav Petkov To: Perry Yuan Cc: Mario.Limonciello@amd.com, gautham.shenoy@amd.com, rafael.j.wysocki@intel.com, viresh.kumar@linaro.org, Ray.Huang@amd.com, Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 08/10] x86/cpufeatures: Add feature bits for AMD heterogeneous processor Message-ID: <20240611105216.GAZmgsYC-J_yLfdupF@fat_crate.local> References: <7a2817ce6e8e6a2787bed8285dba8d81423d8414.1718095377.git.perry.yuan@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7a2817ce6e8e6a2787bed8285dba8d81423d8414.1718095377.git.perry.yuan@amd.com> On Tue, Jun 11, 2024 at 04:52:24PM +0800, Perry Yuan wrote: > Subject: Re: [PATCH v3 08/10] x86/cpufeatures: Add feature bits for AMD heterogeneous processor "... Add a heterogeneous core topology feature bit" not "feature bits" > CPUID leaf 0x80000026 advertises core types with different efficiency rankings > > Bit 30 indicates the heterogeneous core topology feature, if the bit > set, it means not all instances at the current hierarchical level have > the same core topology. > > For better utilization of feature words and help to identify core type, > X86_FEATURE_HETERO_CORE_TOPOLOGY is added as a few scattered feature bits. This sentence is not needed. > PDF p274 > > Link: https://www.amd.com/content/dam/amd/en/documents/processor-tech-docs/programmer-references/24593.pdf This link will become obsolete, you can say instead Search the web for "architecture programmer's manual volume 2 system programming docID #25493" in order to find the official document. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette