Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp267776lqp; Tue, 11 Jun 2024 04:09:27 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUIdgG6zSfrnLlwXRsREqf6S5THspV/bLbRbzXpfhHJ8O3B7fZOrZLbXMtg3MnKDLGlUvFvm4hpcnUiQ8/W7Y6YjKyUyqBGzLKTUYWZLA== X-Google-Smtp-Source: AGHT+IEy66Edz+8sD0chmyLoSMt33VD+O7sFbgBks+qDvdkwoR+dNGJgW4V6nSMOMCaOQyHFyyMh X-Received: by 2002:a05:6a20:12c1:b0:1b4:b4af:6045 with SMTP id adf61e73a8af0-1b4b4af621fmr11820903637.18.1718104167329; Tue, 11 Jun 2024 04:09:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718104167; cv=pass; d=google.com; s=arc-20160816; b=Whe2B2mjMaHK5cOWWPUxtR1B8OUro7EcpSx202HCraDjx/kN2s5Hf6zvrAlNfiuIwx l0yb1+C9siDXVA4bKQSVkei7nFbKM8X7sc4dRl+pKLJ99SqDbwuweGZlvw0GQHrxH54i TNp6O5UmX7CjBsgQyb4eW5J1HEHMk1Z6631wxHUQuJRncNUijXVHGJt8ULlTKvIHfDGt xorZO7TjmfanyV25sKlqQsByQTzjHMo+NAx9b1otfwMJsbMKPlaRZ9qtq2zQ3yIbbd9o 8PqOIihBSrM00h7S8q4+Ed7nbnhHH9pOTDcHdhLg1pR7PuoAD7tahmTHLPGIfrRdbXob L9sA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=fzwbb4rgS+TOgZOXbyzeVCgDtutYzL0zX8ev4fFjZcg=; fh=iHaQkYzS81KCOWN8LnWcBHHVfeuhkn/WSf9z5D8KGSg=; b=I5zI22/20FlIe5BILPzKMls14KI52jc94eKC4CocNgPYNmXgmFZ9GyItZwlUniwCkT bPuQR6dDUbdAHZRWc+o8FI4Dhr0EVPP4tkKnh0G8cff6aXYFuwUGJzdlv5NXRzqSkkLm 2qZKoYHIyBJS//ZNwXXBJDR2QMHYXTpUApgbsdwZSNC4sQOXALkcOHp3OvL+spwcaEfp OCizW8kYvtkVXrk8hbRR84iUGEI8de0LNNN417ZEvAZoKdMVCr7dsmLFxR5rvYMn/U42 FJEScrBOhkIZCK0DNB4MkYFVRvFKXEHOVSkGSPlJ8fiAnMj/QsmxBtGia31vA6ErwhFY 32KQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Yy2GDgHO; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-209300-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-209300-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d2e1a72fcca58-7041e618a42si6522936b3a.94.2024.06.11.04.09.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 04:09:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-209300-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Yy2GDgHO; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-209300-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-209300-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id E8DD0B23AC2 for ; Tue, 11 Jun 2024 06:06:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 97DB617164C; Tue, 11 Jun 2024 06:05:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Yy2GDgHO" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52BF517108D; Tue, 11 Jun 2024 06:05:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718085946; cv=none; b=jpzp6DL/MFKpOGLS84If8dv1ZD7Y2YJKNt3oW2SHu5Yw7Z8BYUBK27HnHBxRtXISIHfQXbvfFNi1TePaPeTVV2YMq2YblmuGlv3vt9SvadPiK4A+bHuhG0ovaMXyDPrKZeU81BmlrS9Aec53exrzp3k7k+iMi2CSeSIDpna5uTU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718085946; c=relaxed/simple; bh=fzwbb4rgS+TOgZOXbyzeVCgDtutYzL0zX8ev4fFjZcg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cvSKbTJI2oP4CB8s8AVoPXV1S905DiEaGzRXRQpUnPBp46KOzaYbq+lz6F0l6VBY3SEDHZXwESOipZeH94XZfwMwT4Ykj+vFcGEtwzB4i1dLmUTVDB3dLJ25lEc0Ql56ZX0AqYb1tFVURmMCWRyl4spa5BBjSh58VX4OZ4PZIv0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Yy2GDgHO; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fzwbb4rgS+TOgZOXbyzeVCgDtutYzL0zX8ev4fFjZcg=; b=Yy2GDgHOIm16MpZUBcVWFHHUCi ZnJalcsiVNQRViDl/VUgf2H8F6gYHlXuWr98JfS3Nv8HRtMQLv4kOp8z1jlVIIaidH4ZIgTWUP00O CxQEM2arFch1mMt0wFgO9GpJHXkjHTt80hNYB+UKglzMpcxmIdBIbd/FkYgFzuoc1q5PxSWfsnMlo KQhUlm25HDUP3WNbK1MDWsuXfnkkXxt46kghOdWqnHyTkH/ldriAguKkNjCZc9zKZ5QpOaHD/cRi3 aMBAafgaGfhXm040fnEiw3qTKuFgGL83MzLXYTAv1kqDsQ3zMdfHmueWPw9xDs/64Zcfus9vczKdm lGwYsZPA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGudb-00000007cwV-23gN; Tue, 11 Jun 2024 06:05:43 +0000 Date: Mon, 10 Jun 2024 23:05:43 -0700 From: Christoph Hellwig To: Mateusz Guzik Cc: Christoph Hellwig , brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, josef@toxicpanda.com Subject: Re: [PATCH v2 1/2] vfs: add rcu-based find_inode variants for iget ops Message-ID: References: <20240610195828.474370-1-mjguzik@gmail.com> <20240610195828.474370-2-mjguzik@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Tue, Jun 11, 2024 at 07:36:46AM +0200, Mateusz Guzik wrote: > I am explaining why the addition looks the way it does: I am keeping > it consistent with the surroundings, which I assumed is the preferred > way. It is not, and it's clearly documented that it isn't.