Received-SPF: pass (google.com: domain of linux-kernel+bounces-209708-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 11 Jun 2024 13:11:28 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Jacky Huang <ychuang570808@gmail.com>
Cc: dan.carpenter@linaro.org, jirislaby@kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org, Jacky Huang <ychuang3@nuvoton.com>
Subject: Re: [PATCH] tty: serial: ma35d1: Add a NULL check for of_node
Message-ID: <2024061118-sycamore-leggings-05a9@gregkh>
References: <20240611092251.159149-1-ychuang570808@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240611092251.159149-1-ychuang570808@gmail.com>

On Tue, Jun 11, 2024 at 09:22:51AM +0000, Jacky Huang wrote:
> From: Jacky Huang <ychuang3@nuvoton.com>
> 
> The pdev->dev.of_node can be NULL if the "serial" node is absent.
> Add a NULL check to return an error in such cases.
> 
> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
> ---
>  drivers/tty/serial/ma35d1_serial.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/tty/serial/ma35d1_serial.c b/drivers/tty/serial/ma35d1_serial.c
> index 19f0a305cc43..3b4206e815fe 100644
> --- a/drivers/tty/serial/ma35d1_serial.c
> +++ b/drivers/tty/serial/ma35d1_serial.c
> @@ -688,12 +688,13 @@ static int ma35d1serial_probe(struct platform_device *pdev)
>  	struct uart_ma35d1_port *up;
>  	int ret = 0;
>  
> -	if (pdev->dev.of_node) {
> -		ret = of_alias_get_id(pdev->dev.of_node, "serial");
> -		if (ret < 0) {
> -			dev_err(&pdev->dev, "failed to get alias/pdev id, errno %d\n", ret);
> -			return ret;
> -		}
> +	if (!pdev->dev.of_node)
> +		return -ENODEV;
> +
> +	ret = of_alias_get_id(pdev->dev.of_node, "serial");
> +	if (ret < 0) {
> +		dev_err(&pdev->dev, "failed to get alias/pdev id, errno %d\n", ret);
> +		return ret;
>  	}
>  	up = &ma35d1serial_ports[ret];
>  	up->port.line = ret;

What commit id does this fix?

thanks,

greg k-h