Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763315AbYBFXEx (ORCPT ); Wed, 6 Feb 2008 18:04:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763115AbYBFXEV (ORCPT ); Wed, 6 Feb 2008 18:04:21 -0500 Received: from nf-out-0910.google.com ([64.233.182.190]:61690 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763086AbYBFXES convert rfc822-to-8bit (ORCPT ); Wed, 6 Feb 2008 18:04:18 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Fcqp5L1PG005mmeWHwN6EaI78aV+ehcAo4YcqaM8czlGUJ0FAx76F+7FVTWeMcDehU871sIxXJYXUkExmkZIgNs3oGn4syZ4z/EDhrymL7GfwA3lzV0UhKjaXl4FoAtsc0mCvGvxREUOkID5k3X9Rl6JjXOl5IKjHHZSE7Zrcto= Message-ID: <6101e8c40802061504r5f2a64f7gd8c0f8f12c7707ce@mail.gmail.com> Date: Thu, 7 Feb 2008 00:04:17 +0100 From: "Oliver Pinter" To: "Linux Kernel" , stable@kernel.org, stable-commits@vger.kernel.org Subject: Re: [2.6.22.y] {13/17} - nfs-fix-nfs-reval-fsid - series for stable kernel #2 In-Reply-To: <6101e8c40802011734q5f98edc6lb0b3d2ebcbb533bd@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Content-Disposition: inline References: <6101e8c40802011734q5f98edc6lb0b3d2ebcbb533bd@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2615 Lines: 91 Patch-mainline: 2.6.24 References: 271803 GIT: a0356862bcbeb20acf64bc1a82d28a4c5bb957a7 Mon Sep 17 00:00:00 2001 From: Trond Myklebust Date: Tue, 5 Jun 2007 13:26:15 -0400 Subject: [PATCH] NFS: Fix nfs_reval_fsid() We don't need to revalidate the fsid on the root directory. It suffices to revalidate it on the current directory. Signed-off-by: Trond Myklebust Acked-by: NeilBrown --- fs/nfs/dir.c | 9 ++++----- fs/nfs/inode.c | 4 ++-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 4948ec1..c02a796 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c @@ -897,14 +897,13 @@ int nfs_is_exclusive_create(struct inode *dir, struct nameidata *nd) return (nd->intent.open.flags & O_EXCL) != 0; } -static inline int nfs_reval_fsid(struct vfsmount *mnt, struct inode *dir, - struct nfs_fh *fh, struct nfs_fattr *fattr) +static inline int nfs_reval_fsid(struct inode *dir, const struct nfs_fattr *fattr) { struct nfs_server *server = NFS_SERVER(dir); if (!nfs_fsid_equal(&server->fsid, &fattr->fsid)) - /* Revalidate fsid on root dir */ - return __nfs_revalidate_inode(server, mnt->mnt_root->d_inode); + /* Revalidate fsid using the parent directory */ + return __nfs_revalidate_inode(server, dir); return 0; } @@ -946,7 +945,7 @@ static struct dentry *nfs_lookup(struct inode *dir, struct dentry * dentry, stru res = ERR_PTR(error); goto out_unlock; } - error = nfs_reval_fsid(nd->mnt, dir, &fhandle, &fattr); + error = nfs_reval_fsid(dir, &fattr); if (error < 0) { res = ERR_PTR(error); goto out_unlock; diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c index 23ecf03..7bcb3df 100644 --- a/fs/nfs/inode.c +++ b/fs/nfs/inode.c @@ -961,8 +961,8 @@ static int nfs_update_inode(struct inode *inode, struct nfs_fattr *fattr) goto out_changed; server = NFS_SERVER(inode); - /* Update the fsid if and only if this is the root directory */ - if (inode == inode->i_sb->s_root->d_inode + /* Update the fsid? */ + if (S_ISDIR(inode->i_mode) && !nfs_fsid_equal(&server->fsid, &fattr->fsid)) server->fsid = fattr->fsid; -- 1.5.3.6 On 2/2/08, Oliver Pinter (Pint?r Oliv?r) wrote: > mainline: a0356862bcbeb20acf64bc1a82d28a4c5bb957a7 > > > -- > Thanks, > Oliver > -- Thanks, Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/