Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757931AbYBFXGT (ORCPT ); Wed, 6 Feb 2008 18:06:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763444AbYBFXFP (ORCPT ); Wed, 6 Feb 2008 18:05:15 -0500 Received: from ug-out-1314.google.com ([66.249.92.172]:39856 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762729AbYBFXFF convert rfc822-to-8bit (ORCPT ); Wed, 6 Feb 2008 18:05:05 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=urgHHm/527d6BTkELhphpMeUFLaB/6J7Dzy5Oo5wthCA7jUrBwYp+XVPN33tA5NkhJ67C7uF3HZfIxhgiXSdFiQMrXXEBXsFQmeqgVf3vfmCUdBcuwwfd89P87pqmk3oKOXEfBQ12B+dsTedpz9TksjcY/zTIltY55oxC5DblbQ= Message-ID: <6101e8c40802061505g101d2cafq477b57f110cbae66@mail.gmail.com> Date: Thu, 7 Feb 2008 00:05:03 +0100 From: "Oliver Pinter" To: "Linux Kernel" , stable@kernel.org, stable-commits@vger.kernel.org Subject: Re: [2.6.22.y] {12/17} - nfsacl-retval.diff - series for stable kernel #2 In-Reply-To: <6101e8c40802011734l63bdb871r29006ad5af408234@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Content-Disposition: inline References: <6101e8c40802011734l63bdb871r29006ad5af408234@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2124 Lines: 63 From: J. Bruce Fields Date: Fri, 2 Nov 2007 15:36:08 -0400 Subject: [PATCH] knfsd: fix spurious EINVAL errors on first access of new filesystem References: 340873 The v2/v3 acl code in nfsd is translating any return from fh_verify() to nfserr_inval. This is particularly unfortunate in the case of an nfserr_dropit return, which is an internal error meant to indicate to callers that this request has been deferred and should just be dropped pending the results of an upcall to mountd. Thanks to Roland for bug report and data collection. Cc: Roland Acked-by: Andreas Gruenbacher Signed-off-by: J. Bruce Fields Index: linux-2.6.23/fs/nfsd/nfs2acl.c =================================================================== --- linux-2.6.23.orig/fs/nfsd/nfs2acl.c +++ linux-2.6.23/fs/nfsd/nfs2acl.c @@ -41,7 +41,7 @@ static __be32 nfsacld_proc_getacl(struct fh = fh_copy(&resp->fh, &argp->fh); if ((nfserr = fh_verify(rqstp, &resp->fh, 0, MAY_NOP))) - RETURN_STATUS(nfserr_inval); + RETURN_STATUS(nfserr); if (argp->mask & ~(NFS_ACL|NFS_ACLCNT|NFS_DFACL|NFS_DFACLCNT)) RETURN_STATUS(nfserr_inval); Index: linux-2.6.23/fs/nfsd/nfs3acl.c =================================================================== --- linux-2.6.23.orig/fs/nfsd/nfs3acl.c +++ linux-2.6.23/fs/nfsd/nfs3acl.c @@ -37,7 +37,7 @@ static __be32 nfsd3_proc_getacl(struct s fh = fh_copy(&resp->fh, &argp->fh); if ((nfserr = fh_verify(rqstp, &resp->fh, 0, MAY_NOP))) - RETURN_STATUS(nfserr_inval); + RETURN_STATUS(nfserr); if (argp->mask & ~(NFS_ACL|NFS_ACLCNT|NFS_DFACL|NFS_DFACLCNT)) RETURN_STATUS(nfserr_inval); On 2/2/08, Oliver Pinter (Pint?r Oliv?r) wrote: > mainline: ac8587dcb58e40dd336d99d60f852041e06cc3dd > > -- > Thanks, > Oliver > -- Thanks, Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/