Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp284985lqp; Tue, 11 Jun 2024 04:46:11 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUCVeZAiwQTOut1vWZREgZOhXg01hrYzMOktlCwyI3MTfTSzdz1Q2fdt+ez+M7soNHEbdCqFTT8xaDbOdIVEXCEgcay02lcPIcibOMQGQ== X-Google-Smtp-Source: AGHT+IF+vkD9CiGol3M3e7W06ZssB5IhzzZD+0TDDwMqsRFFg5c744gRx54AluAdEj4B9IP7+jw4 X-Received: by 2002:a17:906:1394:b0:a6f:218e:6f9 with SMTP id a640c23a62f3a-a6f218e0735mr278678166b.41.1718106371097; Tue, 11 Jun 2024 04:46:11 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718106371; cv=pass; d=google.com; s=arc-20160816; b=e5CSIAAOgw6b5nMsKMQxTL/b7gJ6+J4Ytu7/MK+Z4S+bjEP4lfuF/EKuKWU06Erpf8 pkZLnmfYqfRafJQ7puFEgyYMwVroygiTPAZVyZ3v5p8H6i++rXwVGZbAmsyVLgHQmfGM 5jmT8UjHiAvK2jS14cNGgFc2C/8TxZVLsrIZ01QEjer8PWX+90R7HFs64x62bJMFt2zD N7BnIOyErbiC4HQiFksuoQ5OByRsvmP/ewV9SAhjdV3Oy/VoS/lzhEGZjmal2pleWXDt PqTgMbOjC+JODNCXbDLIo/iitfXt+zvdusfvBeANKTWJEfD7IMTJBrgatUBqITT9Jiei TbVA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=jtpZX04+vZvd4H4jtVh8ouP336azkbSPBqTKoMccYMg=; fh=Lh+JMPZo65h8qJAnE5jHWvKtvWM25xS7kSTjy8t+qRE=; b=rVMFsW+NoF7SRO+SObOQpf9x0S09XEw33e2uRyMks7hSJkaSrgDi54Un43oYXqOKxm SZwUcVXe69N+Pwz5K5GJOKhWowI1SdskKMYywM/jEZrcIUndAlQ7aR7thlkSSnkoCwc8 BRFDt/cv0bvaYGV1aQxVu4FNbWwljfDEbNWA2JroabMTyc4U1qSHH3exKJKhSW+wAsE6 H8YqaG6176zR8WPnaaR485CXb+VoiVrT1DvRHHBVzR2ql9q3BhwkwcskAuXF4fQVU3q3 p7rDyKqmkaJol5SiWcWYxiBCaZgXCOM+A9F1Zbxb7NjMmAXno1omqVeR3NBYF/eo6geK PqaQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-209791-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-209791-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a6f1cd345d9si225588466b.554.2024.06.11.04.46.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 04:46:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-209791-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-209791-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-209791-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 851121F25314 for ; Tue, 11 Jun 2024 11:46:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D9E8817F38E; Tue, 11 Jun 2024 11:41:56 +0000 (UTC) Received: from mxout70.expurgate.net (mxout70.expurgate.net [91.198.224.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D427617F369; Tue, 11 Jun 2024 11:41:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.198.224.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718106116; cv=none; b=E+/mW2nrwk1pNwsvfVSIoWWpWEGEVQr/o3DEsLPziL9bKkUX9wJboJg2xws3i7n1AXBy+gIM7WNFI1oHm37R/pnuF0Z7McA2EU76ktjL3w9FgmSzHicghjzm6Ctitr4nMbBC6mT666bFrxfh3oPZu3RWwjl9a2NDDvtUzwcb3T8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718106116; c=relaxed/simple; bh=I3jDDLhhE9CvNnNbIVh6mYYXoYpZ6qnnBn0WuqEZwZc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sh4wqNCS+vQL4sT4lCJZnKm6xSxmj+kHlwAQPCZeIgb38FlFCiVw/dzGnXJopEYmXl9Vq51Fv5yH74BmbDlFvjATnd9BPmOH0zMGA6IapMgiiRvcolQo1N4hda2Cn3y9Nr4zQMvgMUBDEmm892dB/sSXedLklWqA4DJpdRKa+Ow= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; arc=none smtp.client-ip=91.198.224.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1sGzsu-002Z0t-Vj; Tue, 11 Jun 2024 13:41:53 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sGzsu-001L8n-DI; Tue, 11 Jun 2024 13:41:52 +0200 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id 1C8F6240053; Tue, 11 Jun 2024 13:41:52 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id A2F3F240050; Tue, 11 Jun 2024 13:41:51 +0200 (CEST) Received: from mschiller1.dev.tdt.de (unknown [10.2.3.20]) by mail.dev.tdt.de (Postfix) with ESMTPSA id 0DC6629768; Tue, 11 Jun 2024 13:41:51 +0200 (CEST) From: Martin Schiller To: martin.blumenstingl@googlemail.com, hauke@hauke-m.de, andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ms@dev.tdt.de Subject: [PATCH net-next v4 12/13] net: dsa: lantiq_gswip: Update comments in gswip_port_vlan_filtering() Date: Tue, 11 Jun 2024 13:40:26 +0200 Message-ID: <20240611114027.3136405-13-ms@dev.tdt.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240611114027.3136405-1-ms@dev.tdt.de> References: <20240611114027.3136405-1-ms@dev.tdt.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-purgate-type: clean X-purgate-ID: 151534::1718106112-14A01D11-26A7E30E/0/0 X-purgate: clean From: Martin Blumenstingl Update the comments in gswip_port_vlan_filtering() so it's clear that there are two separate cases, one for "tag based VLAN" and another one for "port based VLAN". Suggested-by: Martin Schiller Signed-off-by: Martin Blumenstingl Acked-by: Hauke Mehrtens --- drivers/net/dsa/lantiq_gswip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswi= p.c index 2bbc7dd45418..ec52c62eadce 100644 --- a/drivers/net/dsa/lantiq_gswip.c +++ b/drivers/net/dsa/lantiq_gswip.c @@ -780,7 +780,7 @@ static int gswip_port_vlan_filtering(struct dsa_switc= h *ds, int port, } =20 if (vlan_filtering) { - /* Use port based VLAN tag */ + /* Use tag based VLAN */ gswip_switch_mask(priv, GSWIP_PCE_VCTRL_VSR, GSWIP_PCE_VCTRL_UVR | GSWIP_PCE_VCTRL_VIMR | @@ -789,7 +789,7 @@ static int gswip_port_vlan_filtering(struct dsa_switc= h *ds, int port, gswip_switch_mask(priv, GSWIP_PCE_PCTRL_0_TVM, 0, GSWIP_PCE_PCTRL_0p(port)); } else { - /* Use port based VLAN tag */ + /* Use port based VLAN */ gswip_switch_mask(priv, GSWIP_PCE_VCTRL_UVR | GSWIP_PCE_VCTRL_VIMR | GSWIP_PCE_VCTRL_VEMR, --=20 2.39.2