Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp285462lqp; Tue, 11 Jun 2024 04:47:18 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUsVVs8pVsgT290Pbsh9hi+q4DHAKcINE2DJCLT5REr94sGeEn5C848kfPiO7QfXEg4u6bcfq2ogdTuorAbC+HgYX6ZGjwG7FcBXu4rgw== X-Google-Smtp-Source: AGHT+IEscfmX8PF/OCvh+RrEGbCnXXSpX875OOR4lWz8G5XndH87cY6dn3pSKmTyS5iD1vUC5UfU X-Received: by 2002:a17:902:988b:b0:1f4:b18a:3f25 with SMTP id d9443c01a7336-1f6d0398abcmr124968465ad.60.1718106437933; Tue, 11 Jun 2024 04:47:17 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718106437; cv=pass; d=google.com; s=arc-20160816; b=qVcQFS661szb8Nby/IGfTAtbIKIX4xvlfi8Y638tD0qagYbFCeiNYgRU+sQzun+YPm HMoZ4WRhEEHGjJvlHmJCnjRYbGhmnsNpNQ/5k1Ue/+p/2PD3ieiyX4Qm2yBB/7iKDKGB c3gG5ooHmVXHeYkgeNTtPvMAuYRe2WUrEpEmMAC5HbRhHjFhqBV5z3H0peykXdWmKj4H h5a29FDwmei25d3Cum3+8gKqV1/hURvbkDXw+iJKPrNQecF1ajFptavAwrjrvVHBoAOJ CVCmou1So/yu63S8h7/G59gj4Ry9wRJKXGCfYchfx3Q4dk4NO3bpOCWSs0QdoDfKS2xW Z5HQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=RKIY9odMZceFUe7am0QXtJvqBYP1H4DpKWwAuSHERxw=; fh=Lh+JMPZo65h8qJAnE5jHWvKtvWM25xS7kSTjy8t+qRE=; b=qhzDGjB3zwR0qQ9tnvdco2dyyrJcayGPq0y8WC/cpVnjrONo/V9yBaQHAF54no06Gt DGYldzcaCERr4K2tVjbJV9uVDKzRgbMi8iyJe15s7JWunGyCO4sF93eBPUPVMgGZFJNA gmMjb4TpSweTXPgPq2MvhnK+QcJtFPIJqM+wW+WfcT6jMifg/cscI/VSXYWPDfzCLmNl Wx0jHXyAO1pKseQZdke7mDuxAv7K3eNv1vbjSNy2YDN6ygSOMM+HpW3g4aUaC8acS72q qvng3DK8oc4pXaLCtO55DZ1zfVDKN0N3yjZSA3uNKSP05JvezIRXhRZjeNXrc6mdcfyi MrKQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-209792-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-209792-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d9443c01a7336-1f72ffdbb7csi11477075ad.42.2024.06.11.04.47.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 04:47:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-209792-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-209792-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-209792-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 74BC62826B5 for ; Tue, 11 Jun 2024 11:47:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B6E4A17FACC; Tue, 11 Jun 2024 11:42:01 +0000 (UTC) Received: from mxout70.expurgate.net (mxout70.expurgate.net [91.198.224.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE79517F50A; Tue, 11 Jun 2024 11:41:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.198.224.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718106121; cv=none; b=KXMzsVi4x49vAhDiHZdTNXeNFJSdXyYU37OASlBYV9JedItHnuw4UnsJJLvSpLlC0wtx0f/1pWNrH/Fm4cxQ593aAZR1TGOITbTlxdlB/s8RePr7N5E4DXUT4NXTF4KwmbWo/YN0VkVVNeTYv13E7QHi9OurLKueNJa9kH72LTg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718106121; c=relaxed/simple; bh=hZekxdzg6/DbdtqVNiroTrOJ0Q1iP2Vz3e229k+G84U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fb6BAIuLsqD+4A4JU0L+OVLVOojKhFY3Baxc3P3xyk/jMowu7E2qN1LfMQQ5XeYhToa2RCIRgPaJVe3e508sWWWLORoAslFqiOkGlIYu7G9OBNzBBNfb9ZJE3tFP/uGyACFnxrwiHV4inZAYFO408zsV+b+sJ3Qnc2zwA1Qj8iA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; arc=none smtp.client-ip=91.198.224.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1sGzsz-002Z1m-PD; Tue, 11 Jun 2024 13:41:57 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sGzsz-0003Ow-7s; Tue, 11 Jun 2024 13:41:57 +0200 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id F0D7A240053; Tue, 11 Jun 2024 13:41:56 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 84486240050; Tue, 11 Jun 2024 13:41:56 +0200 (CEST) Received: from mschiller1.dev.tdt.de (unknown [10.2.3.20]) by mail.dev.tdt.de (Postfix) with ESMTPSA id 5158829768; Tue, 11 Jun 2024 13:41:56 +0200 (CEST) From: Martin Schiller To: martin.blumenstingl@googlemail.com, hauke@hauke-m.de, andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ms@dev.tdt.de Subject: [PATCH net-next v4 13/13] net: dsa: lantiq_gswip: Improve error message in gswip_port_fdb() Date: Tue, 11 Jun 2024 13:40:27 +0200 Message-ID: <20240611114027.3136405-14-ms@dev.tdt.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240611114027.3136405-1-ms@dev.tdt.de> References: <20240611114027.3136405-1-ms@dev.tdt.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-purgate-ID: 151534::1718106117-34A72D11-D8C64E16/0/0 X-purgate-type: clean X-purgate: clean From: Martin Blumenstingl Print that no FID is found for bridge %s instead of the incorrect message that the port is not part of a bridge. Signed-off-by: Martin Blumenstingl Acked-by: Hauke Mehrtens --- drivers/net/dsa/lantiq_gswip.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswi= p.c index ec52c62eadce..fcd4505f4925 100644 --- a/drivers/net/dsa/lantiq_gswip.c +++ b/drivers/net/dsa/lantiq_gswip.c @@ -1370,7 +1370,8 @@ static int gswip_port_fdb(struct dsa_switch *ds, in= t port, } =20 if (fid =3D=3D -1) { - dev_err(priv->dev, "Port not part of a bridge\n"); + dev_err(priv->dev, "no FID found for bridge %s\n", + bridge->name); return -EINVAL; } =20 --=20 2.39.2