Received-SPF: pass (google.com: domain of linux-kernel+bounces-209779-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 11 Jun 2024 13:40:37 +0200
From: Mateusz Guzik <mjguzik@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: brauner@kernel.org, viro@zeniv.linux.org.uk, 
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, 
	josef@toxicpanda.com, hch@infradead.org
Subject: Re: [PATCH v3 1/2] vfs: add rcu-based find_inode variants for iget
 ops
Message-ID: <2aoxtcshqzrrqfvjs2xger5omq2fjkfifhkdjzvscrtybisca7@eoisrrcki2vw>
References: <20240611101633.507101-1-mjguzik@gmail.com>
 <20240611101633.507101-2-mjguzik@gmail.com>
 <20240611105011.ofuqtmtdjddskbrt@quack3>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240611105011.ofuqtmtdjddskbrt@quack3>

On Tue, Jun 11, 2024 at 12:50:11PM +0200, Jan Kara wrote:
> On Tue 11-06-24 12:16:31, Mateusz Guzik wrote:
> > +/**
> > + * ilookup5 - search for an inode in the inode cache
>       ^^^ ilookup5_rcu
> 

fixed in my branch

> > + * @sb:		super block of file system to search
> > + * @hashval:	hash value (usually inode number) to search for
> > + * @test:	callback used for comparisons between inodes
> > + * @data:	opaque data pointer to pass to @test
> > + *
> > + * This is equivalent to ilookup5, except the @test callback must
> > + * tolerate the inode not being stable, including being mid-teardown.
> > + */
> ...
> > +struct inode *ilookup5_nowait_rcu(struct super_block *sb, unsigned long hashval,
> > +		int (*test)(struct inode *, void *), void *data);
> 
> I'd prefer wrapping the above so that it fits into 80 columns.
> 

the last comma is precisely at 80, but i can wrap it if you insist

> Otherwise feel free to add:
> 
> Reviewed-by: Jan Kara <jack@suse.cz>
> 

thanks

I'm going to wait for more feedback, tweak the commit message to stress
that this goes from 2 hash lock acquires to 1, maybe fix some typos and
submit a v4.

past that if people want something faster they are welcome to implement
or carry it over the finish line themselves.

> 									Honza
> -- 
> Jan Kara <jack@suse.com>
> SUSE Labs, CR