Received-SPF: pass (google.com: domain of linux-kernel+bounces-209817-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <4f52b7a1-e289-4a55-ac2c-b3b453a73f30@linux.ibm.com>
Date: Tue, 11 Jun 2024 13:53:07 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [v5 3/3] KVM: s390: don't setup dummy routing when
 KVM_CREATE_IRQCHIP
To: Sean Christopherson <seanjc@google.com>, Yi Wang <up2wing@gmail.com>
Cc: pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        wanpengli@tencent.com, foxywang@tencent.com, oliver.upton@linux.dev,
        maz@kernel.org, anup@brainfault.org, atishp@atishpatra.org,
        frankja@linux.ibm.com, imbrenda@linux.ibm.com, weijiang.yang@intel.com
References: <20240506101751.3145407-1-foxywang@tencent.com>
 <20240506101751.3145407-4-foxywang@tencent.com> <ZmcnlPcplno-toU4@google.com>
Content-Language: en-US
From: Christian Borntraeger <borntraeger@linux.ibm.com>
In-Reply-To: <ZmcnlPcplno-toU4@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


Am 10.06.24 um 18:19 schrieb Sean Christopherson:
> On Mon, May 06, 2024, Yi Wang wrote:
>> From: Yi Wang <foxywang@tencent.com>
>>
>> As we have setup empty irq routing in kvm_create_vm(), there's
>> no need to setup dummy routing when KVM_CREATE_IRQCHIP.
>>
>> Signed-off-by: Yi Wang <foxywang@tencent.com>
>> ---
>>   arch/s390/kvm/kvm-s390.c | 9 +--------
>>   1 file changed, 1 insertion(+), 8 deletions(-)
>>
>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
>> index 5147b943a864..ba7fd39bcbf4 100644
>> --- a/arch/s390/kvm/kvm-s390.c
>> +++ b/arch/s390/kvm/kvm-s390.c
>> @@ -2998,14 +2998,7 @@ int kvm_arch_vm_ioctl(struct file *filp, unsigned int ioctl, unsigned long arg)
>>   		break;
>>   	}
>>   	case KVM_CREATE_IRQCHIP: {
>> -		struct kvm_irq_routing_entry routing;
>> -
>> -		r = -EINVAL;
>> -		if (kvm->arch.use_irqchip) {
>> -			/* Set up dummy routing. */
>> -			memset(&routing, 0, sizeof(routing));
>> -			r = kvm_set_irq_routing(kvm, &routing, 0, 0);
>> -		}
>> +		r = 0;
> 
> This is wrong, KVM_CREATE_IRQCHIP should fail with -EINVAL if kvm->arch.use_irqchip
> is false.
> 
> There's also a functional change here, though I highly doubt it negatively affects
> userspace.  Nothing in s390 prevents invoking KVM_CREATE_IRQCHIP after
> KVM_SET_GSI_ROUTING, so userspace could very theoretically use KVM_CREATE_IRQCHIP
> to reset to empty IRQ routing.
> 
> Christian, if it works for you, I'll massage it to this when applying.

Oops. Yes please do so.