Received-SPF: pass (google.com: domain of linux-kernel+bounces-209839-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 11 Jun 2024 14:14:33 +0200
From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: Benson Leung <bleung@chromium.org>, 
	Guenter Roeck <groeck@chromium.org>, Sebastian Reichel <sre@kernel.org>, 
	"Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>, 
	Robert Moore <robert.moore@intel.com>, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, 
	linux-pm@vger.kernel.org, Mario Limonciello <mario.limonciello@amd.com>, 
	Dustin Howett <dustin@howett.net>, Stephen Horvath <s.horvath@outlook.com.au>, 
	Rajas Paranjpe <paranjperajas@gmail.com>, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, 
	Matt Hartley <matt.hartley@gmail.com>
Subject: Re: [PATCH v3 3/5] platform/chrome: cros_ec_proto: Introduce
 cros_ec_cmd_versions()
Message-ID: <96f0d632-7fdd-4fca-9528-449440d72f5d@t-8ch.de>
References: <20240610-cros_ec-charge-control-v3-0-135e37252094@weissschuh.net>
 <20240610-cros_ec-charge-control-v3-3-135e37252094@weissschuh.net>
 <Zmg2iwOWRZdCybxw@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <Zmg2iwOWRZdCybxw@google.com>

On 2024-06-11 11:35:39+0000, Tzung-Bi Shih wrote:
> On Mon, Jun 10, 2024 at 05:51:08PM +0200, Thomas Weißschuh wrote:
> > +/**
> > + * cros_ec_cmd_versions - Get supported version mask.
> 
> I guess we would like to call it something like "cros_ec_get_cmd_versions".

Ack.

> > + *
> > + * @ec_dev: EC device
> > + * @cmd: Command to test
> > + *
> > + * Return: version mask on success, negative error number on failure.
> > + */
> > +int cros_ec_cmd_versions(struct cros_ec_device *ec_dev, u16 cmd)
> 
> Could it support a "version" parameter as existing EC_CMD_GET_CMD_VERSIONS
> usages use both versions?  An `u16 cmd` parameter and down-cast to u8 for v0
> should be fine. (ec_params_get_cmd_versions vs. ec_params_get_cmd_versions_v1)

Ack.

Or we could automatically use v0 if cmd <= U8_MAX?