Received-SPF: pass (google.com: domain of linux-kernel+bounces-209869-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <d7d32ef3-8b2e-476c-a15e-7f829ea0d60a@collabora.com>
Date: Tue, 11 Jun 2024 14:38:09 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1] ASoC: support machine driver with TAS2781
To: Mark Brown <broonie@kernel.org>,
 Rui Zhou <zhourui@huaqin.corp-partner.google.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
 matthias.bgg@gmail.com, trevor.wu@mediatek.com, allen-kh.cheng@mediatek.com,
 kuninori.morimoto.gx@renesas.com, maso.huang@mediatek.com,
 linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
References: <20240611022227.2508354-1-zhourui@huaqin.corp-partner.google.com>
 <Zmgsfafmfedd9_MV@finisterre.sirena.org.uk>
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Content-Language: en-US
In-Reply-To: <Zmgsfafmfedd9_MV@finisterre.sirena.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Il 11/06/24 12:52, Mark Brown ha scritto:
> On Tue, Jun 11, 2024 at 10:22:27AM +0800, Rui Zhou wrote:
>> Support amp TAS2781 for mt8188 platform
>>
>> Signed-off-by: Rui Zhou <zhourui@huaqin.corp-partner.google.com>
>> ---
>>   sound/soc/mediatek/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig
>> index 5a8476e1ecca..07f67f96c889 100644
>> --- a/sound/soc/mediatek/Kconfig
>> +++ b/sound/soc/mediatek/Kconfig
>> @@ -233,6 +233,7 @@ config SND_SOC_MT8188_MT6359
>>   	select SND_SOC_HDMI_CODEC
>>   	select SND_SOC_DMIC
>>   	select SND_SOC_MAX98390
>> +	select SND_SOC_TAS2781_I2C
>>   	select SND_SOC_NAU8315
>>   	select SND_SOC_NAU8825
> 
> Ideally this would be sorted to avoid spurious merge conficts.  Also do
> we really have dependencies here or should these just be being enabled
> by users - these drivers are all pretty generic now?

The only dependency is on the MT6359 PMIC's audio related IPs and nothing else.

I'd even remove the other select statements for the other codecs, honestly,
as there's no reason why MT8188 wouldn't support a codec or the other, and
there is no reason why that SoC needs exactly those codecs, apart from some
board (Chromebooks) having one, or the other.

Instead of adding a select statement on MT8188_MT6359, adding the TAS2781_I2C
driver as a module in defconfig is a better idea..... at least, IMO.

>  Not that this
> change in itself makes a huge difference to the existing state.

I agree it doesn't make any huge difference, but I also don't see why users
can't simply enable (y/m) that in the kernel configuration :-)

Cheers,
Angelo