Received-SPF: pass (google.com: domain of linux-kernel+bounces-209886-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <d05230ee-caa0-4fb5-a076-f0b0fc448574@quicinc.com>
Date: Tue, 11 Jun 2024 18:27:01 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 2/2] misc: fastrpc: use coherent pool for untranslated
 Compute Banks
Content-Language: en-US
To: Dylan Van Assche <me@dylanvanassche.be>,
        Srinivas Kandagatla
	<srinivas.kandagatla@linaro.org>,
        Amol Maheshwari <amahesh@qti.qualcomm.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman
	<gregkh@linuxfoundation.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC: Caleb Connolly <caleb.connolly@linaro.org>, <phone-devel@vger.kernel.org>,
        <~postmarketos/upstreaming@lists.sr.ht>
References: <20240524161423.15392-1-me@dylanvanassche.be>
 <20240524161423.15392-3-me@dylanvanassche.be>
From: Ekansh Gupta <quic_ekangupt@quicinc.com>
In-Reply-To: <20240524161423.15392-3-me@dylanvanassche.be>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit


On 5/24/2024 9:44 PM, Dylan Van Assche wrote:
> Use fastrpc_remote_heap_alloc to allocate from the FastRPC device
> instead of the Compute Bank when the session ID is 0. This ensures
> that the allocation is inside the coherent DMA pool which is already
> accessible to the DSP. This is necessary to support FastRPC devices
> which do not have dedicated Compute Banks such as the SLPI on the SDM845.
> The latter uses an allocated CMA region instead of FastRPC Compute Banks.
>
> Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
> Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
Reviewed-by: Ekansh Gupta <quic_ekangupt@quicinc.com>
>  drivers/misc/fastrpc.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
> index c06667b29055..f53d20e2e07e 100644
> --- a/drivers/misc/fastrpc.c
> +++ b/drivers/misc/fastrpc.c
> @@ -953,7 +953,10 @@ static int fastrpc_get_args(u32 kernel, struct fastrpc_invoke_ctx *ctx)
>  
>  	ctx->msg_sz = pkt_size;
>  
> -	err = fastrpc_buf_alloc(ctx->fl, dev, pkt_size, &ctx->buf);
> +	if (ctx->fl->sctx->sid)
> +		err = fastrpc_buf_alloc(ctx->fl, dev, pkt_size, &ctx->buf);
> +	else
> +		err = fastrpc_remote_heap_alloc(ctx->fl, dev, pkt_size, &ctx->buf);
>  	if (err)
>  		return err;
>