Received-SPF: pass (google.com: domain of linux-kernel+bounces-209888-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 11 Jun 2024 14:57:17 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
Cc: nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	linux@armlinux.org.uk, vadim.fedorenko@linux.dev,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, git@amd.com
Subject: Re: [PATCH net-next v4 3/4] net: macb: Add ARP support to WOL
Message-ID: <a95e3b77-bdda-428e-9d25-f9be017fd40a@lunn.ch>
References: <20240610053936.622237-1-vineeth.karumanchi@amd.com>
 <20240610053936.622237-4-vineeth.karumanchi@amd.com>
 <b46427d8-2b8c-4b26-b53a-6dcc3d0ea27f@lunn.ch>
 <6c01bed7-580e-4f1a-9986-39c20f063e67@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6c01bed7-580e-4f1a-9986-39c20f063e67@amd.com>

> > > +	/* Don't manage WoL on MAC if there's a failure in talking to the PHY */
> > > +	if (!!ret && ret != -EOPNOTSUPP)
> > >   		return ret;
> > 
> > The comment is wrong. You could be happily talking to the PHY, it just
> > does not support what you asked it to do.
> > 
> 
> 
> These are the 3 possible return scenarios
> 
> 1. -EOPNOTSUPP. : When there is no PHY or no set_wol() in PHY driver.
> 2. 0 : Success
> 3. any error (-EINVAL, ... ) from set_wol()
> 
> we are returning in case 3.
> 
> The comment can be "Don't manage WoL on MAC, if PHY set_wol() fails"

O.K.

You don't need the !! on ret.

	Andrew