Received-SPF: pass (google.com: domain of linux-kernel+bounces-209905-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <5a970f32-25c0-4955-b480-a4738bf86153@kili.mountain>
In-Reply-To: <5a970f32-25c0-4955-b480-a4738bf86153@kili.mountain>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Tue, 11 Jun 2024 15:08:15 +0200
Message-ID: <CACRpkdbSiSpRXGa=eHRgt-8sCgk9ByostgynRYoC1tZY9fUh8A@mail.gmail.com>
Subject: Re: [PATCH] bitops: Add a comment explaining the double underscore macros
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Yury Norov <yury.norov@gmail.com>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, 
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 11, 2024 at 2:38=E2=80=AFPM Dan Carpenter <dan.carpenter@linaro=
.org> wrote:

> Linus Walleij pointed out that a new comer might be confused about the
> difference between set_bit() and __set_bit().  Add a comment explaining
> the difference.
>
> Link: https://lore.kernel.org/all/CACRpkdZFPG_YLici-BmYfk9HZ36f4WavCN3JNo=
tkk8cPgCODCg@mail.gmail.com/
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> v2: re-word the comment, put it right next to the macros and add a blank
>     line in front of the test_bit() macros so it's not mixed in with the
>     non-atomic macros

Thanks Dan! This makes the kernel a better place.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij