Received-SPF: pass (google.com: domain of linux-kernel+bounces-209926-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 11 Jun 2024 15:21:05 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH next-next] net: phy: realtek: add support for rtl8224
 2.5Gbps PHY
Message-ID: <243d5e27-522d-408d-a551-d11073cf330b@lunn.ch>
References: <20240611053415.2111723-1-chris.packham@alliedtelesis.co.nz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240611053415.2111723-1-chris.packham@alliedtelesis.co.nz>

On Tue, Jun 11, 2024 at 05:34:14PM +1200, Chris Packham wrote:
> The Realtek RTL8224 PHY is a 2.5Gbps capable PHY. It only uses the
> clause 45 MDIO interface and can leverage the support that has already
> been added for the other 822x PHYs.
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>

You probably should Cc: Eric Woudstra and Marek Beh?n who have both
worked on 2.5G variants of this PHY.

> Notes:
>     I'm currently testing this on an older kernel because the board I'm
>     using has a SOC/DSA switch that has a driver in openwrt for Linux 5.15.
>     I have tried to selectively back port the bits I need from the other
>     rtl822x work so this should be all that is required for the rtl8224.
>     
>     There's quite a lot that would need forward porting get a working system
>     against a current kernel so hopefully this is small enough that it can
>     land while I'm trying to figure out how to untangle all the other bits.
     
I don't see this as being a problem. It should not be possible to
cause regressions by adding a new device like this. If it turns out to
be broken, you can fix it up later.

	Andrew