Received-SPF: pass (google.com: domain of linux-kernel+bounces-209923-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 11 Jun 2024 14:19:11 +0100
From: Mark Brown <broonie@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: Rui Zhou <zhourui@huaqin.corp-partner.google.com>, lgirdwood@gmail.com,
	perex@perex.cz, tiwai@suse.com, matthias.bgg@gmail.com,
	trevor.wu@mediatek.com, allen-kh.cheng@mediatek.com,
	kuninori.morimoto.gx@renesas.com, maso.huang@mediatek.com,
	linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v1] ASoC: support machine driver with TAS2781
Message-ID: <ZmhOz7BB8eJ38QVE@finisterre.sirena.org.uk>
References: <20240611022227.2508354-1-zhourui@huaqin.corp-partner.google.com>
 <Zmgsfafmfedd9_MV@finisterre.sirena.org.uk>
 <d7d32ef3-8b2e-476c-a15e-7f829ea0d60a@collabora.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="L8C5DHVHxE1pZFLB"
Content-Disposition: inline
In-Reply-To: <d7d32ef3-8b2e-476c-a15e-7f829ea0d60a@collabora.com>


--L8C5DHVHxE1pZFLB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jun 11, 2024 at 02:38:09PM +0200, AngeloGioacchino Del Regno wrote:
> Il 11/06/24 12:52, Mark Brown ha scritto:
> > On Tue, Jun 11, 2024 at 10:22:27AM +0800, Rui Zhou wrote:
> > > Support amp TAS2781 for mt8188 platform

> > > +++ b/sound/soc/mediatek/Kconfig
> > > @@ -233,6 +233,7 @@ config SND_SOC_MT8188_MT6359
> > >   	select SND_SOC_HDMI_CODEC
> > >   	select SND_SOC_DMIC
> > >   	select SND_SOC_MAX98390
> > > +	select SND_SOC_TAS2781_I2C
> > >   	select SND_SOC_NAU8315
> > >   	select SND_SOC_NAU8825

> > Ideally this would be sorted to avoid spurious merge conficts.  Also do
> > we really have dependencies here or should these just be being enabled
> > by users - these drivers are all pretty generic now?

> The only dependency is on the MT6359 PMIC's audio related IPs and nothing else.

> I'd even remove the other select statements for the other codecs, honestly,
> as there's no reason why MT8188 wouldn't support a codec or the other, and
> there is no reason why that SoC needs exactly those codecs, apart from some
> board (Chromebooks) having one, or the other.

Right, that's what I meant - the drivers are now so generic that they
probably shouldn't be selecting everything they could possibly work
with.

> Instead of adding a select statement on MT8188_MT6359, adding the TAS2781_I2C
> driver as a module in defconfig is a better idea..... at least, IMO.

Yes.

> >  Not that this
> > change in itself makes a huge difference to the existing state.

> I agree it doesn't make any huge difference, but I also don't see why users
> can't simply enable (y/m) that in the kernel configuration :-)

I think this is a result of the drivers originally being very specific
to a particular setup and gradually getting made more generic, if the
driver can only be used on a specific machine then the selects make
sense but that's no longer the case for these drivers I think.

--L8C5DHVHxE1pZFLB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZoTs4ACgkQJNaLcl1U
h9C5qQf9G5KuVznYWJOIxmrBhe90rR14xzXQ8iuN/dpwJrplNgIKiv/scP1621jG
KMls3d3XffNozTDEjmE38BVH8H8kpa0pS2A88fKLp9Gv+4lvXMQXrw/XO/oKxkIZ
b5sX+1YNLdebMbKyDzw16JmUenEkZHgSNpxc68bfmxFptlhtqo+0V3ZPkpGlsTCr
i8uIMveI3ySIyxh+nRJHll9qfgqA5YvoHEadaflAnaRhQ6eI9beW9VtbBX3+P02n
IYysSSakV433928mgTzoGvXGTgyJkc9ZV/uF7E5RRntPdqzU+/dEVlvt2wipweI2
LyNOUbLuMhdQXn/GFYSUfFaJBROFdw==
=JJl5
-----END PGP SIGNATURE-----

--L8C5DHVHxE1pZFLB--