Received-SPF: pass (google.com: domain of linux-kernel+bounces-210001-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <d2ffbc2d-0966-4210-a5d0-719c27d9adb1@intel.com>
Date: Tue, 11 Jun 2024 15:50:47 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/6] auxbus: make to_auxiliary_drv accept and return a
 constant pointer
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<linux-kernel@vger.kernel.org>
CC: Dave Ertman <david.m.ertman@intel.com>, Ira Weiny <ira.weiny@intel.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>, Sakari Ailus
	<sakari.ailus@linux.intel.com>, Bingbu Cao <bingbu.cao@intel.com>, "Tianshu
 Qiu" <tian.shu.qiu@intel.com>, Mauro Carvalho Chehab <mchehab@kernel.org>,
	Michael Chan <michael.chan@broadcom.com>, "David S. Miller"
	<davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
	<kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Jesse Brandeburg
	<jesse.brandeburg@intel.com>, Tony Nguyen <anthony.l.nguyen@intel.com>,
	"Saeed Mahameed" <saeedm@nvidia.com>, Leon Romanovsky <leon@kernel.org>,
	Tariq Toukan <tariqt@nvidia.com>, Pierre-Louis Bossart
	<pierre-louis.bossart@linux.intel.com>, Liam Girdwood <lgirdwood@gmail.com>,
	Peter Ujfalusi <peter.ujfalusi@linux.intel.com>, Bard Liao
	<yung-chuan.liao@linux.intel.com>, Ranjani Sridharan
	<ranjani.sridharan@linux.intel.com>, Daniel Baluta <daniel.baluta@nxp.com>,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>, Mark Brown <broonie@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, "Richard
 Cochran" <richardcochran@gmail.com>, <linux-media@vger.kernel.org>,
	<netdev@vger.kernel.org>, <intel-wired-lan@lists.osuosl.org>,
	<linux-rdma@vger.kernel.org>, <sound-open-firmware@alsa-project.org>,
	<linux-sound@vger.kernel.org>
References: <20240611130103.3262749-7-gregkh@linuxfoundation.org>
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Content-Language: en-US
In-Reply-To: <20240611130103.3262749-7-gregkh@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S3BrWFNKRUtORjlxKzZpbGFmWkZSUXdVb1N5U0cxNUh1QVExNVhva0NVNjUr?=
 =?utf-8?B?ZDd2OUtoVHJVcWdFQWVsaWJhZjFudUhiMDlxb2pHVFM1c0dkRjdMZkFScGtl?=
 =?utf-8?B?VlFURFErSS9FZy9tM0JmSVMwRjBVMS9iMDBWeTFBTGRtMElicDdZQ21KTzRI?=
 =?utf-8?B?NmJmRytFRzFZRkVnOXllZHorVHFxbHhSQ1czYnp0ZkpRSit4Kzl1R2MrNzEv?=
 =?utf-8?B?R1dPUlZHRE52WFM5R0oxSStISnRzTHVHclI1NGNTWE9QWGpOSEFhTkhNbG8v?=
 =?utf-8?B?cGhXZ2JPUnpiMGFKeUNuTU94R0lIN3h1TDBGa295R0FEQVpLdXR0TXI1cXlP?=
 =?utf-8?B?Wi9yL1ZYTWdTR0toMExuTXpodk9xYm9ZTXp1cjhVZnM5dENQVThQZWxFNG43?=
 =?utf-8?B?S1lOVEVJalowd2lvMkNmZFlKay9hMXphcXJsOG9wS1drMkJrRlNMd3FoVXJF?=
 =?utf-8?B?RnhSSXJMNkFmUnJuakJFbFJadUNXd1h1ZjRUbERhZlZvTnRoYThKSFIzWk9K?=
 =?utf-8?B?VTJYSXh3K0xrbC9XRmRuV1dpVEE5aXZRZk9YcmJ1MEhweTRYUll0L1ZacHg1?=
 =?utf-8?B?azJaS09rZC9DQ0J5dE5zbGxMZmljQWExYnA2YVppTVpjVEJlSnNtUEx5VzNy?=
 =?utf-8?B?MVFBcnFLVkttbUJrVjRGK2FKWFlNQk1pdHUrdE5YT3o1ZVRxTUcrY3B5Umdn?=
 =?utf-8?B?QytjSXJBVHF3L0VzenNyNHFCSlpldTBSM2J2YVNvZmRyY0lhTDZEMWdDQll6?=
 =?utf-8?B?Z3pRcCtuRzJjbmhTU2VsckorcitjQUJQTGpjamdWa3c2aWR0djRUSmh1QWpO?=
 =?utf-8?B?SEd4S0dESHBrU0xyNC8vSFNDTWl1VDhBRkpiRHYweGRVWDc3TER5dzFobjV3?=
 =?utf-8?B?N1hzendpdWRHTzJFR251ZzhtQjZTek81a2hMMzdwMWd0bmpWYmFrNFM4bWJs?=
 =?utf-8?B?STUwUjU3ZGU0YXc1bWFvZXpPL1oxZ3dpVlBSR2xzYlZoM2phK1RKdkZzZjI4?=
 =?utf-8?B?KzJGR3I3bnNrU3dNKzFsN0FlcjgyMHlpTEc2K0lhVXBJK3l4WTJQT3NQOEpN?=
 =?utf-8?B?aGZMOG96S01lVUh6SFVwTE1jbmkxTGducVpibHQ1OXRuaEFZcDgrRTBsdkZx?=
 =?utf-8?B?MzRlSGJkM2VCZ2ZnRm50ck1LUnc1V0kvb2ZCMS9yVGttLzBWSmM3NTcvclZX?=
 =?utf-8?B?TEtFNU5pejIycXpsejYxanNqU2QrK094dVdyRnk1MGVkT1VERzhZeStUaldZ?=
 =?utf-8?B?dUQ4eWlJdXBSZ2xxUndIaFVEUiswbWloTFdHOUVFVE80eU1LS1VRdTZHc28v?=
 =?utf-8?B?NldFL2ZvMEdNQXB0Rmg5OTAybnQ1M1lrdnFpdGpCN3hjdHJ4OWxwZkhJYjZI?=
 =?utf-8?B?RzEvNUtVU0RJU3MrVmJDcjdoWVl1ZGo3MG9VakkwMi9rUzM3aFZRUnFyVFRJ?=
 =?utf-8?B?dzJrQWhUb3BKNXhLUEFjaGpCLy9wZWVNMzdnbjFUck1jM1BOdGl2c1cyc3o2?=
 =?utf-8?B?ZmpnVkZ0dVZnbTdWcmV3aWZyYkxIZm5INGRhdk85STJXbUprRk8rUis0d2NB?=
 =?utf-8?B?MStYODhlK29oMDAzZHFkelJyY2FRalhQNVlyU0hWc0QreGRVNnBySDZ4WXlp?=
 =?utf-8?B?YlFPcFBPaEV2N0I3eVc2bGIwQ0IzK0UzZXhlUWZpcmlQVWxtVWhZTCtGZVZW?=
 =?utf-8?B?WjVma2pjRkZSNTJyOU1jU0h6UitpUndOMGdKbXliUTRzSEZmYnZ2OUNBQ01w?=
 =?utf-8?B?M3hmUU9wL095VklZMXBYbW96SVRxbWJuL25XOUdkY0lITEtadnZKS0JPU3RH?=
 =?utf-8?B?dmRoRTNHZ2FCYVJDeWcvKzk0R1g5ajhRUFlxMC80Y3J1aUNlYytYVURuM2dC?=
 =?utf-8?B?NDVQMmNNUVhyc3JlN2tjZ0FPVmN4eUlMcFE2SDc2R1Q4V2RqZmNGWHZ6R2d0?=
 =?utf-8?B?eUVZWHNyaEtZR2I2V2lYRFdrWjIyTmJGT1dIdG1venV1NXhaNjBpUlNxL0Ey?=
 =?utf-8?B?RGV2bEZBNTVYZmhTOVZQT21rVS9kRitPMU4wNElGbklHZEw3UVpVUXVoWkJr?=
 =?utf-8?B?VmxBZi9wcGlYU1NiMWNMQ3dyN2ozUmJwdTlINHRnZzJ6dG1zWlgzUG5KTzA4?=
 =?utf-8?B?cUI3WlRQc2NUQjNCL1grU3RKM3A0MnhoUFpHZEpCVmtrOFN4RStzTDhJakx2?=
 =?utf-8?B?UXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: db824e18-8139-4bee-d473-08dc8a1d8657
X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8102.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 13:50:59.4834
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a3kS7QXuFL1bco07ujzs/mHyxWYRAOBGG8px8UaSFmkCgowlPoYqyFg7HBp4RRUXSMeE2KHIMPAsIo562qsSIq4MyqDt2HsXwlJHU4JYJs8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6746
X-OriginatorOrg: intel.com

On 6/11/24 15:01, Greg Kroah-Hartman wrote:
> In the quest to make struct device constant, start by making

just curious, how far it will go? eg. do you plan to convert
get/put_device() to accept const? or convert devlink API to accept
consts?

> to_auziliary_drv() return a constant pointer so that drivers that call

typo: s/auz/aux/

> this can be fixed up before the driver core changes.
> 
> As the return type previously was not constant, also fix up all callers
> that were assuming that the pointer was not going to be a constant one
> in order to not break the build.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


[...]

> diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.c b/drivers/net/ethernet/intel/ice/ice_ptp.c
> index 0f17fc1181d2..7341e7c4ef24 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ptp.c
> +++ b/drivers/net/ethernet/intel/ice/ice_ptp.c
> @@ -2784,7 +2784,7 @@ static struct ice_pf *
>   ice_ptp_aux_dev_to_owner_pf(struct auxiliary_device *aux_dev)
>   {
>   	struct ice_ptp_port_owner *ports_owner;
> -	struct auxiliary_driver *aux_drv;
> +	const struct auxiliary_driver *aux_drv;
>   	struct ice_ptp *owner_ptp;
>   
>   	if (!aux_dev->dev.driver)
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/dev.c b/drivers/net/ethernet/mellanox/mlx5/core/dev.c
> index 47e7c2639774..9a79674d27f1 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/dev.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/dev.c
> @@ -349,7 +349,7 @@ int mlx5_attach_device(struct mlx5_core_dev *dev)
>   {
>   	struct mlx5_priv *priv = &dev->priv;
>   	struct auxiliary_device *adev;
> -	struct auxiliary_driver *adrv;
> +	const struct auxiliary_driver *adrv;

nit: in netdev we do maintain RCT order of initialization

>   	int ret = 0, i;
>   
>   	devl_assert_locked(priv_to_devlink(dev));
> @@ -406,7 +406,7 @@ void mlx5_detach_device(struct mlx5_core_dev *dev, bool suspend)
>   {
>   	struct mlx5_priv *priv = &dev->priv;
>   	struct auxiliary_device *adev;
> -	struct auxiliary_driver *adrv;
> +	const struct auxiliary_driver *adrv;
>   	pm_message_t pm = {};
>   	int i;
>   

[...]