Received-SPF: pass (google.com: domain of linux-kernel+bounces-210005-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <95163ee547da95964c16f87a38d3326ae4da3253.camel@sipsolutions.net>
Subject: Re: iwlwifi: Regression after migrating to 6.6.32
From: Johannes Berg <johannes@sipsolutions.net>
To: Fabio Estevam <festevam@gmail.com>
Cc: miriam.rachel.korenblit@intel.com, kvalo@kernel.org, Jakub Kicinski
	 <kuba@kernel.org>, linux-wireless <linux-wireless@vger.kernel.org>, 
 linux-kernel <linux-kernel@vger.kernel.org>
Date: Tue, 11 Jun 2024 15:54:16 +0200
In-Reply-To: <CAOMZO5Aufe7zAE7TFVprvRreamYd9=RHjybjaEz2O9WaPksV=Q@mail.gmail.com>
References: 
	<CAOMZO5A7+nxACoBPY0k8cOpVQByZtEV_N1489MK5wETHF_RXWA@mail.gmail.com>
	 <3fbb5317d9ff33ef1b60ca8297537335ce86a79d.camel@sipsolutions.net>
	 <CAOMZO5Aufe7zAE7TFVprvRreamYd9=RHjybjaEz2O9WaPksV=Q@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.2 (3.52.2-1.fc40) 
Precedence: bulk
MIME-Version: 1.0

Hi Fabio,

>=20
> I did as suggested:
>=20
> --- a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> @@ -266,7 +266,8 @@ static void iwl_pcie_rxmq_restock(struct iwl_trans *t=
rans,
>                 list_del(&rxb->list);
>                 rxb->invalid =3D false;
>                 /* some low bits are expected to be unset (depending on h=
w) */
> -               WARN_ON(rxb->page_dma & trans_pcie->supported_dma_mask);
> +               WARN_ONCE(rxb->page_dma & trans_pcie->supported_dma_mask,
> +                         "rxb->offset is %d trans_pcie->rx_buf_bytes
> is %d\n", rxb->offset, trans_pcie->rx_buf_bytes);
>=20

> [    5.038174] rxb->offset is 0 trans_pcie->rx_buf_bytes is 4096

so that looks pretty normal?

Might be useful to see rx->page_dma too, supported_dma_mask should be
4095 or 2047 depending on the device, but I'm not sure how you could end
up with a DMA mapping for a page that's not at least 11 bit aligned?

johannes