Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp365082lqp; Tue, 11 Jun 2024 06:58:49 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVkvz501eWA2owcBx/yzty8Td4KnsbrcBH8AuQNwWF72KW+Wah6SMGsDfwIOl8JKS+EQ0xNfUqJEshiayF4mDxEC+4cz4gI2u1df369LA== X-Google-Smtp-Source: AGHT+IEqNa2K881M2m/9aGiFoLTjyWN7RgQCiXFx2cl+fLQzCUhB7Y8xU6t8UBOXbxmqeL95jUGP X-Received: by 2002:a05:6358:71cc:b0:19f:483e:89cc with SMTP id e5c5f4694b2df-19f483e8d5bmr1059858155d.4.1718114329387; Tue, 11 Jun 2024 06:58:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718114329; cv=pass; d=google.com; s=arc-20160816; b=keJX7YuAoDKLa7UALufO0lM+C+yCCMV14Fo7towf6yK2E3y8DLRta3aJV0VE7kMy9d RerG0f0eWflXDiwfybhLL0PdFEZCuazsWP0F+Dyne9xK+/ijxC1CMVbBPWDlZcYxrZCf 4plZ2gXyFaPLnSWQ2uBhBnGFCGu4B6ggaMmJAJglaSHc9FrvshSqK0moHB1/BfNzCd7V EWqfHZMhDoYHAFcZss4OOyefRJ0Vc7LHvoCADfIg4DkxV3su0wj2LtGAu05fzv7KJo4z PbZkZbENs66BQH7fnHKgfoWUGNMrD8Y9F5QDhf6IoabTXoEX0RYkWqaRgLQ/x9qQn8b3 ARjA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=oY6awzPlBOwdA9cCrMMPUY8VS5zNRyrO+A1DIg9/IiU=; fh=Lh+JMPZo65h8qJAnE5jHWvKtvWM25xS7kSTjy8t+qRE=; b=G443M13D8j0o3lsIRa1roHJrKqidZ/5LYw7AgyM5I+2bpUWJx71+NxVwfXQA1LlBXz RnraK0a2WeQqU5y6TyHcCGjWTkCiZGmvlANj7aZZOT0hetRJjoIPdfITHRx+jg3cwvin 631LtAeIEZA8Y4RjPvWZtg0n6o2H45Eyl4Jhl69nN3/eg0WRFNGSvE3RgQgRwgYkiMdV jrsmDL576pDgbGfq+anDJDDjmFPphAqy+Up9PP5cNyH+gBzrBeIW73PY6oioRZxuqeDE H7wfI/zpAOWlk93g4+YMAgqMt5csf6NELLOJ0gbd5CzxE2q+/m5UUJY4V4XACLiO80hs Smxw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-210014-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210014-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 41be03b00d2f7-6e7adb4a3e7si708337a12.256.2024.06.11.06.58.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 06:58:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-210014-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-210014-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210014-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 73A0C287FC6 for ; Tue, 11 Jun 2024 13:57:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D3B5417F37D; Tue, 11 Jun 2024 13:55:37 +0000 (UTC) Received: from mxout70.expurgate.net (mxout70.expurgate.net [194.37.255.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F37B317D8AF; Tue, 11 Jun 2024 13:55:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.37.255.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718114137; cv=none; b=f6GW4tUzsezH67Ze0G8ozVV6I2o2VNuwPLMSnuuHWydp/tXAg3T6+YYanQYHRVsZVK02MMZ65U8Vnhj9hJpELV9hep9Zjp1BlGCrXp6squAthKansAgS6xdyL3KRDIzeLp3STfuQlZUYnEy1kUy2KATRuY03G5izKKfbg8HoPu8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718114137; c=relaxed/simple; bh=taDd5iOXcMi1GDYjC36QIK9CTE076C7/N4X93v5aW10=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gaBsNWIEkwFb7x7hAS8briIRWYT+2FAdbWrALaKh41labEyaV7tKuyeSsjrb/kFGpapIy8iql49sz9dubrqhrCi412r5EiYsbCamvW2kh0BLTg4y8vJPXtbqceBF+blGagyHMfmpwVsk/hPYKWXtWW3P//ISfo8Jaag7qw1cb3w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; arc=none smtp.client-ip=194.37.255.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1sH1yI-002Ydp-6M; Tue, 11 Jun 2024 15:55:34 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sH1yH-00369r-LF; Tue, 11 Jun 2024 15:55:33 +0200 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id 60920240053; Tue, 11 Jun 2024 15:55:33 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id E97C5240050; Tue, 11 Jun 2024 15:55:32 +0200 (CEST) Received: from mschiller1.dev.tdt.de (unknown [10.2.3.20]) by mail.dev.tdt.de (Postfix) with ESMTPSA id B0451376FA; Tue, 11 Jun 2024 15:55:32 +0200 (CEST) From: Martin Schiller To: martin.blumenstingl@googlemail.com, hauke@hauke-m.de, andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ms@dev.tdt.de Subject: [PATCH net-next v5 05/12] net: dsa: lantiq_gswip: Don't manually call gswip_port_enable() Date: Tue, 11 Jun 2024 15:54:27 +0200 Message-ID: <20240611135434.3180973-6-ms@dev.tdt.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240611135434.3180973-1-ms@dev.tdt.de> References: <20240611135434.3180973-1-ms@dev.tdt.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-purgate: clean X-purgate-ID: 151534::1718114134-C1C4D8CF-5F3975C0/0/0 X-purgate-type: clean From: Martin Blumenstingl We don't need to manually call gswip_port_enable() from within gswip_setup() for the CPU port. DSA does this automatically for us. Signed-off-by: Martin Blumenstingl Acked-by: Hauke Mehrtens --- drivers/net/dsa/lantiq_gswip.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswi= p.c index 37cc0247dc78..c1f9419af35f 100644 --- a/drivers/net/dsa/lantiq_gswip.c +++ b/drivers/net/dsa/lantiq_gswip.c @@ -898,8 +898,6 @@ static int gswip_setup(struct dsa_switch *ds) =20 ds->mtu_enforcement_ingress =3D true; =20 - gswip_port_enable(ds, cpu_port, NULL); - ds->configure_vlan_while_not_filtering =3D false; =20 return 0; --=20 2.39.2