Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp366189lqp; Tue, 11 Jun 2024 07:00:24 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW06G4JNf25s4Mkx2DXj7nQV4U7owdlfiWuhjAge3pz4Li3yOTi74drltP1N3UjKo+d10+P+db3W3jdNMsA1/UujtnOWLRhiX+uUG8tNg== X-Google-Smtp-Source: AGHT+IFECptvffH/NNqRBtGm0Vdzsw0sG38x5zEUHRau2nNhxYW8+T7LoREjbW/0vWeMHk9vypcl X-Received: by 2002:a05:620a:270d:b0:794:f722:68f3 with SMTP id af79cd13be357-797c32ad3aemr422669885a.36.1718114424191; Tue, 11 Jun 2024 07:00:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718114424; cv=pass; d=google.com; s=arc-20160816; b=Pl4e4TkFL1WCVYTMiDBxUHaORY7ai6bW/S2y0KkWsHyNWUm6lb6zNz15K8Q5C8e9nm 3zNH6qn9TP28RtP7yePqb8q2q2bve6UJJppNFGnvNUIb7zsDBE6eGKJL6Ctqccc5nsz1 dCZp50nXuhi62OZ2v5n9WkPIXLFhWAWH3Kzlb+W0M/2v7Zgtm76PHQearLlLU8ejufKa GHSP4OktOzIHc31W6rNKoUixh9gvMNkxlmBBHzwuVsn/bZyqP1qmcTwSmmgHrLAPdAut Wj4WsqmT2eoniXbWhHbCVF/BbrPgDmX/tfy0Y+O6+n1Np9sYuQQUQq7t/QYyGun/Ub+1 lDCg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=RKIY9odMZceFUe7am0QXtJvqBYP1H4DpKWwAuSHERxw=; fh=Lh+JMPZo65h8qJAnE5jHWvKtvWM25xS7kSTjy8t+qRE=; b=pTlJ0nwtiDNg+bMxWoxm/VVaK4Hq2FMQm9d2rZoY3PVlTRepWF4qm4PBpep8SuWs6j y1HHqeieWwQEGFL6AY/6rAmBI40gEr+lXyEMXWKNGXh6uN2HC0dE8Kj092FQ1o3IzaU4 yJSf4zSkAFY3gBfcNHJf5/2BNUjAHRwv4DBEC3xrNd1hAd3cheCuPTl1cCl4rjR0an6E S/iK/ilFAuy3LxGBwtw4u4TBBmiMLjgO2IIH9VNFfj3dK0Mv3VHIGE2o6f9vW8QbGSA3 6aU+cLMeW68pFmw5GecNj9tjKISQdafOHXIUO713iitIPf1SPS3fVUJue3mxsgCOLI+o S18w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-210021-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210021-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id af79cd13be357-795601e0e64si585458485a.113.2024.06.11.07.00.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 07:00:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-210021-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-210021-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210021-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 40CEB1C24D8D for ; Tue, 11 Jun 2024 13:59:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 50A94180A81; Tue, 11 Jun 2024 13:56:16 +0000 (UTC) Received: from mxout70.expurgate.net (mxout70.expurgate.net [194.37.255.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CCA217DE3D; Tue, 11 Jun 2024 13:56:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.37.255.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718114175; cv=none; b=uENZAWnXnwgd7YXwS/U/bOiPaFZAYCB9n35EKVvdp/Q+HfSrx7V/ltpPSmpJmSfyL505RSkrb4cvd7+EbdgALBxxGIYO1QOIr/7HP4djiRlgfwkWh79BnBCwjIeSYsVLb7s6E/9sChcRpGUF1gHH9oaN+KCEul2PUTGCDP8JYLo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718114175; c=relaxed/simple; bh=hZekxdzg6/DbdtqVNiroTrOJ0Q1iP2Vz3e229k+G84U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AP5MFf1e2pSfx9WDWtOo8cQwWwFXLO94WKoT8AormZwd3TnIIVWQbQ0MEnHS4k3/blm6N8CyBZ4j/evTYgYBZ++wKSYvJKaFkOjFQKSC9u3EzThy4aW0gz9FoJ3/IG4IcZ9rkZ2sUe0gLmzp2j5RFnfWy4SlJyKo5m71FgX0Jcw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; arc=none smtp.client-ip=194.37.255.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1sH1yu-002Yle-LV; Tue, 11 Jun 2024 15:56:12 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sH1yu-00FJ85-4O; Tue, 11 Jun 2024 15:56:12 +0200 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id D3EA8240053; Tue, 11 Jun 2024 15:56:11 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 68642240050; Tue, 11 Jun 2024 15:56:11 +0200 (CEST) Received: from mschiller1.dev.tdt.de (unknown [10.2.3.20]) by mail.dev.tdt.de (Postfix) with ESMTPSA id 3775B376FA; Tue, 11 Jun 2024 15:56:11 +0200 (CEST) From: Martin Schiller To: martin.blumenstingl@googlemail.com, hauke@hauke-m.de, andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ms@dev.tdt.de Subject: [PATCH net-next v5 12/12] net: dsa: lantiq_gswip: Improve error message in gswip_port_fdb() Date: Tue, 11 Jun 2024 15:54:34 +0200 Message-ID: <20240611135434.3180973-13-ms@dev.tdt.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240611135434.3180973-1-ms@dev.tdt.de> References: <20240611135434.3180973-1-ms@dev.tdt.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-purgate-type: clean X-purgate: clean X-purgate-ID: 151534::1718114172-CF4488CF-D5B94AF4/0/0 From: Martin Blumenstingl Print that no FID is found for bridge %s instead of the incorrect message that the port is not part of a bridge. Signed-off-by: Martin Blumenstingl Acked-by: Hauke Mehrtens --- drivers/net/dsa/lantiq_gswip.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswi= p.c index ec52c62eadce..fcd4505f4925 100644 --- a/drivers/net/dsa/lantiq_gswip.c +++ b/drivers/net/dsa/lantiq_gswip.c @@ -1370,7 +1370,8 @@ static int gswip_port_fdb(struct dsa_switch *ds, in= t port, } =20 if (fid =3D=3D -1) { - dev_err(priv->dev, "Port not part of a bridge\n"); + dev_err(priv->dev, "no FID found for bridge %s\n", + bridge->name); return -EINVAL; } =20 --=20 2.39.2