Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp371100lqp; Tue, 11 Jun 2024 07:05:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW/+G+YiqN/SHgYVlAGmRf6j/YEtOrQ8rpz7vRX6Cy7rb2tXzU0g+FlYHyI8UfAP+zSrtkaSCd0CKsxR5X6kkvpcxNVkb0QnJIT26tdyg== X-Google-Smtp-Source: AGHT+IGnQcAiA7HvYjw1SI8MqR/6AQnDOxgVpdh7Uv6dmFK36qauWYuhDyx+BdLFRlVdo08vOFA+ X-Received: by 2002:a81:6f8a:0:b0:61b:1f0d:838b with SMTP id 00721157ae682-62cd55c5a85mr103969877b3.14.1718114746814; Tue, 11 Jun 2024 07:05:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718114746; cv=pass; d=google.com; s=arc-20160816; b=HfCsZeVunBv1fBfKfuuHssy+WLxxIOLYddR/nlqWlp4Ht0/J/evrHHrNw55YH0GzxK WRDgSoaC/dlo0+MRbV2G0tLldYxJAqDMwnQFuVikvqbhsQeO2YUPPFgPbGEtTNk9H1al krbT2dJstez7Vq3ozgEvoz/BYKJRH5JL6zZw4952BMnBjOdhhYRYlA0+hHVy7Rd6xOqE HeMNIbmQihlKWY1asOZJVxy5iXGZsJoYVkl8gJ9jsKxSvV1wAdMfJSecSazc27BmeHUt IvraacV2co6cXbbqRqdIEms3QefunKyenYNENK2rhYgtvULwdeRIxvXRfB4ency9fa08 cxvA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=Q7vJYI794t8yFOWqw7e9233uWxSZQ5JG1WiKDMH+Ia4=; fh=Lh+JMPZo65h8qJAnE5jHWvKtvWM25xS7kSTjy8t+qRE=; b=K6SG8sR+RdgwOg7+E1FuRiWZbwFtfYIo/1KZBlXzK7U1SzBWpzJnC76VJnDdz6zWPC /SOo1c8r2VXMmQVukT7AQH3WabDW6AVd1fayBQbUs6rz9F0RfNi+se026a/xuNJEmiyT n5Bg4mE8zm8vZ6FuU5rV6gkxsZjS0dvM1xjg6+Vy4kWPxYIQUiWCgTc39NsXMSiPPvs6 RtMBzTG4dhfzTqpNNFKmPB7oZKo9A60XCMvjCTj4CUfpqHG/9m/cBTeUSqyNrPh7HVh0 NY3c3J5ZM4kLZsRPKAO47baldByJ5gWQ+daZLCrOK/CLl/v1qlWF/9cPcnVDX1X1aRb5 7YbQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-210012-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210012-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 00721157ae682-62cead2bdbesi31160907b3.91.2024.06.11.07.05.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 07:05:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-210012-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-210012-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210012-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E6CFB1C2430C for ; Tue, 11 Jun 2024 13:56:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D902117E8F3; Tue, 11 Jun 2024 13:55:27 +0000 (UTC) Received: from mxout70.expurgate.net (mxout70.expurgate.net [194.37.255.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D89E917D8AF; Tue, 11 Jun 2024 13:55:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.37.255.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718114127; cv=none; b=CenWROZvIWcoTH4e9Pg+b+IQOTi7t4T/y19NhcnZbyeSy73OfaM5g9ZhbV36B9O9hFqyG4xFh8NxS+9NTsYsISPu2nxqReIvrAViZ3eyGg71035+A9+9IdK9PGcM1+9kmo8AAZCWHalW0h4+Oa9gk7VYPFjYE1c82N0q4hCtIKU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718114127; c=relaxed/simple; bh=D3oVcUtkTVq+/7cDht2gnLzzOfcwH0UaOWGZGd6x1lY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=joXyuzbyBmvBuGcBCMvCwsVM05rdCJ9DuFE/i/lUc+VI6m2r7nv90IvjMJ4uFEnTduvuNWyS2vyj/RS0SX+RPrdXcf4PMB0LFbKnr8rAr3ymOZFkJ2d7uARZaffYR82JoVEf+EXYsJ9hwvqUp7Lf3g8ofBDASMwhe3J3e+9ih0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; arc=none smtp.client-ip=194.37.255.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1sH1y7-0011gh-KN; Tue, 11 Jun 2024 15:55:23 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sH1y7-00364p-2E; Tue, 11 Jun 2024 15:55:23 +0200 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id C2CE0240053; Tue, 11 Jun 2024 15:55:22 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 5834A240050; Tue, 11 Jun 2024 15:55:22 +0200 (CEST) Received: from mschiller1.dev.tdt.de (unknown [10.2.3.20]) by mail.dev.tdt.de (Postfix) with ESMTPSA id 02A25376FA; Tue, 11 Jun 2024 15:55:22 +0200 (CEST) From: Martin Schiller To: martin.blumenstingl@googlemail.com, hauke@hauke-m.de, andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ms@dev.tdt.de Subject: [PATCH net-next v5 03/12] net: dsa: lantiq_gswip: add terminating \n where missing Date: Tue, 11 Jun 2024 15:54:25 +0200 Message-ID: <20240611135434.3180973-4-ms@dev.tdt.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240611135434.3180973-1-ms@dev.tdt.de> References: <20240611135434.3180973-1-ms@dev.tdt.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-purgate-ID: 151534::1718114123-36936522-CA75D238/0/0 X-purgate-type: clean X-purgate: clean Some dev_err are missing the terminating \n. Let's add that. Suggested-by: Vladimir Oltean Signed-off-by: Martin Schiller Reviewed-by: Andrew Lunn --- drivers/net/dsa/lantiq_gswip.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswi= p.c index b9c7076ce32f..fe64baf0d7f1 100644 --- a/drivers/net/dsa/lantiq_gswip.c +++ b/drivers/net/dsa/lantiq_gswip.c @@ -836,7 +836,7 @@ static int gswip_setup(struct dsa_switch *ds) =20 err =3D gswip_pce_load_microcode(priv); if (err) { - dev_err(priv->dev, "writing PCE microcode failed, %i", err); + dev_err(priv->dev, "writing PCE microcode failed, %i\n", err); return err; } =20 @@ -1792,7 +1792,7 @@ static u32 gswip_bcm_ram_entry_read(struct gswip_pr= iv *priv, u32 table, err =3D gswip_switch_r_timeout(priv, GSWIP_BM_RAM_CTRL, GSWIP_BM_RAM_CTRL_BAS); if (err) { - dev_err(priv->dev, "timeout while reading table: %u, index: %u", + dev_err(priv->dev, "timeout while reading table: %u, index: %u\n", table, index); return 0; } @@ -2021,7 +2021,7 @@ static void gswip_gphy_fw_remove(struct gswip_priv = *priv, =20 ret =3D regmap_write(priv->rcu_regmap, gphy_fw->fw_addr_offset, 0); if (ret) - dev_err(priv->dev, "can not reset GPHY FW pointer"); + dev_err(priv->dev, "can not reset GPHY FW pointer\n"); =20 clk_disable_unprepare(gphy_fw->clk_gate); =20 @@ -2050,7 +2050,7 @@ static int gswip_gphy_fw_list(struct gswip_priv *pr= iv, priv->gphy_fw_name_cfg =3D &xrx200a2x_gphy_data; break; default: - dev_err(dev, "unknown GSWIP version: 0x%x", version); + dev_err(dev, "unknown GSWIP version: 0x%x\n", version); return -ENOENT; } } @@ -2060,7 +2060,7 @@ static int gswip_gphy_fw_list(struct gswip_priv *pr= iv, priv->gphy_fw_name_cfg =3D match->data; =20 if (!priv->gphy_fw_name_cfg) { - dev_err(dev, "GPHY compatible type not supported"); + dev_err(dev, "GPHY compatible type not supported\n"); return -ENOENT; } =20 @@ -2163,7 +2163,7 @@ static int gswip_probe(struct platform_device *pdev= ) return -EINVAL; break; default: - dev_err(dev, "unknown GSWIP version: 0x%x", version); + dev_err(dev, "unknown GSWIP version: 0x%x\n", version); return -ENOENT; } =20 @@ -2191,7 +2191,7 @@ static int gswip_probe(struct platform_device *pdev= ) goto gphy_fw_remove; } if (!dsa_is_cpu_port(priv->ds, priv->hw_info->cpu_port)) { - dev_err(dev, "wrong CPU port defined, HW only supports port: %i", + dev_err(dev, "wrong CPU port defined, HW only supports port: %i\n", priv->hw_info->cpu_port); err =3D -EINVAL; goto disable_switch; --=20 2.39.2