Received-SPF: pass (google.com: domain of linux-kernel+bounces-210033-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 11 Jun 2024 16:05:39 +0200
From: Borislav Petkov <bp@alien8.de>
To: Peter Zijlstra <peterz@infradead.org>, Borislav Petkov <bp@kernel.org>
CC: X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 00/14] x86/alternatives: Nest them
User-Agent: K-9 Mail for Android
In-Reply-To: <20240611132609.GH8774@noisy.programming.kicks-ass.net>
References: <20240607111701.8366-1-bp@kernel.org> <20240611132609.GH8774@noisy.programming.kicks-ass.net>
Message-ID: <7C4F08B2-70C1-4A63-B901-33D197A2BDC4@alien8.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable

On June 11, 2024 3:26:09 PM GMT+02:00, Peter Zijlstra <peterz@infradead=2Eo=
rg> wrote:
>On Fri, Jun 07, 2024 at 01:16:47PM +0200, Borislav Petkov wrote:
>
>> Borislav Petkov (AMD) (13):
>>   x86/alternative: Zap alternative_ternary()
>>   x86/alternative: Convert alternative()
>>   x86/alternative: Convert alternative_2()
>>   x86/alternative: Convert alternative_input()
>>   x86/alternative: Convert alternative_io()
>>   x86/alternative: Convert alternative_call()
>>   x86/alternative: Convert alternative_call_2()
>>   x86/alternative: Convert ALTERNATIVE_TERNARY()
>>   x86/alternative: Convert ALTERNATIVE_3()
>>   x86/alternative: Convert the asm ALTERNATIVE() macro
>>   x86/alternative: Convert the asm ALTERNATIVE_2() macro
>>   x86/alternative: Convert the asm ALTERNATIVE_3() macro
>>   x86/alternative: Replace the old macros
>>=20
>> Peter Zijlstra (1):
>>   x86/alternatives: Add nested alternatives macros
>>=20
>>  arch/x86/include/asm/alternative=2Eh | 225 +++++++++------------------=
--
>>  arch/x86/kernel/alternative=2Ec      |  20 ++-
>>  arch/x86/kernel/fpu/xstate=2Eh       |  14 +-
>>  tools/objtool/arch/x86/special=2Ec   |  23 +++
>>  tools/objtool/special=2Ec            |  16 +-
>>  5 files changed, 125 insertions(+), 173 deletions(-)
>
>The whole back and forth with the n_foo things ia weird, but sure, have
>at=2E
>
>Acked-by: Peter Zijlstra (Intel) <peterz@infradead=2Eorg>

Thanks, yeah it is in the 0th mail:

"For ease of bisection, the old macros are converted to the new, nested
variants in a step-by-step manner so that in case an issue is
encountered during testing, one can pinpoint the place where it fails
easier=2E Because debugging alternatives is a serious pain=2E"

If you remember, your original patch had this issue where it would confuse=
 two back-to-back =2Ealtinstr entries for nested because you were comparing=
 only the offsets and they happened to be equal, by l

Now debugging *that* was insane and I managed to find the issue only when =
I started converting each place one-by-one and booting each one step=2E

That's why this superficial split is all about=2E We will appreciate it la=
ter=2E I hope not but if something explodes, bisection will be a lot easier=
 this way=2E

I hope this makes sense=2E


--=20
Sent from a small device: formatting sucks and brevity is inevitable=2E