Received-SPF: pass (google.com: domain of linux-kernel+bounces-210049-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 11 Jun 2024 16:14:35 +0200
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: Florian Fainelli <florian.fainelli@telecomint.eu>,
	Ralf Baechle <ralf@linux-mips.org>, Phil Sutter <n0-1@freewrt.org>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] MIPS: Routerboard 532: Fix vendor retry check code
Message-ID: <Zmhby7DtfLGVj+8V@alpha.franken.de>
References: <20240508120700.51374-1-ilpo.jarvinen@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240508120700.51374-1-ilpo.jarvinen@linux.intel.com>

On Wed, May 08, 2024 at 03:07:00PM +0300, Ilpo J?rvinen wrote:
> read_config_dword() contains strange condition checking ret for a
> number of values. The ret variable, however, is always zero because
> config_access() never returns anything else. Thus, the retry is always
> taken until number of tries is exceeded.
> 
> The code looks like it wants to check *val instead of ret to see if the
> read gave an error response.
> 
> Fixes: 73b4390fb234 ("[MIPS] Routerboard 532: Support for base system")
> Signed-off-by: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>
> --
> 
> IMPORTANT NOTE TO MAINTAINER:
> 
> This change has potential of breaking something and I don't have HW to
> test this with. I only came across it while going through all PCIBIOS_*
> call chains. Clearly the current code non-sensical so something is not
> right but whether this is the right way to solve the problem, I'm not
> entirely sure because it will make small change into the behavior.

I have rework of this code sitting in one of my development branches
and I didn't spot the bug in the old code, but the new code does
what your fix is doing. So I'm pretty sure this change is correct.

> ---
>  arch/mips/pci/ops-rc32434.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

applied to mips-fixes.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]