Received-SPF: pass (google.com: domain of linux-kernel+bounces-210037-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 11 Jun 2024 22:08:06 +0800
From: Chao Gao <chao.gao@intel.com>
To: Sean Christopherson <seanjc@google.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<daniel.sneddon@linux.intel.com>, <pawan.kumar.gupta@linux.intel.com>, "Zhang
 Chen" <chen.zhang@intel.com>, Paolo Bonzini <pbonzini@redhat.com>, "Thomas
 Gleixner" <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "Borislav
 Petkov" <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
	<x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [RFC PATCH v3 09/10] KVM: VMX: Advertise
 MITI_CTRL_BHB_CLEAR_SEQ_S_SUPPORT
Message-ID: <ZmhaRr5Lr4pOHcm7@chao-email>
References: <20240410143446.797262-1-chao.gao@intel.com>
 <20240410143446.797262-10-chao.gao@intel.com>
 <ZmepkZfLIvj_st5W@google.com>
 <ZmgrkMLuComwPl1X@chao-email>
 <ZmhSeZpyoYxACs-n@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZmhSeZpyoYxACs-n@google.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ze9L/CMsf5KTOGMDOL2QriDaCy71EdF/y9kzsOOxr98m5RUNf75K1odjXlSs?=
 =?us-ascii?Q?3T5Joeq4GRnOgxa1MmPCWGwxGjekrywN9A7VgEMJw+q7nJE7T1EJFJfcFpN7?=
 =?us-ascii?Q?OtkGLZdUGWhzEny27bWiD5WtINR6KMXprRGi87uirsieitsHrjVlamVVQd4D?=
 =?us-ascii?Q?a6Z8kd188HCKBwOJJwujhjPS4nt272RSIwKTX9aBH44qtVYo66XynEWBT08W?=
 =?us-ascii?Q?YJ7+Ply2f4jE01LuvLGtpjOWShYkGpxo6B0aVBI20LPQ9EDepcsijgYseJA7?=
 =?us-ascii?Q?U3JPkFnoqrrQMAdxDc6xApFUglGe9YtHZRgjaFvg6BaR07OJNA2M77VJtWZH?=
 =?us-ascii?Q?vZtezx6ybGVPZKCgLDaUu1JUdUFCYzCuwQPXvvQvR2jCc6mVRsilcRqBPyll?=
 =?us-ascii?Q?W7JKYUObwKqyJm3pnR+TAwm7sRAeenJ57odA7d1msgfzxh947vm6wyEUCpPW?=
 =?us-ascii?Q?beHOsoa/+Njkmw0h/ZweeOC/X0j3B5+l6tPjo83e5FCTCIDr59jd0yaFNPm+?=
 =?us-ascii?Q?jbSbZp0hRWiqsFDD9e2u2ZJ0ELGCTYAMwG3DaMsfOK7dcY7VcV+IHsOtQpU/?=
 =?us-ascii?Q?pLUWviNB7WrOF0D6WkbBYvqjsU28VIYzI8h7ARKclDfQ6PulaQ6fY4fpVXpK?=
 =?us-ascii?Q?ZH7vP001m6bU+oL7UNM+u9Ty0EaGbYub6yduJl8rHncGpxbXrAdsfmv9JbqC?=
 =?us-ascii?Q?VLUh9tgblYbo3W+aIBd/IuQpmtAObXb2NYoxHXtd9jH7GcqQENveAZSI9lM7?=
 =?us-ascii?Q?RPvS+pT6Yee/VTq8hSNanOxKNxumueQ1OGxsW76ih1a7nFaPV+JZAAyoUKlL?=
 =?us-ascii?Q?M2EFRCZ5eLTPIYC2cNXVTWpGvS9sxutyd7DXtV7ab6fbqLtr/Ry4mxDFi8RD?=
 =?us-ascii?Q?atZ8l3+101510hir5WjpfN6a6KSUBBI3RE1wjYpK9nXBEXspJuIa0Th8NOxk?=
 =?us-ascii?Q?X78u2UA8CPMeuHI0DKjXcNs7x0vKh5o4PLgIiJ/ferEMf2c9y0hpUIVS/RYZ?=
 =?us-ascii?Q?OkUzxplz6oZuIewZjscButDFMZBaRmkXDhaylQngT+160eOERYWpKMjIUyf1?=
 =?us-ascii?Q?IuLwLrUEDiEUW3+OcLdtN+Y0M2iI2OWiWJWfTvB6er/L84PGI9xpoBiXslRI?=
 =?us-ascii?Q?LRf+oo747QvpIIvdMbN7xnA8bMn34OnRiNNd6qAB2tFJ2sYcF4Dq3HIgrYMn?=
 =?us-ascii?Q?lACvHWlrTITW52XM3yX4frC80VkwgsBlPn5JEN8bDJbUG3LhTo3pCxUJCi2A?=
 =?us-ascii?Q?pib4hrUe1L5uyFv7hM5xs9oV4nceFSSlPt2QhqGAmODTn8x/JOp+cQSMGi/1?=
 =?us-ascii?Q?RFPO7S7OnnXtgbC5Mk2dXB7H+Kw8RKYHsz0gRl1Xrz3UuqV7E9eiesy6+8J6?=
 =?us-ascii?Q?jc3t/IAEj6sRTIGGWxsc6VQgLtTXEjDuMkq0dd5h6R0ST771f0wjQ3dR4Ysu?=
 =?us-ascii?Q?2ew5B1FYtr0C6mHhmW+KCifGq3ghqu4qcEFla7650YmUewAjNDVe0XwZeZwR?=
 =?us-ascii?Q?0YuT3nVNgu6IB8+pciSpz/NKYbm70c/5iaIF6sNsL96ylzwQywJxJWZgMhCQ?=
 =?us-ascii?Q?bw1IcXa/xJVtLbYDWumKdCY754vRnIFrXXQx8BHh?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fb1657f9-cada-4323-4394-08dc8a1ff09c
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 14:08:16.7228
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +waK+mTT0iWoGNcy8gGskNdrgWgjZl59OWxIHAcQRYvaJMLqZaVCI/L267upe/ErXj7r4eT5bV2C0QwAb+3ntQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6347
X-OriginatorOrg: intel.com

On Tue, Jun 11, 2024 at 06:34:49AM -0700, Sean Christopherson wrote:
>On Tue, Jun 11, 2024, Chao Gao wrote:
>> >I continue find all of this unpalatable.  The guest tells KVM what software
>> >mitigations the guest is using, and then KVM is supposed to translate that into
>> >some hardware functionality?  And merge that with userspace's own overrides?
>> 
>> Yes. It is ugly. I will drop all Intel-defined stuff from KVM. Actually, I
>> wanted to punt to userspace ...
>> 
>> >
>> >Blech.
>> >
>> >With KVM_CAP_FORCE_SPEC_CTRL, I don't see any reason for KVM to support the
>> >Intel-defined virtual MSRs.  If the userspace VMM wants to play nice with the
>> >Intel-defined stuff, then userspace can advertise the MSRs and use an MSR filter
>> >to intercept and "emulate" the MSRs.  They should be set-and-forget MSRs, so
>> >there's no need for KVM to handle them for performance reasons.
>> 
>> ... I had this idea of implementing policy-related stuff in userspace, and I wrote
>> in the cover-letter:
>> 
>> 	"""
>> 	1. the KVM<->userspace ABI defined in patch 1
>> 
>> 	I am wondering if we can allow the userspace to configure the mask
>> 	and the shadow value during guest's lifetime and do it on a vCPU basis.
>> 	this way, in conjunction with "virtual MSRs" or any other interfaces,
>> 	the usespace can adjust hardware mitigations applied to the guest during
>> 	guest's lifetime e.g., for the best performance.
>> 	"""
>
>Gah, sorry, I speed read the cover letter and didn't take the time to process that.
>
>> As said, this requires some tweaks to KVM_CAP_FORCE_SPEC_CTRL, such as making
>> the mask and shadow values adjustable and applicable on a per-vCPU basis. The
>> tweaks are not necessarily for Intel-defined virtual MSRs; if there were other
>> preferable interfaces, they could also benefit from these changes.
>> 
>> Any objections to these tweaks to KVM_CAP_FORCE_SPEC_CTRL?
>
>Why does KVM_CAP_FORCE_SPEC_CTRL need to be per-vCPU?  Won't the CPU bugs and
>mitigations be system-wide / VM-wide?

Because spec_ctrl is per-vCPU and Intel-defined virtual MSRs are also per-vCPU.
i.e., a guest __can__ configure different values to virtual MSRs on different
vCPUs even though a sane guest won't do this. If KVM doesn't want to rule out
the possibility of supporting Intel-defined virtual MSRs in userspace or any
other per-vCPU interfaces, KVM_CAP_FORCE_SPEC_CTRL needs to be per-vCPU.

implementation-wise, being per-vCPU is simpler because, otherwise, once userspace
adjusts the hardware mitigations to enforce, KVM needs to kick all vCPUs. This
will add more complexity.

And IMO, requiring guests to deploy same mitigations on vCPUs is an unnecessary
limitation.