Received-SPF: pass (google.com: domain of linux-kernel+bounces-210041-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <12441f87-6e61-4618-a2f5-a2b2b202b26e@molgen.mpg.de>
Date: Tue, 11 Jun 2024 16:10:32 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 md-6.11 00/12] md: refacotor and some fixes related to
 sync_thread
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: agk@redhat.com, snitzer@kernel.org, mpatocka@redhat.com, song@kernel.org,
 xni@redhat.com, mariusz.tkaczyk@linux.intel.com, dm-devel@lists.linux.dev,
 linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
 yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com
References: <20240611132251.1967786-1-yukuai1@huaweicloud.com>
Content-Language: en-US
From: Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20240611132251.1967786-1-yukuai1@huaweicloud.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Dear Yu,


Thank you for your series.


Am 11.06.24 um 15:22 schrieb Yu Kuai:
> From: Yu Kuai <yukuai3@huawei.com>

It’d be great if you wrote a small summary, what the same fixes are, are 
what patches are that.

Nit: Small typo in the summary/title: refacotor → refactor.

> Changes from v1:
>   - respin on the top of md-6.11 branch
> 
> Changes from RFC:
>   - fix some typos;
>   - add patch 7 to prevent some mdadm tests failure;
>   - add patch 12 to fix BUG_ON() panic by mdadm test 07revert-grow;
> 
> Yu Kuai (12):
>    md: rearrange recovery_flags
>    md: add a new enum type sync_action
>    md: add new helpers for sync_action
>    md: factor out helper to start reshape from action_store()
>    md: replace sysfs api sync_action with new helpers
>    md: remove parameter check_seq for stop_sync_thread()
>    md: don't fail action_store() if sync_thread is not registered
>    md: use new helers in md_do_sync()

hel*p*ers

>    md: replace last_sync_action with new enum type
>    md: factor out helpers for different sync_action in md_do_sync()
>    md: pass in max_sectors for pers->sync_request()
>    md/raid5: avoid BUG_ON() while continue reshape after reassembling
> 
>   drivers/md/dm-raid.c |   2 +-
>   drivers/md/md.c      | 437 ++++++++++++++++++++++++++-----------------
>   drivers/md/md.h      | 124 +++++++++---
>   drivers/md/raid1.c   |   5 +-
>   drivers/md/raid10.c  |   8 +-
>   drivers/md/raid5.c   |  23 ++-
>   6 files changed, 388 insertions(+), 211 deletions(-)


Kind regards,

Paul